[GitHub] [beam] pabloem commented on a change in pull request #12489: [BEAM-6064] Add an option to avoid insert_ids on BQ in exchange for faster insertions

2020-08-11 Thread GitBox
pabloem commented on a change in pull request #12489: URL: https://github.com/apache/beam/pull/12489#discussion_r468843122 ## File path: sdks/python/apache_beam/io/gcp/bigquery.py ## @@ -1048,6 +1055,11 @@ def __init__( to be passed when creating a BigQuery table.

[GitHub] [beam] pabloem commented on a change in pull request #12489: [BEAM-6064] Add an option to avoid insert_ids on BQ in exchange for faster insertions

2020-08-11 Thread GitBox
pabloem commented on a change in pull request #12489: URL: https://github.com/apache/beam/pull/12489#discussion_r468825940 ## File path: sdks/python/apache_beam/io/gcp/bigquery.py ## @@ -304,6 +308,8 @@ def compute_table_name(row): NOTE: This job name template does not have