pskevin commented on a change in pull request #12445:
URL: https://github.com/apache/beam/pull/12445#discussion_r471794678
##
File path: sdks/go/pkg/beam/runners/universal/universal.go
##
@@ -82,6 +82,54 @@ func Execute(ctx context.Context, p *beam.Pipeline) error {
pskevin commented on a change in pull request #12445:
URL: https://github.com/apache/beam/pull/12445#discussion_r471794239
##
File path: sdks/go/pkg/beam/external.go
##
@@ -16,10 +16,151 @@
package beam
import (
+ "context"
+ "fmt"
+
pskevin commented on a change in pull request #12445:
URL: https://github.com/apache/beam/pull/12445#discussion_r471794342
##
File path: sdks/go/pkg/beam/pipeline.go
##
@@ -60,7 +60,8 @@ func (s Scope) String() string {
// Pipelines can safely be executed concurrently.
type
pskevin commented on a change in pull request #12445:
URL: https://github.com/apache/beam/pull/12445#discussion_r471794063
##
File path: sdks/go/pkg/beam/external.go
##
@@ -16,10 +16,151 @@
package beam
import (
+ "context"
+ "fmt"
+
pskevin commented on a change in pull request #12445:
URL: https://github.com/apache/beam/pull/12445#discussion_r471792581
##
File path: sdks/go/examples/xlang/wordcount/xlang_wordcount.go
##
@@ -0,0 +1,107 @@
+// Licensed to the Apache Software Foundation (ASF) under one or
pskevin commented on a change in pull request #12445:
URL: https://github.com/apache/beam/pull/12445#discussion_r465934906
##
File path: sdks/go/pkg/beam/external.go
##
@@ -16,10 +16,144 @@
package beam
import (
+ "context"
+ "fmt"
+
pskevin commented on a change in pull request #12445:
URL: https://github.com/apache/beam/pull/12445#discussion_r465934590
##
File path: sdks/go/pkg/beam/external.go
##
@@ -16,10 +16,144 @@
package beam
import (
+ "context"
+ "fmt"
+
pskevin commented on a change in pull request #12445:
URL: https://github.com/apache/beam/pull/12445#discussion_r465479332
##
File path: sdks/go/pkg/beam/external.go
##
@@ -16,10 +16,151 @@
package beam
import (
+ "context"
+ "fmt"
+
pskevin commented on a change in pull request #12445:
URL: https://github.com/apache/beam/pull/12445#discussion_r465478664
##
File path: sdks/go/pkg/beam/external.go
##
@@ -16,10 +16,151 @@
package beam
import (
+ "context"
+ "fmt"
+
pskevin commented on a change in pull request #12445:
URL: https://github.com/apache/beam/pull/12445#discussion_r465478490
##
File path: sdks/go/examples/xlang/wordcount/xlang_wordcount.go
##
@@ -0,0 +1,100 @@
+package main
Review comment:
Ack.
pskevin commented on a change in pull request #12445:
URL: https://github.com/apache/beam/pull/12445#discussion_r465373887
##
File path: sdks/go/pkg/beam/runners/universal/universal.go
##
@@ -82,6 +82,54 @@ func Execute(ctx context.Context, p *beam.Pipeline) error {
pskevin commented on a change in pull request #12445:
URL: https://github.com/apache/beam/pull/12445#discussion_r465373680
##
File path: sdks/go/pkg/beam/external.go
##
@@ -16,10 +16,151 @@
package beam
import (
+ "context"
+ "fmt"
+
pskevin commented on a change in pull request #12445:
URL: https://github.com/apache/beam/pull/12445#discussion_r465373567
##
File path: sdks/go/pkg/beam/external.go
##
@@ -16,10 +16,151 @@
package beam
import (
+ "context"
+ "fmt"
+
pskevin commented on a change in pull request #12445:
URL: https://github.com/apache/beam/pull/12445#discussion_r465373296
##
File path: sdks/go/pkg/beam/external.go
##
@@ -16,10 +16,151 @@
package beam
import (
+ "context"
+ "fmt"
+
pskevin commented on a change in pull request #12445:
URL: https://github.com/apache/beam/pull/12445#discussion_r465370908
##
File path: sdks/go/examples/xlang/wordcount/xlang_wordcount.go
##
@@ -0,0 +1,100 @@
+package main
+
+import (
+ "context"
+ "flag"
+
pskevin commented on a change in pull request #12445:
URL: https://github.com/apache/beam/pull/12445#discussion_r465370813
##
File path: sdks/go/examples/xlang/wordcount/xlang_wordcount.go
##
@@ -0,0 +1,100 @@
+package main
+
+import (
+ "context"
+ "flag"
+
pskevin commented on a change in pull request #12445:
URL: https://github.com/apache/beam/pull/12445#discussion_r465365506
##
File path: sdks/go/examples/xlang/wordcount/xlang_wordcount.go
##
@@ -0,0 +1,100 @@
+package main
+
+import (
+ "context"
+ "flag"
+
pskevin commented on a change in pull request #12445:
URL: https://github.com/apache/beam/pull/12445#discussion_r465365206
##
File path: sdks/go/examples/xlang/wordcount/xlang_wordcount.go
##
@@ -0,0 +1,100 @@
+package main
+
+import (
+ "context"
+ "flag"
+
pskevin commented on a change in pull request #12445:
URL: https://github.com/apache/beam/pull/12445#discussion_r465361934
##
File path: sdks/python/Pipfile
##
@@ -0,0 +1,12 @@
+[[source]]
+name = "pypi"
Review comment:
Resolving since this was caused due to botched
pskevin commented on a change in pull request #12445:
URL: https://github.com/apache/beam/pull/12445#discussion_r465361243
##
File path: sdks/go/examples/xlang/wordcount/xlang_wordcount.go
##
@@ -0,0 +1,100 @@
+package main
Review comment:
Ack.
pskevin commented on a change in pull request #12445:
URL: https://github.com/apache/beam/pull/12445#discussion_r465361018
##
File path: sdks/go/examples/xlang/wordcount/input
##
@@ -0,0 +1,5 @@
+Lorem ipsum dolor sit amet, consectetur adipiscing elit. Mauris id tellus
pskevin commented on a change in pull request #12445:
URL: https://github.com/apache/beam/pull/12445#discussion_r465360901
##
File path:
runners/core-construction-java/src/test/java/org/apache/beam/runners/core/construction/ValidateRunnerXlangTest.java
##
@@ -177,6 +232,14 @@
22 matches
Mail list logo
