[GitHub] [beam] rworley-monster commented on pull request #12389: [BEAM-10587] Support Maps in BigQuery

2020-10-15 Thread GitBox
rworley-monster commented on pull request #12389: URL: https://github.com/apache/beam/pull/12389#issuecomment-708978442 Thanks, feel free to squash, I think all of the changes are a logical unit. This is an automated message

[GitHub] [beam] rworley-monster commented on pull request #12389: [BEAM-10587] Support Maps in BigQuery

2020-10-14 Thread GitBox
rworley-monster commented on pull request #12389: URL: https://github.com/apache/beam/pull/12389#issuecomment-708359843 Based on feedback from the dev list, I have added a `SchemaConversionOptions` class with the option to infer maps when converting a BigQuery `TableSchema` to a Beam

[GitHub] [beam] rworley-monster commented on pull request #12389: [BEAM-10587] Support Maps in BigQuery

2020-10-09 Thread GitBox
rworley-monster commented on pull request #12389: URL: https://github.com/apache/beam/pull/12389#issuecomment-706094339 I have written to the dev list and we will see how the conversation goes about the implicit conversion. And I will attempt to add the BigQuery integration test.

[GitHub] [beam] rworley-monster commented on pull request #12389: [BEAM-10587] Support Maps in BigQuery

2020-10-09 Thread GitBox
rworley-monster commented on pull request #12389: URL: https://github.com/apache/beam/pull/12389#issuecomment-706094339 I have written to the dev list and we will see how the conversation goes about the implicit conversion. And I will attempt to add the BigQuery integration test.

[GitHub] [beam] rworley-monster commented on pull request #12389: [BEAM-10587] Support Maps in BigQuery

2020-09-18 Thread GitBox
rworley-monster commented on pull request #12389: URL: https://github.com/apache/beam/pull/12389#issuecomment-695080557 I have added tests for the conversion of Beam schema maps to BigQuery and back. Can you please let me know if there is anything else that I can do to help prepare this

[GitHub] [beam] rworley-monster commented on pull request #12389: [BEAM-10587] Support Maps in BigQuery

2020-08-14 Thread GitBox
rworley-monster commented on pull request #12389: URL: https://github.com/apache/beam/pull/12389#issuecomment-674139020 I have added support for reading BigQuery map records back into Beam Schema and Row. Can you please confirm that I am on the right track and let me know if there are

[GitHub] [beam] rworley-monster commented on pull request #12389: [BEAM-10587] Support Maps in BigQuery

2020-08-07 Thread GitBox
rworley-monster commented on pull request #12389: URL: https://github.com/apache/beam/pull/12389#issuecomment-670381949 Yes, it's in progress, but temporarily preempted by a higher priority task. I hope to get back to it and add the follow-up commit next week.

[GitHub] [beam] rworley-monster commented on pull request #12389: [BEAM-10587] Support Maps in BigQuery

2020-07-29 Thread GitBox
rworley-monster commented on pull request #12389: URL: https://github.com/apache/beam/pull/12389#issuecomment-664974133 This is an automated message from the Apache Git Service. To respond to the message, please log on to