[GitHub] [beam] tvalentyn commented on pull request #11707: [BEAM-9810] Add a Tox (precommit) suite for Python 3.8

2020-05-27 Thread GitBox
tvalentyn commented on pull request #11707: URL: https://github.com/apache/beam/pull/11707#issuecomment-634783915 Yes - feel free to self-merge once Python precommits pass. Just checking that they still work after Jenkins changes.

[GitHub] [beam] tvalentyn commented on pull request #11707: [BEAM-9810] Add a Tox (precommit) suite for Python 3.8

2020-05-27 Thread GitBox
tvalentyn commented on pull request #11707: URL: https://github.com/apache/beam/pull/11707#issuecomment-634783372 Run Python PreCommit This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] tvalentyn commented on pull request #11707: [BEAM-9810] Add a Tox (precommit) suite for Python 3.8

2020-05-20 Thread GitBox
tvalentyn commented on pull request #11707: URL: https://github.com/apache/beam/pull/11707#issuecomment-631622571 Thanks! Let's merge this once BEAM-9994 is closed. I will add comments there. This is an automated message

[GitHub] [beam] tvalentyn commented on pull request #11707: [BEAM-9810] Add a Tox (precommit) suite for Python 3.8

2020-05-19 Thread GitBox
tvalentyn commented on pull request #11707: URL: https://github.com/apache/beam/pull/11707#issuecomment-631067325 The code change LGTM, thank you. We need to address BEAM-9994 before we can merge this. Would you have time to investigate & recommend a solution for that issue, @kamilwu ?

[GitHub] [beam] tvalentyn commented on pull request #11707: [BEAM-9810] Add a Tox (precommit) suite for Python 3.8

2020-05-15 Thread GitBox
tvalentyn commented on pull request #11707: URL: https://github.com/apache/beam/pull/11707#issuecomment-629456098 re: > I didn't change py37-lint to py38-lint, because this requires updating dependencies (for example, our current version of pycodestyle doesn't support Python 3.8