riteshghorse merged PR #30677:
URL: https://github.com/apache/beam/pull/30677
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
riteshghorse commented on PR #30677:
URL: https://github.com/apache/beam/pull/30677#issuecomment-2026361574
All tests passed. Unrelated test failure in Py Coverage. Merging this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
riteshghorse commented on PR #30677:
URL: https://github.com/apache/beam/pull/30677#issuecomment-2025926637
All tests passed
https://github.com/apache/beam/assets/25881114/7028399a-fdb5-48e1-a2bd-b5d6ef1551f5;>
riteshghorse commented on PR #30677:
URL: https://github.com/apache/beam/pull/30677#issuecomment-2023905104
> What tests are exercising this dependency?
Good catch. there are 2 enrichment tests using redis. I'll drop the
requirements file for them and rerun again
--
This is an
tvalentyn commented on PR #30677:
URL: https://github.com/apache/beam/pull/30677#issuecomment-2023329061
What tests are exercising this dependency?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
tvalentyn commented on code in PR #30677:
URL: https://github.com/apache/beam/pull/30677#discussion_r1539458372
##
sdks/python/setup.py:
##
@@ -392,6 +392,7 @@ def get_portability_package_data():
'pydot>=1.2.0,<2',
'python-dateutil>=2.8.0,<3',
github-actions[bot] commented on PR #30677:
URL: https://github.com/apache/beam/pull/30677#issuecomment-2020522970
Assigning reviewers. If you would like to opt out of this review, comment
`assign to next reviewer`:
R: @tvalentyn for label python.
R: @damccorm for label build.
codecov[bot] commented on PR #30677:
URL: https://github.com/apache/beam/pull/30677#issuecomment-2019339940
##
[Codecov](https://app.codecov.io/gh/apache/beam/pull/30677?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
Report
All
riteshghorse opened a new pull request, #30677:
URL: https://github.com/apache/beam/pull/30677
With the addition of redis cache support to the Enrichment transform, it
will be good to package redis client dependency with apache-beam package.
Otherwise user will have to install it
