Abacn merged PR #31969:
URL: https://github.com/apache/beam/pull/31969
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.or
Abacn commented on PR #31969:
URL: https://github.com/apache/beam/pull/31969#issuecomment-2258429615
PreCommit YAML Xlang Direct fails with slf4jlogger classDefNotFoundError.
Test passed on an earlier commit and the change later on are trivial naming
changes. Likely bad gradle cache and mer
tvalentyn commented on code in PR #31969:
URL: https://github.com/apache/beam/pull/31969#discussion_r1695724254
##
sdks/python/apache_beam/metrics/cells.py:
##
@@ -553,3 +610,22 @@ def combine(self, x, y):
def result(self, x):
# type: (GaugeData) -> GaugeResult
retu
Abacn commented on code in PR #31969:
URL: https://github.com/apache/beam/pull/31969#discussion_r1695691559
##
sdks/python/apache_beam/runners/portability/portable_runner.py:
##
@@ -437,15 +437,16 @@ def _combine(committed, attempted, filter):
]
def query(self, filter=
Abacn commented on code in PR #31969:
URL: https://github.com/apache/beam/pull/31969#discussion_r1695686529
##
sdks/python/apache_beam/metrics/monitoring_infos.py:
##
@@ -67,10 +72,12 @@
common_urns.monitoring_info_types.DISTRIBUTION_INT64_TYPE.urn)
LATEST_INT64_TYPE = com
Abacn commented on code in PR #31969:
URL: https://github.com/apache/beam/pull/31969#discussion_r1695685802
##
sdks/python/apache_beam/metrics/cells.py:
##
@@ -268,6 +268,63 @@ def to_runner_api_monitoring_info_impl(self, name,
transform_id):
ptransform=transform_id)
Abacn commented on code in PR #31969:
URL: https://github.com/apache/beam/pull/31969#discussion_r1695682193
##
sdks/python/apache_beam/metrics/cells.py:
##
@@ -553,3 +610,22 @@ def combine(self, x, y):
def result(self, x):
# type: (GaugeData) -> GaugeResult
return G
tvalentyn commented on code in PR #31969:
URL: https://github.com/apache/beam/pull/31969#discussion_r1695656913
##
sdks/python/apache_beam/runners/portability/portable_runner.py:
##
@@ -437,15 +437,16 @@ def _combine(committed, attempted, filter):
]
def query(self, fil
Abacn commented on PR #31969:
URL: https://github.com/apache/beam/pull/31969#issuecomment-2256236377
R: @tvalentyn @robertwb
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
github-actions[bot] commented on PR #31969:
URL: https://github.com/apache/beam/pull/31969#issuecomment-2250340339
Stopping reviewer notifications for this pull request: review requested by
someone other than the bot, ceding control. If you'd like to restart, comment
`assign set of reviewer
Abacn commented on PR #31969:
URL: https://github.com/apache/beam/pull/31969#issuecomment-2250337712
R: @robertwb
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubsc
github-actions[bot] commented on PR #31969:
URL: https://github.com/apache/beam/pull/31969#issuecomment-2249064220
Checks are failing. Will not request review until checks are succeeding. If
you'd like to override that behavior, comment `assign set of reviewers`
--
This is an automated me
Abacn opened a new pull request, #31969:
URL: https://github.com/apache/beam/pull/31969
**Please** add a meaningful description for your change here
Direct runner and Flink runner (loopback) working. For Dataflow runner,
needs to regenerate apiclient, will be done in a separate PR
13 matches
Mail list logo
