scwhittle merged PR #30672:
URL: https://github.com/apache/beam/pull/30672
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
dmitryor commented on PR #30672:
URL: https://github.com/apache/beam/pull/30672#issuecomment-2043539547
I rebased to recent `main` and tests are passing now. I suspect the previous
failure was a flake.
--
This is an automated message from the Apache Git Service.
To respond to the
scwhittle commented on PR #30672:
URL: https://github.com/apache/beam/pull/30672#issuecomment-2036657711
Will merge if retriggered tests pass
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
scwhittle closed pull request #30672: Correct per-entry HashMap overhead in
WindmillStateCache
URL: https://github.com/apache/beam/pull/30672
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
scwhittle commented on PR #30672:
URL: https://github.com/apache/beam/pull/30672#issuecomment-2006346607
> Task :runners:google-cloud-dataflow-java:worker:test
org.apache.beam.runners.dataflow.worker.windmill.state.WindmillStateCacheTest >
testBasic FAILED
github-actions[bot] commented on PR #30672:
URL: https://github.com/apache/beam/pull/30672#issuecomment-2006009059
Stopping reviewer notifications for this pull request: review requested by
someone other than the bot, ceding control
--
This is an automated message from the Apache Git
dmitryor commented on PR #30672:
URL: https://github.com/apache/beam/pull/30672#issuecomment-2006005444
R: @scwhittle
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
dmitryor opened a new pull request, #30672:
URL: https://github.com/apache/beam/pull/30672
Existing code incorrectly assumes a per-entry HashMap overhead is 16 bytes.
In reality it's 32 bytes [per this
article](https://appsintheopen.com/posts/52-the-memory-overhead-of-java-ojects),
