Re: [PR] Deduplicate common environments. [beam]

2024-03-26 Thread via GitHub
robertwb merged PR #30681: URL: https://github.com/apache/beam/pull/30681 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Deduplicate common environments. [beam]

2024-03-26 Thread via GitHub
robertwb commented on PR #30681: URL: https://github.com/apache/beam/pull/30681#issuecomment-2021072479 Just trying to ensure everything is green. Looks like WordCountIT.test_wordcount_it failed with `QUOTA_EXCEEDED: Instance 'beamapp-runner-0325174918-03251049-a16z-harness-8857'

Re: [PR] Deduplicate common environments. [beam]

2024-03-26 Thread via GitHub
aaltay commented on PR #30681: URL: https://github.com/apache/beam/pull/30681#issuecomment-2020981060 Is this ready to be merged? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Deduplicate common environments. [beam]

2024-03-22 Thread via GitHub
codecov[bot] commented on PR #30681: URL: https://github.com/apache/beam/pull/30681#issuecomment-2015602340 ## [Codecov](https://app.codecov.io/gh/apache/beam/pull/30681?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report

Re: [PR] Deduplicate common environments. [beam]

2024-03-21 Thread via GitHub
chamikaramj commented on code in PR #30681: URL: https://github.com/apache/beam/pull/30681#discussion_r1534859758 ## sdks/python/apache_beam/runners/common_test.py: ## @@ -584,5 +587,37 @@ def test_window_observing_split_on_window_boundary_round_down_on_last_window(

Re: [PR] Deduplicate common environments. [beam]

2024-03-21 Thread via GitHub
robertwb commented on code in PR #30681: URL: https://github.com/apache/beam/pull/30681#discussion_r1534772640 ## sdks/python/apache_beam/runners/common.py: ## @@ -1941,3 +1945,64 @@ def validate_transform(transform_id): for t in pipeline_proto.root_transform_ids:

Re: [PR] Deduplicate common environments. [beam]

2024-03-21 Thread via GitHub
robertwb commented on code in PR #30681: URL: https://github.com/apache/beam/pull/30681#discussion_r1534772378 ## sdks/python/apache_beam/runners/common.py: ## @@ -1941,3 +1945,64 @@ def validate_transform(transform_id): for t in pipeline_proto.root_transform_ids:

Re: [PR] Deduplicate common environments. [beam]

2024-03-20 Thread via GitHub
scwhittle commented on code in PR #30681: URL: https://github.com/apache/beam/pull/30681#discussion_r1531597620 ## sdks/python/apache_beam/runners/common.py: ## @@ -1941,3 +1945,64 @@ def validate_transform(transform_id): for t in pipeline_proto.root_transform_ids:

Re: [PR] Deduplicate common environments. [beam]

2024-03-19 Thread via GitHub
robertwb commented on code in PR #30681: URL: https://github.com/apache/beam/pull/30681#discussion_r1531179623 ## sdks/python/apache_beam/runners/common.py: ## @@ -1941,3 +1945,64 @@ def validate_transform(transform_id): for t in pipeline_proto.root_transform_ids:

Re: [PR] Deduplicate common environments. [beam]

2024-03-19 Thread via GitHub
chamikaramj commented on code in PR #30681: URL: https://github.com/apache/beam/pull/30681#discussion_r1531155798 ## sdks/python/apache_beam/runners/common.py: ## @@ -1941,3 +1945,64 @@ def validate_transform(transform_id): for t in pipeline_proto.root_transform_ids:

Re: [PR] Deduplicate common environments. [beam]

2024-03-19 Thread via GitHub
github-actions[bot] commented on PR #30681: URL: https://github.com/apache/beam/pull/30681#issuecomment-2008172678 Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control -- This is an automated message from the Apache Git

Re: [PR] Deduplicate common environments. [beam]

2024-03-19 Thread via GitHub
robertwb commented on PR #30681: URL: https://github.com/apache/beam/pull/30681#issuecomment-2008171114 R: @chamikaramj -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[PR] Deduplicate common environments. [beam]

2024-03-19 Thread via GitHub
robertwb opened a new pull request, #30681: URL: https://github.com/apache/beam/pull/30681 This can be especially useful for those pipelines with many cross-language transforms. Thank you for your contribution! Follow this checklist to help us