Re: [PR] Fix coder parsing for any non-standard composite coder types [beam]

2025-04-10 Thread via GitHub
lostluck merged PR #34606: URL: https://github.com/apache/beam/pull/34606 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache

Re: [PR] Fix coder parsing for any non-standard composite coder types [beam]

2025-04-10 Thread via GitHub
lostluck commented on PR #34606: URL: https://github.com/apache/beam/pull/34606#issuecomment-2795170659 Confirmed that test_pack_combiners runs and succeeds! The current failure seems like an unrelated flake, but we should re-run that to be sure, before merging in. -- This is an automate

Re: [PR] Fix coder parsing for any non-standard composite coder types [beam]

2025-04-10 Thread via GitHub
shunping commented on PR #34606: URL: https://github.com/apache/beam/pull/34606#issuecomment-2795122751 > We need to also un-skip the packed coders test in Python with this PR. Basically delete the overload test_pack_combiners here: https://github.com/apache/beam/blob/master/sdks/python/apa

Re: [PR] Fix coder parsing for any non-standard composite coder types [beam]

2025-04-10 Thread via GitHub
lostluck commented on PR #34606: URL: https://github.com/apache/beam/pull/34606#issuecomment-2795072385 We need to also un-skip the packed coders test in Python with this PR. Basically delete the overload test_pack_combiners here: https://github.com/apache/beam/blob/master/sdks/python/apach

Re: [PR] Fix coder parsing for any non-standard composite coder types [beam]

2025-04-10 Thread via GitHub
github-actions[bot] commented on PR #34606: URL: https://github.com/apache/beam/pull/34606#issuecomment-2795044848 Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`: R: @lostluck for label go. Available commands: - `stop revi

[PR] Fix coder parsing for any non-standard composite coder types [beam]

2025-04-10 Thread via GitHub
shunping opened a new pull request, #34606: URL: https://github.com/apache/beam/pull/34606 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-ma