Re: [PR] Iceberg SchemaTransforms and Translation [beam]

2024-04-16 Thread via GitHub
ahmedabu98 commented on code in PR #30910: URL: https://github.com/apache/beam/pull/30910#discussion_r1568193684 ## sdks/java/managed/src/main/java/org/apache/beam/sdk/managed/Managed.java: ## @@ -108,8 +107,8 @@ public static ManagedTransform read(String source) { }

Re: [PR] Iceberg SchemaTransforms and Translation [beam]

2024-04-16 Thread via GitHub
ahmedabu98 commented on code in PR #30910: URL: https://github.com/apache/beam/pull/30910#discussion_r1568193214 ## sdks/java/io/iceberg/src/main/java/org/apache/beam/io/iceberg/IcebergIOTranslation.java: ## @@ -0,0 +1,241 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Iceberg SchemaTransforms and Translation [beam]

2024-04-16 Thread via GitHub
ahmedabu98 commented on code in PR #30910: URL: https://github.com/apache/beam/pull/30910#discussion_r1568193051 ## sdks/java/io/iceberg/src/main/java/org/apache/beam/io/iceberg/IcebergIOTranslation.java: ## @@ -0,0 +1,241 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Iceberg SchemaTransforms and Translation [beam]

2024-04-16 Thread via GitHub
ahmedabu98 commented on code in PR #30910: URL: https://github.com/apache/beam/pull/30910#discussion_r1568192720 ## sdks/java/io/iceberg/src/main/java/org/apache/beam/io/iceberg/IcebergIO.java: ## @@ -19,73 +19,116 @@ import static

Re: [PR] Iceberg SchemaTransforms and Translation [beam]

2024-04-16 Thread via GitHub
ahmedabu98 commented on code in PR #30910: URL: https://github.com/apache/beam/pull/30910#discussion_r1568192121 ## model/pipeline/src/main/proto/org/apache/beam/model/pipeline/v1/schema_aware_transforms.proto: ## @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache Software

Re: [PR] Iceberg SchemaTransforms and Translation [beam]

2024-04-16 Thread via GitHub
ahmedabu98 commented on code in PR #30910: URL: https://github.com/apache/beam/pull/30910#discussion_r1568192121 ## model/pipeline/src/main/proto/org/apache/beam/model/pipeline/v1/schema_aware_transforms.proto: ## @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache Software

Re: [PR] Iceberg SchemaTransforms and Translation [beam]

2024-04-16 Thread via GitHub
chamikaramj commented on code in PR #30910: URL: https://github.com/apache/beam/pull/30910#discussion_r1568031375 ## model/pipeline/src/main/proto/org/apache/beam/model/pipeline/v1/schema_aware_transforms.proto: ## @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache Software