Re: [PR] Support ValueProvider for _CustomBigQueryStorageSource [beam]

2024-03-19 Thread via GitHub
Abacn merged PR #30662: URL: https://github.com/apache/beam/pull/30662 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Support ValueProvider for _CustomBigQueryStorageSource [beam]

2024-03-18 Thread via GitHub
Abacn commented on PR #30662: URL: https://github.com/apache/beam/pull/30662#issuecomment-2004618077 PreCommit Python Coverage stucks executing `:sdks:python:test-suites:tox:py38:testPy38tft-113` trying again -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] Support ValueProvider for _CustomBigQueryStorageSource [beam]

2024-03-18 Thread via GitHub
robertwb commented on PR #30662: URL: https://github.com/apache/beam/pull/30662#issuecomment-2004578186 Sure, and I'm not opposing this change now that's it's been implemented and approved, but the preferred workaround is to use flex templates instead. -- This is an automated message

Re: [PR] Support ValueProvider for _CustomBigQueryStorageSource [beam]

2024-03-18 Thread via GitHub
liferoad commented on PR #30662: URL: https://github.com/apache/beam/pull/30662#issuecomment-2004566895 > FWIW, now that we have flex templates, I don't think we should be propagating `ValueProvider`s more places than they already are. (IMHO, it'd be preferable to finally deprecate and

Re: [PR] Support ValueProvider for _CustomBigQueryStorageSource [beam]

2024-03-18 Thread via GitHub
robertwb commented on PR #30662: URL: https://github.com/apache/beam/pull/30662#issuecomment-2004547641 FWIW, now that we have flex templates, I don't think we should be propagating `ValueProvider`s more places than they already are. (IMHO, it'd be preferable to finally deprecate and

Re: [PR] Support ValueProvider for _CustomBigQueryStorageSource [beam]

2024-03-18 Thread via GitHub
github-actions[bot] commented on PR #30662: URL: https://github.com/apache/beam/pull/30662#issuecomment-2004234732 Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`: R: @jrmccluskey for label python. R: @Abacn for label io.

[PR] Support ValueProvider for _CustomBigQueryStorageSource [beam]

2024-03-18 Thread via GitHub
liferoad opened a new pull request, #30662: URL: https://github.com/apache/beam/pull/30662 Following https://stackoverflow.com/questions/67441316/attributeerror-runtimevalueprovider-object-has-no-attribute-projectid, we need to support ValueProvider for _CustomBigQueryStorageSource