pabloem commented on pull request #11596:
URL: https://github.com/apache/beam/pull/11596#issuecomment-631522462
Run Java postcommit
This is an automated message from the Apache Git Service.
To respond to the message, please
pabloem commented on pull request #11339:
URL: https://github.com/apache/beam/pull/11339#issuecomment-631583545
Run Java PostCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
pabloem commented on pull request #11339:
URL: https://github.com/apache/beam/pull/11339#issuecomment-631583361
Run Java PostCommit
This is an automated message from the Apache Git Service.
To respond to the message,
pabloem commented on pull request #11596:
URL: https://github.com/apache/beam/pull/11596#issuecomment-631583181
Retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
pabloem commented on pull request #11596:
URL: https://github.com/apache/beam/pull/11596#issuecomment-631598650
Run Java PostCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
tvalentyn commented on pull request #11707:
URL: https://github.com/apache/beam/pull/11707#issuecomment-631622571
Thanks! Let's merge this once BEAM-9994 is closed. I will add comments there.
This is an automated message
chamikaramj commented on pull request #11757:
URL: https://github.com/apache/beam/pull/11757#issuecomment-631637932
Run Python PreCommit
This is an automated message from the Apache Git Service.
To respond to the message,
pulasthi commented on a change in pull request #10888:
URL: https://github.com/apache/beam/pull/10888#discussion_r428226234
##
File path:
runners/twister2/src/main/java/org/apache/beam/runners/twister2/Twister2LegacyRunner.java
##
@@ -0,0 +1,339 @@
+/*
+ * Licensed to the
nielm commented on a change in pull request #11529:
URL: https://github.com/apache/beam/pull/11529#discussion_r428235563
##
File path:
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/spanner/SpannerIOWriteTest.java
##
@@ -263,6 +263,17 @@ private
TheNeuralBit commented on pull request #11754:
URL: https://github.com/apache/beam/pull/11754#issuecomment-631665220
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message,
lukecwik commented on a change in pull request #11746:
URL: https://github.com/apache/beam/pull/11746#discussion_r428246537
##
File path:
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/state/StateBackedIterable.java
##
@@ -0,0 +1,223 @@
+/*
+ * Licensed to the
chamikaramj commented on pull request #11360:
URL: https://github.com/apache/beam/pull/11360#issuecomment-631668418
LGTM. Thanks.
This is an automated message from the Apache Git Service.
To respond to the message, please
chamikaramj commented on pull request #11360:
URL: https://github.com/apache/beam/pull/11360#issuecomment-631668518
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
youngoli commented on pull request #11763:
URL: https://github.com/apache/beam/pull/11763#issuecomment-631668755
R: @lostluck
This is an automated message from the Apache Git Service.
To respond to the message, please log
TheNeuralBit commented on pull request #11529:
URL: https://github.com/apache/beam/pull/11529#issuecomment-631668950
Retest this please
This is an automated message from the Apache Git Service.
To respond to the message,
nielm commented on a change in pull request #11529:
URL: https://github.com/apache/beam/pull/11529#discussion_r428246820
##
File path:
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/spanner/SpannerIOWriteTest.java
##
@@ -263,6 +263,17 @@ private
youngoli opened a new pull request #11763:
URL: https://github.com/apache/beam/pull/11763
Pretty simple. Moves some commonly desired behaviors out of the SDF
code and into the offset range tracker/restriction code + adds tests.
Thank you for your
nielm removed a comment on pull request #11529:
URL: https://github.com/apache/beam/pull/11529#issuecomment-630491891
Retest this please
This is an automated message from the Apache Git Service.
To respond to the message,
chamikaramj commented on pull request #11360:
URL: https://github.com/apache/beam/pull/11360#issuecomment-631669059
I can "squash and merge" after tests pass.
Feel free to squash/fixup commits if you need more than one commit.
nielm commented on pull request #11529:
URL: https://github.com/apache/beam/pull/11529#issuecomment-631668908
Retest this please
This is an automated message from the Apache Git Service.
To respond to the message,
epicfaace opened a new pull request #11760:
URL: https://github.com/apache/beam/pull/11760
Fix grammar / spelling in code comments. R: @kamilwu
Post-Commit Tests Status (on master branch)
veblush commented on pull request #11651:
URL: https://github.com/apache/beam/pull/11651#issuecomment-631632732
This is the result of linkage chekcer. (it was challenging because it seems
to require Java8 strictly to finish it smoothly)
```
# /bin/bash
pabloem commented on pull request #11339:
URL: https://github.com/apache/beam/pull/11339#issuecomment-631645585
heh no worries. I'll discuss with @jaketf to see what we do...
This is an automated message from the Apache Git
aaltay commented on pull request #11744:
URL: https://github.com/apache/beam/pull/11744#issuecomment-631658770
> Somehow this seems to introduce an additional flake in
`SdkWorkerMainTest`. I can't replicate it locally... I suspect it only occurs
when pipeline options get polluted from
lukecwik commented on a change in pull request #11746:
URL: https://github.com/apache/beam/pull/11746#discussion_r428246181
##
File path:
runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/ModelCoders.java
##
@@ -59,6 +60,14 @@ private
aaltay commented on pull request #11744:
URL: https://github.com/apache/beam/pull/11744#issuecomment-631667834
> test_parse_pipeline_options
This test is a bit flawed. `expected_options.get_all_options()` could return
all registered options. Test is assuming that no other option
TheNeuralBit commented on pull request #11701:
URL: https://github.com/apache/beam/pull/11701#issuecomment-631633755
Run Python PreCommit
This is an automated message from the Apache Git Service.
To respond to the message,
tvalentyn commented on pull request #11738:
URL: https://github.com/apache/beam/pull/11738#issuecomment-631640224
Awesome, thank you!
I also opened BEAM-10046 to make sure Python 3.8 is reflected in the Beam
release.
TheNeuralBit commented on pull request #11744:
URL: https://github.com/apache/beam/pull/11744#issuecomment-631653792
Somehow this seems to introduce an additional flake in `SdkWorkerMainTest`.
I can't replicate it locally... I suspect it only occurs when pipeline options
get polluted from
TheNeuralBit edited a comment on pull request #11575:
URL: https://github.com/apache/beam/pull/11575#issuecomment-631666570
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
epicfaace commented on pull request #11759:
URL: https://github.com/apache/beam/pull/11759#issuecomment-631565034
@pabloem
This is an automated message from the Apache Git Service.
To respond to the message, please log on
pabloem commented on pull request #11596:
URL: https://github.com/apache/beam/pull/11596#issuecomment-631585052
Run Java Postcommit
This is an automated message from the Apache Git Service.
To respond to the message, please
TheNeuralBit commented on a change in pull request #11755:
URL: https://github.com/apache/beam/pull/11755#discussion_r428148051
##
File path: release/src/main/scripts/mass_comment.py
##
@@ -0,0 +1,141 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
pabloem commented on pull request #11339:
URL: https://github.com/apache/beam/pull/11339#issuecomment-631585200
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
pabloem commented on pull request #11339:
URL: https://github.com/apache/beam/pull/11339#issuecomment-631585253
Run Java Postcommit
This is an automated message from the Apache Git Service.
To respond to the message, please
TheNeuralBit commented on pull request #11754:
URL: https://github.com/apache/beam/pull/11754#issuecomment-631585754
retest this please
This is an automated message from the Apache Git Service.
To respond to the message,
tvalentyn commented on pull request #11738:
URL: https://github.com/apache/beam/pull/11738#issuecomment-631629202
Run Python Dataflow ValidatesContainer
This is an automated message from the Apache Git Service.
To respond to
TheNeuralBit commented on pull request #11575:
URL: https://github.com/apache/beam/pull/11575#issuecomment-631629222
I plan to merge when CI is green
This is an automated message from the Apache Git Service.
To respond to
ibzib commented on pull request #11738:
URL: https://github.com/apache/beam/pull/11738#issuecomment-631639325
> > @ibzib Do you know if we will need to update release instructions to
make sure we build and release Python 3.8 containers for future releases? (It
may be done in a future PR).
TheNeuralBit commented on pull request #11339:
URL: https://github.com/apache/beam/pull/11339#issuecomment-631643889
@pabloem I'm fine with adding the test data in this PR if you are. Sorry to
jump in with a random comment.
lukecwik commented on pull request #11406:
URL: https://github.com/apache/beam/pull/11406#issuecomment-631656387
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
y1chi commented on a change in pull request #11756:
URL: https://github.com/apache/beam/pull/11756#discussion_r428242655
##
File path:
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnApiDoFnRunner.java
##
@@ -460,14 +461,22 @@ public void accept(WindowedValue
y1chi commented on a change in pull request #11756:
URL: https://github.com/apache/beam/pull/11756#discussion_r428241083
##
File path:
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnApiDoFnRunner.java
##
@@ -460,14 +461,22 @@ public void accept(WindowedValue
lukecwik commented on a change in pull request #11406:
URL: https://github.com/apache/beam/pull/11406#discussion_r428239285
##
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Reshuffle.java
##
@@ -107,10 +108,57 @@ public void processElement(
/**
y1chi commented on a change in pull request #11756:
URL: https://github.com/apache/beam/pull/11756#discussion_r428241263
##
File path:
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnApiDoFnRunner.java
##
@@ -1207,15 +1224,51 @@ private void output(Instant
TheNeuralBit commented on pull request #11339:
URL: https://github.com/apache/beam/pull/11339#issuecomment-631591988
This PR is almost 300k lines, it seems to mostly be due to committing a lot
of JSON test data, which isn't ideal. Is there any way to store that test data
elsewhere?
pabloem commented on pull request #11086:
URL: https://github.com/apache/beam/pull/11086#issuecomment-631609774
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
jaketf commented on pull request #11339:
URL: https://github.com/apache/beam/pull/11339#issuecomment-631609714
We could stage these / pull these in from GCS.
This will mean devs would need access to this bucket to run the tests.
lukecwik commented on pull request #11406:
URL: https://github.com/apache/beam/pull/11406#issuecomment-631612221
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
TheNeuralBit commented on a change in pull request #11575:
URL: https://github.com/apache/beam/pull/11575#discussion_r428198550
##
File path: sdks/python/apache_beam/transforms/sql.py
##
@@ -31,8 +31,15 @@
__all__ = ['SqlTransform']
+_SQL_PLANNERS = {
+'zetasql':
TheNeuralBit commented on pull request #11575:
URL: https://github.com/apache/beam/pull/11575#issuecomment-631628284
Run XVR_Flink PostCommit
This is an automated message from the Apache Git Service.
To respond to the
tvalentyn commented on pull request #11738:
URL: https://github.com/apache/beam/pull/11738#issuecomment-631628792
@ibzib Do you know if we will need to update release instructions to make
sure we build and release Python 3.8 containers for future releases? (It may be
done in a future PR).
ibzib commented on pull request #11738:
URL: https://github.com/apache/beam/pull/11738#issuecomment-631634279
> @ibzib Do you know if we will need to update release instructions to make
sure we build and release Python 3.8 containers for future releases? (It may be
done in a future PR).
ibzib commented on pull request #11403:
URL: https://github.com/apache/beam/pull/11403#issuecomment-631641621
Run Release Gradle Build
This is an automated message from the Apache Git Service.
To respond to the message,
lukecwik commented on pull request #11406:
URL: https://github.com/apache/beam/pull/11406#issuecomment-631647633
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
HuangLED commented on a change in pull request #11746:
URL: https://github.com/apache/beam/pull/11746#discussion_r427657090
##
File path:
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/state/StateBackedIterable.java
##
@@ -0,0 +1,223 @@
+/*
+ * Licensed to the
pabloem merged pull request #11596:
URL: https://github.com/apache/beam/pull/11596
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
epicfaace opened a new pull request #11762:
URL: https://github.com/apache/beam/pull/11762
Remove curly quotes from documentation code samples. R: @pabloem
It might be good to add a CI check for markdown formatting in the future.
Post-Commit Tests Status (on master branch)
pabloem commented on pull request #11339:
URL: https://github.com/apache/beam/pull/11339#issuecomment-631582267
Run Java PostCommit
This is an automated message from the Apache Git Service.
To respond to the message,
pabloem commented on pull request #11596:
URL: https://github.com/apache/beam/pull/11596#issuecomment-631595939
Run Java Postcommit
This is an automated message from the Apache Git Service.
To respond to the message,
TheNeuralBit commented on pull request #11744:
URL: https://github.com/apache/beam/pull/11744#issuecomment-631630548
Run Python PreCommit
This is an automated message from the Apache Git Service.
To respond to the message,
ibzib commented on a change in pull request #11755:
URL: https://github.com/apache/beam/pull/11755#discussion_r428217875
##
File path: release/src/main/scripts/mass_comment.py
##
@@ -0,0 +1,141 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+#
robertwb commented on a change in pull request #11701:
URL: https://github.com/apache/beam/pull/11701#discussion_r428217917
##
File path: sdks/python/apache_beam/coders/row_coder.py
##
@@ -134,19 +134,18 @@ def __init__(self, schema, components):
def encode_to_stream(self,
TheNeuralBit commented on pull request #11754:
URL: https://github.com/apache/beam/pull/11754#issuecomment-631654862
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message,
TheNeuralBit commented on pull request #11744:
URL: https://github.com/apache/beam/pull/11744#issuecomment-631661434
```
self =
def test_parse_pipeline_options(self):
expected_options = PipelineOptions([])
expected_options.view_as(
epicfaace opened a new pull request #11759:
URL: https://github.com/apache/beam/pull/11759
Fix an issue where if the language setting in the docs is toggled to
something like Python, all examples that were only in Java disappeared
completely.
Usually, docs would look like this (in
rionmonster opened a new pull request #11761:
URL: https://github.com/apache/beam/pull/11761
In this PR, you can find a fork of the latest version of all of the current
Java Beam Katas that have been ported to use Kotlin with the associated
conversions and dependencies made.
A
pabloem commented on pull request #11339:
URL: https://github.com/apache/beam/pull/11339#issuecomment-631584938
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
pabloem commented on pull request #11596:
URL: https://github.com/apache/beam/pull/11596#issuecomment-631584876
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
lazylynx commented on pull request #11707:
URL: https://github.com/apache/beam/pull/11707#issuecomment-631604104
LGTM, Thanks!
I checked pydoc generated with `py38-docs` to make sure and it's OK.
This is an automated
chamikaramj commented on a change in pull request #11360:
URL: https://github.com/apache/beam/pull/11360#discussion_r428215342
##
File path:
sdks/java/io/snowflake/src/main/java/org/apache/beam/sdk/io/snowflake/SnowflakeIO.java
##
@@ -0,0 +1,735 @@
+/*
+ * Licensed to the
TheNeuralBit commented on pull request #11701:
URL: https://github.com/apache/beam/pull/11701#issuecomment-631649461
Run XVR_Spark PostCommit
This is an automated message from the Apache Git Service.
To respond to the
TheNeuralBit commented on a change in pull request #11701:
URL: https://github.com/apache/beam/pull/11701#discussion_r428223966
##
File path: sdks/python/apache_beam/coders/row_coder.py
##
@@ -134,19 +134,18 @@ def __init__(self, schema, components):
def
TheNeuralBit commented on a change in pull request #11529:
URL: https://github.com/apache/beam/pull/11529#discussion_r428237904
##
File path:
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/spanner/SpannerIOWriteTest.java
##
@@ -263,6 +263,17 @@
davidcavazos commented on pull request #10165:
URL: https://github.com/apache/beam/pull/10165#issuecomment-631659989
@aaltay sorry for the delay on this, this should be ready for review.
This is an automated message from the
stale[bot] commented on pull request #10165:
URL: https://github.com/apache/beam/pull/10165#issuecomment-631659293
This pull request is no longer marked as stale.
This is an automated message from the Apache Git Service.
DariuszAniszewski commented on a change in pull request #11360:
URL: https://github.com/apache/beam/pull/11360#discussion_r428244242
##
File path:
sdks/java/io/snowflake/src/main/java/org/apache/beam/sdk/io/snowflake/SnowflakeIO.java
##
@@ -0,0 +1,735 @@
+/*
+ * Licensed to
TheNeuralBit commented on pull request #11575:
URL: https://github.com/apache/beam/pull/11575#issuecomment-631666570
XVR Flink
[passed](https://builds.apache.org/job/beam_PostCommit_XVR_Flink_PR/100] before
the package-info run, so I won't do it again
chamikaramj commented on pull request #11360:
URL: https://github.com/apache/beam/pull/11360#issuecomment-631669498
Retest this please
This is an automated message from the Apache Git Service.
To respond to the message,
TheNeuralBit commented on pull request #11529:
URL: https://github.com/apache/beam/pull/11529#issuecomment-631669226
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
pabloem commented on pull request #11339:
URL: https://github.com/apache/beam/pull/11339#issuecomment-631523853
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
lukecwik commented on a change in pull request #11596:
URL: https://github.com/apache/beam/pull/11596#discussion_r428095390
##
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare/HL7v2IO.java
##
@@ -472,24 +523,77 @@ public void
nfisher commented on a change in pull request #11732:
URL: https://github.com/apache/beam/pull/11732#discussion_r428008097
##
File path:
sdks/java/io/cassandra/src/main/java/org/apache/beam/sdk/io/cassandra/CassandraIO.java
##
@@ -330,6 +331,24 @@ private CassandraIO() {}
kamilwu commented on pull request #11707:
URL: https://github.com/apache/beam/pull/11707#issuecomment-631472237
Run Python PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
RyanSkraba commented on a change in pull request #10888:
URL: https://github.com/apache/beam/pull/10888#discussion_r427878327
##
File path:
runners/twister2/src/main/java/org/apache/beam/runners/twister2/Twister2PipelineOptions.java
##
@@ -0,0 +1,93 @@
+/*
+ * Licensed to the
kamilwu commented on pull request #11707:
URL: https://github.com/apache/beam/pull/11707#issuecomment-631500053
> We need to address BEAM-9994 before we can merge this.
I think we get it. Please see the description of the issue.
However, I'm a bit worried about the time needed
ibzib commented on a change in pull request #11755:
URL: https://github.com/apache/beam/pull/11755#discussion_r428096074
##
File path: release/src/main/scripts/mass_comment.py
##
@@ -0,0 +1,141 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+#
mwalenia commented on a change in pull request #11566:
URL: https://github.com/apache/beam/pull/11566#discussion_r428033761
##
File path: sdks/java/extensions/ml/build.gradle
##
@@ -26,15 +28,23 @@ description = 'Apache Beam :: SDKs :: Java :: Extensions ::
ML'
dependencies
pabloem commented on pull request #11339:
URL: https://github.com/apache/beam/pull/11339#issuecomment-631521398
Retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
pabloem commented on pull request #11339:
URL: https://github.com/apache/beam/pull/11339#issuecomment-631521592
Run Java PostCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
pabloem commented on pull request #11596:
URL: https://github.com/apache/beam/pull/11596#issuecomment-631522261
Retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
nfisher commented on a change in pull request #11732:
URL: https://github.com/apache/beam/pull/11732#discussion_r428007520
##
File path:
sdks/java/io/cassandra/src/main/java/org/apache/beam/sdk/io/cassandra/CassandraIO.java
##
@@ -106,19 +107,13 @@
*
* Cassandra Socket
lukecwik commented on a change in pull request #11596:
URL: https://github.com/apache/beam/pull/11596#discussion_r428107636
##
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare/HL7v2IO.java
##
@@ -427,39 +458,59 @@ private
DariuszAniszewski commented on a change in pull request #11360:
URL: https://github.com/apache/beam/pull/11360#discussion_r427993794
##
File path:
sdks/java/io/snowflake/src/main/java/org/apache/beam/sdk/io/snowflake/SnowflakeIO.java
##
@@ -0,0 +1,735 @@
+/*
+ * Licensed to
TheNeuralBit commented on pull request #11529:
URL: https://github.com/apache/beam/pull/11529#issuecomment-631676277
Retest this please
This is an automated message from the Apache Git Service.
To respond to the message,
lukecwik commented on pull request #11715:
URL: https://github.com/apache/beam/pull/11715#issuecomment-631722098
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
chamikaramj commented on pull request #11651:
URL: https://github.com/apache/beam/pull/11651#issuecomment-631745259
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
chamikaramj commented on pull request #11360:
URL: https://github.com/apache/beam/pull/11360#issuecomment-631745574
Retest this please
This is an automated message from the Apache Git Service.
To respond to the message,
TheNeuralBit commented on pull request #11651:
URL: https://github.com/apache/beam/pull/11651#issuecomment-631748270
whoops
This is an automated message from the Apache Git Service.
To respond to the message, please log on
TheNeuralBit commented on pull request #11651:
URL: https://github.com/apache/beam/pull/11651#issuecomment-631748120
Run Java PostCommit
This is an automated message from the Apache Git Service.
To respond to the message,
1 - 100 of 256 matches
Mail list logo
