lazylynx commented on pull request #11707:
URL: https://github.com/apache/beam/pull/11707#issuecomment-631604104
LGTM, Thanks!
I checked pydoc generated with `py38-docs` to make sure and it's OK.
This is an automated messa
pabloem commented on pull request #11596:
URL: https://github.com/apache/beam/pull/11596#issuecomment-631598650
Run Java PostCommit
This is an automated message from the Apache Git Service.
To respond to the message, please l
pabloem commented on pull request #11596:
URL: https://github.com/apache/beam/pull/11596#issuecomment-631595939
Run Java Postcommit
This is an automated message from the Apache Git Service.
To respond to the message,
TheNeuralBit commented on pull request #11339:
URL: https://github.com/apache/beam/pull/11339#issuecomment-631591988
This PR is almost 300k lines, it seems to mostly be due to committing a lot
of JSON test data, which isn't ideal. Is there any way to store that test data
elsewhere?
-
TheNeuralBit commented on pull request #11754:
URL: https://github.com/apache/beam/pull/11754#issuecomment-631585754
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, plea
pabloem commented on pull request #11339:
URL: https://github.com/apache/beam/pull/11339#issuecomment-631585253
Run Java Postcommit
This is an automated message from the Apache Git Service.
To respond to the message, please l
pabloem commented on pull request #11596:
URL: https://github.com/apache/beam/pull/11596#issuecomment-631585052
Run Java Postcommit
This is an automated message from the Apache Git Service.
To respond to the message, please l
pabloem commented on pull request #11339:
URL: https://github.com/apache/beam/pull/11339#issuecomment-631585200
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please lo
TheNeuralBit commented on a change in pull request #11755:
URL: https://github.com/apache/beam/pull/11755#discussion_r428148051
##
File path: release/src/main/scripts/mass_comment.py
##
@@ -0,0 +1,141 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+
pabloem commented on pull request #11339:
URL: https://github.com/apache/beam/pull/11339#issuecomment-631584938
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please lo
pabloem commented on pull request #11596:
URL: https://github.com/apache/beam/pull/11596#issuecomment-631584876
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please lo
pabloem commented on pull request #11339:
URL: https://github.com/apache/beam/pull/11339#issuecomment-631583361
Run Java PostCommit
This is an automated message from the Apache Git Service.
To respond to the message,
pabloem commented on pull request #11339:
URL: https://github.com/apache/beam/pull/11339#issuecomment-631583545
Run Java PostCommit
This is an automated message from the Apache Git Service.
To respond to the message, please l
pabloem commented on pull request #11596:
URL: https://github.com/apache/beam/pull/11596#issuecomment-631583181
Retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please lo
pabloem commented on pull request #11339:
URL: https://github.com/apache/beam/pull/11339#issuecomment-631582267
Run Java PostCommit
This is an automated message from the Apache Git Service.
To respond to the message,
epicfaace opened a new pull request #11762:
URL: https://github.com/apache/beam/pull/11762
Remove curly quotes from documentation code samples. R: @pabloem
It might be good to add a CI check for markdown formatting in the future.
Post-Commit Tests Status (on master branch)
rionmonster opened a new pull request #11761:
URL: https://github.com/apache/beam/pull/11761
In this PR, you can find a fork of the latest version of all of the current
Java Beam Katas that have been ported to use Kotlin with the associated
conversions and dependencies made.
A summ
epicfaace opened a new pull request #11760:
URL: https://github.com/apache/beam/pull/11760
Fix grammar / spelling in code comments. R: @kamilwu
Post-Commit Tests Status (on master branch)
---
epicfaace commented on pull request #11759:
URL: https://github.com/apache/beam/pull/11759#issuecomment-631565034
@pabloem
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
epicfaace opened a new pull request #11759:
URL: https://github.com/apache/beam/pull/11759
Fix an issue where if the language setting in the docs is toggled to
something like Python, all examples that were only in Java disappeared
completely.
Usually, docs would look like this (in Q
lukecwik commented on a change in pull request #11596:
URL: https://github.com/apache/beam/pull/11596#discussion_r428107636
##
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare/HL7v2IO.java
##
@@ -427,39 +458,59 @@ private Messag
lukecwik commented on a change in pull request #11596:
URL: https://github.com/apache/beam/pull/11596#discussion_r428095390
##
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare/HL7v2IO.java
##
@@ -472,24 +523,77 @@ public void in
ibzib commented on a change in pull request #11755:
URL: https://github.com/apache/beam/pull/11755#discussion_r428096074
##
File path: release/src/main/scripts/mass_comment.py
##
@@ -0,0 +1,141 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contr
pabloem commented on pull request #11339:
URL: https://github.com/apache/beam/pull/11339#issuecomment-631523853
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please lo
pabloem commented on pull request #11596:
URL: https://github.com/apache/beam/pull/11596#issuecomment-631522462
Run Java postcommit
This is an automated message from the Apache Git Service.
To respond to the message, please l
pabloem commented on pull request #11596:
URL: https://github.com/apache/beam/pull/11596#issuecomment-631522261
Retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please lo
pabloem commented on pull request #11339:
URL: https://github.com/apache/beam/pull/11339#issuecomment-631521592
Run Java PostCommit
This is an automated message from the Apache Git Service.
To respond to the message, please l
pabloem commented on pull request #11339:
URL: https://github.com/apache/beam/pull/11339#issuecomment-631521398
Retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please lo
kamilwu commented on pull request #11707:
URL: https://github.com/apache/beam/pull/11707#issuecomment-631500053
> We need to address BEAM-9994 before we can merge this.
I think we get it. Please see the description of the issue.
However, I'm a bit worried about the time needed
mwalenia commented on a change in pull request #11566:
URL: https://github.com/apache/beam/pull/11566#discussion_r428033761
##
File path: sdks/java/extensions/ml/build.gradle
##
@@ -26,15 +28,23 @@ description = 'Apache Beam :: SDKs :: Java :: Extensions ::
ML'
dependencies {
nfisher commented on a change in pull request #11732:
URL: https://github.com/apache/beam/pull/11732#discussion_r428008097
##
File path:
sdks/java/io/cassandra/src/main/java/org/apache/beam/sdk/io/cassandra/CassandraIO.java
##
@@ -330,6 +331,24 @@ private CassandraIO() {}
kamilwu commented on pull request #11707:
URL: https://github.com/apache/beam/pull/11707#issuecomment-631472237
Run Python PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
nfisher commented on a change in pull request #11732:
URL: https://github.com/apache/beam/pull/11732#discussion_r428007520
##
File path:
sdks/java/io/cassandra/src/main/java/org/apache/beam/sdk/io/cassandra/CassandraIO.java
##
@@ -106,19 +107,13 @@
*
* Cassandra Socket Opt
RyanSkraba commented on a change in pull request #10888:
URL: https://github.com/apache/beam/pull/10888#discussion_r427878327
##
File path:
runners/twister2/src/main/java/org/apache/beam/runners/twister2/Twister2PipelineOptions.java
##
@@ -0,0 +1,93 @@
+/*
+ * Licensed to the
DariuszAniszewski commented on a change in pull request #11360:
URL: https://github.com/apache/beam/pull/11360#discussion_r427993794
##
File path:
sdks/java/io/snowflake/src/main/java/org/apache/beam/sdk/io/snowflake/SnowflakeIO.java
##
@@ -0,0 +1,735 @@
+/*
+ * Licensed to th
wcc526 opened a new pull request #11758:
URL: https://github.com/apache/beam/pull/11758
Old version Fastjson has a serious security problem which will cause RCE
https://www.anquanke.com/post/id/199527
https://www.cnblogs.com/tr1ple/p/12348886.html
https://github.com/jas502n/fastjson
kamilwu commented on pull request #11738:
URL: https://github.com/apache/beam/pull/11738#issuecomment-631398475
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please lo
kamilwu commented on pull request #11707:
URL: https://github.com/apache/beam/pull/11707#issuecomment-631393434
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
kamilwu merged pull request #11274:
URL: https://github.com/apache/beam/pull/11274
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
kamilwu commented on pull request #11274:
URL: https://github.com/apache/beam/pull/11274#issuecomment-631390328
LGTM, thanks for contribution!
This is an automated message from the Apache Git Service.
To respond to the messag
kamilwu commented on pull request #11707:
URL: https://github.com/apache/beam/pull/11707#issuecomment-631385430
Run PythonFormatter PreCommit
This is an automated message from the Apache Git Service.
To respond to the message
kamilwu commented on pull request #11707:
URL: https://github.com/apache/beam/pull/11707#issuecomment-631385686
Run Python PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
echauchot commented on a change in pull request #11732:
URL: https://github.com/apache/beam/pull/11732#discussion_r427861203
##
File path:
sdks/java/io/cassandra/src/main/java/org/apache/beam/sdk/io/cassandra/CassandraIO.java
##
@@ -106,19 +107,13 @@
*
* Cassandra Socket O
kamilwu commented on pull request #11738:
URL: https://github.com/apache/beam/pull/11738#issuecomment-631374566
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
mwalenia commented on a change in pull request #11566:
URL: https://github.com/apache/beam/pull/11566#discussion_r427880303
##
File path:
sdks/java/extensions/ml/src/main/java/org/apache/beam/sdk/extensions/ml/DLPReidentifyText.java
##
@@ -0,0 +1,206 @@
+/*
+ * Licensed to the
mwalenia commented on a change in pull request #11566:
URL: https://github.com/apache/beam/pull/11566#discussion_r427872119
##
File path:
sdks/java/extensions/ml/src/main/java/org/apache/beam/sdk/extensions/ml/DLPReidentifyText.java
##
@@ -0,0 +1,206 @@
+/*
+ * Licensed to the
kamilwu commented on a change in pull request #11738:
URL: https://github.com/apache/beam/pull/11738#discussion_r427859015
##
File path: sdks/python/container/run_validatescontainer.sh
##
@@ -69,8 +71,13 @@ elif [[ $1 == "python37" ]]; then
CONTAINER_PROJECT="sdks:python:con
kamilwu commented on pull request #11274:
URL: https://github.com/apache/beam/pull/11274#issuecomment-631323516
Run Python PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
kamilwu commented on pull request #11274:
URL: https://github.com/apache/beam/pull/11274#issuecomment-631323353
Run Python PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
ihji commented on a change in pull request #11757:
URL: https://github.com/apache/beam/pull/11757#discussion_r427807599
##
File path: sdks/python/apache_beam/runners/dataflow/internal/apiclient.py
##
@@ -314,8 +314,15 @@ def __init__(
if container_image_url in already_
ihji commented on a change in pull request #11757:
URL: https://github.com/apache/beam/pull/11757#discussion_r427807327
##
File path: sdks/python/apache_beam/runners/dataflow/internal/apiclient.py
##
@@ -314,8 +314,15 @@ def __init__(
if container_image_url in already_
ihji commented on a change in pull request #11757:
URL: https://github.com/apache/beam/pull/11757#discussion_r427804783
##
File path: sdks/python/apache_beam/runners/dataflow/internal/apiclient.py
##
@@ -314,8 +314,15 @@ def __init__(
if container_image_url in already_
jaketf commented on pull request #11596:
URL: https://github.com/apache/beam/pull/11596#issuecomment-631277688
@pabloem please retest this
This is an automated message from the Apache Git Service.
To respond to the message, p
201 - 253 of 253 matches
Mail list logo
