ihji opened a new pull request #11771:
URL: https://github.com/apache/beam/pull/11771
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [ ] [**Choose
reviewer(s)**](https://beam.
ihji commented on pull request #11771:
URL: https://github.com/apache/beam/pull/11771#issuecomment-631950394
R: @chamikaramj
This is an automated message from the Apache Git Service.
To respond to the message, please log on
kamilwu commented on pull request #11760:
URL: https://github.com/apache/beam/pull/11760#issuecomment-631967204
Retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please lo
kamilwu commented on pull request #11760:
URL: https://github.com/apache/beam/pull/11760#issuecomment-631976285
Thanks @epicfaace!
This is an automated message from the Apache Git Service.
To respond to the message, please lo
kamilwu merged pull request #11760:
URL: https://github.com/apache/beam/pull/11760
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
kkucharc commented on pull request #11360:
URL: https://github.com/apache/beam/pull/11360#issuecomment-631990753
Run Python2_PVR_Flink PreCommit
This is an automated message from the Apache Git Service.
To respond to the mess
mxm opened a new pull request #11772:
URL: https://github.com/apache/beam/pull/11772
Post-Commit Tests Status (on master branch)
Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza
DariuszAniszewski commented on pull request #11360:
URL: https://github.com/apache/beam/pull/11360#issuecomment-632019864
Just a small comment about the force-push from above - it was mistakenly
done, then reverted. HEAD of this branch is still on **3ba192a** and comment is
a leftover.
-
mwalenia commented on a change in pull request #11566:
URL: https://github.com/apache/beam/pull/11566#discussion_r428605560
##
File path:
sdks/java/extensions/ml/src/main/java/org/apache/beam/sdk/extensions/ml/BatchRequestForDLP.java
##
@@ -0,0 +1,101 @@
+/*
+ * Licensed to th
mwalenia commented on a change in pull request #11566:
URL: https://github.com/apache/beam/pull/11566#discussion_r428606587
##
File path:
sdks/java/extensions/ml/src/test/java/org/apache/beam/sdk/extensions/ml/DLPTextOperationsIT.java
##
@@ -0,0 +1,154 @@
+/*
+ * Licensed to t
harriskistpay opened a new pull request #11773:
URL: https://github.com/apache/beam/pull/11773
Updated CHANGES.md file
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [ ] [**
harriskistpay closed pull request #11773:
URL: https://github.com/apache/beam/pull/11773
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
rehmanmuradali opened a new pull request #11774:
URL: https://github.com/apache/beam/pull/11774
Updated CHANGES.md
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [ ] [**Choo
rehmanmuradali commented on pull request #11774:
URL: https://github.com/apache/beam/pull/11774#issuecomment-632067025
R: @reuvenlax
This is an automated message from the Apache Git Service.
To respond to the message, please
mwalenia opened a new pull request #11775:
URL: https://github.com/apache/beam/pull/11775
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
mwalenia commented on a change in pull request #11566:
URL: https://github.com/apache/beam/pull/11566#discussion_r428661780
##
File path:
sdks/java/extensions/ml/src/main/java/org/apache/beam/sdk/extensions/ml/DLPDeidentifyText.java
##
@@ -0,0 +1,215 @@
+/*
+ * Licensed to the
mwalenia commented on a change in pull request #11566:
URL: https://github.com/apache/beam/pull/11566#discussion_r428666183
##
File path:
sdks/java/extensions/ml/src/main/java/org/apache/beam/sdk/extensions/ml/MapStringToDlpRow.java
##
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the
henryken commented on pull request #11734:
URL: https://github.com/apache/beam/pull/11734#issuecomment-632104571
Thanks @damondouglas!
This is an automated message from the Apache Git Service.
To respond to the message, pleas
kkucharc commented on pull request #11360:
URL: https://github.com/apache/beam/pull/11360#issuecomment-632106649
I retested failing test - probably the previous one was timeouting.
This is an automated message from the Apach
mwalenia commented on a change in pull request #11566:
URL: https://github.com/apache/beam/pull/11566#discussion_r428676595
##
File path:
sdks/java/extensions/ml/src/main/java/org/apache/beam/sdk/extensions/ml/DLPReidentifyText.java
##
@@ -0,0 +1,206 @@
+/*
+ * Licensed to the
mwalenia commented on a change in pull request #11566:
URL: https://github.com/apache/beam/pull/11566#discussion_r428679955
##
File path:
sdks/java/extensions/ml/src/main/java/org/apache/beam/sdk/extensions/ml/DLPDeidentifyText.java
##
@@ -0,0 +1,215 @@
+/*
+ * Licensed to the
mwalenia commented on pull request #11566:
URL: https://github.com/apache/beam/pull/11566#issuecomment-632113183
@tysonjh , @santhh Thanks for the review, I added the first batch of fixes.
I'll take care of the Javadocs tomorrow.
---
kamilwu opened a new pull request #11776:
URL: https://github.com/apache/beam/pull/11776
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [ ] [**Choose
reviewer(s)**](https://be
reuvenlax merged pull request #11774:
URL: https://github.com/apache/beam/pull/11774
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
reuvenlax commented on pull request #11774:
URL: https://github.com/apache/beam/pull/11774#issuecomment-632168553
LGTM
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
y1chi commented on a change in pull request #11756:
URL: https://github.com/apache/beam/pull/11756#discussion_r428754395
##
File path:
sdks/java/harness/src/test/java/org/apache/beam/fn/harness/FnApiDoFnRunnerTest.java
##
@@ -947,49 +910,213 @@ public void testTimers() throws
mxm opened a new pull request #11777:
URL: https://github.com/apache/beam/pull/11777
We have a test pipeline which runs with the DirectRunner. When upgrading
from 2.18.0 to 2.21.0 the test failed with the following exception:
```
tp = Exception('Monitor task detected a pipeline st
TheNeuralBit commented on pull request #11770:
URL: https://github.com/apache/beam/pull/11770#issuecomment-632179933
Run Go PostCommit
This is an automated message from the Apache Git Service.
To respond to the message, pleas
mxm commented on pull request #11777:
URL: https://github.com/apache/beam/pull/11777#issuecomment-632181118
R: @rohdesamuel
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
mxm commented on pull request #11777:
URL: https://github.com/apache/beam/pull/11777#issuecomment-632181899
Please have a look @rohdesamuel if you consider the fix valid. I'm not very
familiar with the Python SDK triggering code.
---
boyuanzz commented on pull request #11756:
URL: https://github.com/apache/beam/pull/11756#issuecomment-632182849
retest all please
This is an automated message from the Apache Git Service.
To respond to the message, please lo
boyuanzz commented on pull request #11756:
URL: https://github.com/apache/beam/pull/11756#issuecomment-632185565
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please l
TheNeuralBit commented on pull request #11770:
URL: https://github.com/apache/beam/pull/11770#issuecomment-632185540
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, plea
TheNeuralBit commented on pull request #11770:
URL: https://github.com/apache/beam/pull/11770#issuecomment-632186469
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, plea
TheNeuralBit commented on pull request #11770:
URL: https://github.com/apache/beam/pull/11770#issuecomment-632186575
Run Python PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, pl
TheNeuralBit commented on pull request #11770:
URL: https://github.com/apache/beam/pull/11770#issuecomment-632187939
Run Python 3.6 PostCommit
This is an automated message from the Apache Git Service.
To respond to the messag
TheNeuralBit commented on pull request #11770:
URL: https://github.com/apache/beam/pull/11770#issuecomment-632187854
Run Python 2 PostCommit
This is an automated message from the Apache Git Service.
To respond to the message,
TheNeuralBit commented on pull request #11770:
URL: https://github.com/apache/beam/pull/11770#issuecomment-632188019
Run Python 3.7 PostCommit
This is an automated message from the Apache Git Service.
To respond to the messag
TheNeuralBit commented on pull request #11770:
URL: https://github.com/apache/beam/pull/11770#issuecomment-632188678
Run Java Spark PortableValidatesRunner Batch
This is an automated message from the Apache Git Service.
To re
TheNeuralBit commented on pull request #11770:
URL: https://github.com/apache/beam/pull/11770#issuecomment-632190367
Run Release Gradle Build
This is an automated message from the Apache Git Service.
To respond to the message
TheNeuralBit commented on pull request #11770:
URL: https://github.com/apache/beam/pull/11770#issuecomment-632191832
Run SQL_Java11 PreCommit
This is an automated message from the Apache Git Service.
To respond to the message
ibzib commented on a change in pull request #11764:
URL: https://github.com/apache/beam/pull/11764#discussion_r428769910
##
File path: website/www/site/content/en/contribute/release-guide.md
##
@@ -583,189 +582,44 @@ For this step, we recommend you using automation script
to c
ibzib commented on a change in pull request #11764:
URL: https://github.com/apache/beam/pull/11764#discussion_r428770502
##
File path: release/src/main/scripts/build_release_candidate.sh
##
@@ -113,7 +113,7 @@ if [[ $confirmation = "y" ]]; then
echo "-Staging Jav
ibzib commented on a change in pull request #11764:
URL: https://github.com/apache/beam/pull/11764#discussion_r428774392
##
File path: website/www/site/content/en/contribute/release-guide.md
##
@@ -583,189 +582,44 @@ For this step, we recommend you using automation script
to c
apilloud commented on a change in pull request #11682:
URL: https://github.com/apache/beam/pull/11682#discussion_r428778641
##
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Partition.java
##
@@ -85,7 +141,14 @@
* @throws IllegalArgumentException if
mxm commented on a change in pull request #11777:
URL: https://github.com/apache/beam/pull/11777#discussion_r428778698
##
File path: sdks/python/apache_beam/transforms/trigger.py
##
@@ -1368,7 +1368,7 @@ def _output(
if timestamp is None:
# If no watermark hold was
apilloud commented on pull request #11682:
URL: https://github.com/apache/beam/pull/11682#issuecomment-632218345
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please l
chamikaramj commented on pull request #11771:
URL: https://github.com/apache/beam/pull/11771#issuecomment-632219614
WDYT about https://github.com/ihji/beam/pull/1 ?
(only change is to Environments.java other changes should go away if you
rebase)
chamikaramj merged pull request #11757:
URL: https://github.com/apache/beam/pull/11757
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
robertwb merged pull request #11503:
URL: https://github.com/apache/beam/pull/11503
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
TheNeuralBit commented on pull request #11521:
URL: https://github.com/apache/beam/pull/11521#issuecomment-632237798
@robertwb I think this broke Java PVR Spark Batch. First failure is here:
https://builds.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/2887/ Not
sure if there is a jir
TheNeuralBit commented on pull request #11521:
URL: https://github.com/apache/beam/pull/11521#issuecomment-632241122
[BEAM-9971](https://issues.apache.org/jira/browse/BEAM-9971) was filed to
track
This is an automated messag
amaliujia commented on pull request #11610:
URL: https://github.com/apache/beam/pull/11610#issuecomment-632248973
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
amaliujia commented on pull request #11610:
URL: https://github.com/apache/beam/pull/11610#issuecomment-632249476
run Java Precommit
This is an automated message from the Apache Git Service.
To respond to the message, please
amaliujia commented on pull request #11610:
URL: https://github.com/apache/beam/pull/11610#issuecomment-632249853
Tests retriggered.
And it becomes a really big PR :-) Nice work!
This is an automated message from the
boyuanzz commented on pull request #11756:
URL: https://github.com/apache/beam/pull/11756#issuecomment-632250883
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please l
boyuanzz commented on pull request #11756:
URL: https://github.com/apache/beam/pull/11756#issuecomment-632251140
Run Java Flink PortableValidatesRunner Streaming
This is an automated message from the Apache Git Service.
To re
boyuanzz commented on pull request #11756:
URL: https://github.com/apache/beam/pull/11756#issuecomment-632250772
retest all please
This is an automated message from the Apache Git Service.
To respond to the message, please lo
boyuanzz commented on pull request #11756:
URL: https://github.com/apache/beam/pull/11756#issuecomment-632251027
Run Java Flink PortableValidatesRunner Batch
This is an automated message from the Apache Git Service.
To respon
ihji commented on pull request #11771:
URL: https://github.com/apache/beam/pull/11771#issuecomment-632251342
> WDYT about [ihji#1](https://github.com/ihji/beam/pull/1) ?
> (only change is to Environments.java other changes should go away if you
rebase)
It will add 36 characters +
veblush opened a new pull request #11778:
URL: https://github.com/apache/beam/pull/11778
Backport of #11651
CC: @theneuralbit
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
TheNeuralBit commented on pull request #11778:
URL: https://github.com/apache/beam/pull/11778#issuecomment-632260642
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
tedromer opened a new pull request #11779:
URL: https://github.com/apache/beam/pull/11779
Add --region to python examples where it was missing.
R: ibzib
This is an automated message from the Apache Git Service.
To resp
aaltay commented on pull request #8457:
URL: https://github.com/apache/beam/pull/8457#issuecomment-632270901
There are still failing tests on https://github.com/apache/beam/pull/11295.
@mf2199 - What is the next step for this PR?
---
aaltay commented on pull request #11580:
URL: https://github.com/apache/beam/pull/11580#issuecomment-632271494
@kmjung - What is the next step for this PR?
This is an automated message from the Apache Git Service.
To respond
chamikaramj commented on pull request #11771:
URL: https://github.com/apache/beam/pull/11771#issuecomment-632271987
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
chamikaramj commented on pull request #11771:
URL: https://github.com/apache/beam/pull/11771#issuecomment-632272181
Retest this please
This is an automated message from the Apache Git Service.
To respond to the message, pleas
kmjung commented on pull request #11580:
URL: https://github.com/apache/beam/pull/11580#issuecomment-632272486
The next step is to merge this PR, I believe. I don't believe there's
anything blocking other than a review from @chamikaramj.
---
udim commented on a change in pull request #11661:
URL: https://github.com/apache/beam/pull/11661#discussion_r428838484
##
File path: sdks/python/test-suites/dataflow/common.gradle
##
@@ -109,4 +109,21 @@ task validatesRunnerStreamingTests {
args '-c', ". ${envdir}/bin/a
pabloem commented on pull request #11086:
URL: https://github.com/apache/beam/pull/11086#issuecomment-632277003
Run Python2_PVR_Flink PreCommit
This is an automated message from the Apache Git Service.
To respond to the messa
chamikaramj commented on pull request #11771:
URL: https://github.com/apache/beam/pull/11771#issuecomment-632278144
Retest this please
This is an automated message from the Apache Git Service.
To respond to the message, pleas
chamikaramj commented on pull request #11771:
URL: https://github.com/apache/beam/pull/11771#issuecomment-632279237
Retest this please
This is an automated message from the Apache Git Service.
To respond to the message, pleas
aijamalnk opened a new pull request #11780:
URL: https://github.com/apache/beam/pull/11780
**Please** add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quic
ibzib merged pull request #11764:
URL: https://github.com/apache/beam/pull/11764
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
TheNeuralBit commented on pull request #11770:
URL: https://github.com/apache/beam/pull/11770#issuecomment-632296307
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, plea
pabloem commented on pull request #11780:
URL: https://github.com/apache/beam/pull/11780#issuecomment-632296533
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please lo
rohdesamuel commented on pull request #11765:
URL: https://github.com/apache/beam/pull/11765#issuecomment-632299883
R: @robertwb
This is an automated message from the Apache Git Service.
To respond to the message, please log
rohdesamuel commented on pull request #11745:
URL: https://github.com/apache/beam/pull/11745#issuecomment-632301124
R: @pabloem thanks Pablo!
This is an automated message from the Apache Git Service.
To respond to the messag
lukecwik opened a new pull request #11781:
URL: https://github.com/apache/beam/pull/11781
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [ ] [**Choose
reviewer(s)**](https://b
lukecwik commented on pull request #11781:
URL: https://github.com/apache/beam/pull/11781#issuecomment-632303098
R: @ihji @chamikaramj
CC: @TheNeuralBit (cherry pick into 2.22)
This is an automated message from the Apache
TheNeuralBit commented on pull request #11781:
URL: https://github.com/apache/beam/pull/11781#issuecomment-632304060
Is there any test coverage of this?
This is an automated message from the Apache Git Service.
To respond to
lostluck opened a new pull request #11782:
URL: https://github.com/apache/beam/pull/11782
We were a bit too strict for CoGBKs with multiple value streams with
Structural DoFns. This PR expands the validation to support precise validation
at construction time, and relaxes the execution time
lostluck commented on pull request #11782:
URL: https://github.com/apache/beam/pull/11782#issuecomment-632304959
R: @youngoli
This is an automated message from the Apache Git Service.
To respond to the message, please log on
TheNeuralBit commented on pull request #11778:
URL: https://github.com/apache/beam/pull/11778#issuecomment-632309156
Run Python2_PVR_Flink PreCommit
This is an automated message from the Apache Git Service.
To respond to the
pabloem commented on a change in pull request #11086:
URL: https://github.com/apache/beam/pull/11086#discussion_r428877884
##
File path: sdks/python/apache_beam/io/gcp/bigquery.py
##
@@ -610,7 +611,8 @@ def __init__(
coder=None,
use_standard_sql=False,
flat
aaltay commented on pull request #11682:
URL: https://github.com/apache/beam/pull/11682#issuecomment-632313052
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please log
aaltay commented on pull request #11682:
URL: https://github.com/apache/beam/pull/11682#issuecomment-632313262
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please log
chamikaramj commented on pull request #11781:
URL: https://github.com/apache/beam/pull/11781#issuecomment-632314521
I suspect test coverage will be internal to Dataflow (hence during import).
This is an automated message from
chamikaramj commented on pull request #11781:
URL: https://github.com/apache/beam/pull/11781#issuecomment-632314627
I'm doing a manual validation for now.
This is an automated message from the Apache Git Service.
To respond t
TheNeuralBit commented on pull request #11781:
URL: https://github.com/apache/beam/pull/11781#issuecomment-632318843
Got it, thanks
This is an automated message from the Apache Git Service.
To respond to the message, please l
TheNeuralBit commented on pull request #11272:
URL: https://github.com/apache/beam/pull/11272#issuecomment-632327533
Something just occurred to me - are there any tests that use the DATE Type
in an aggregation (e.g. MAX)?
I'd think that would run into the same issue I have in #11456
TheNeuralBit edited a comment on pull request #11272:
URL: https://github.com/apache/beam/pull/11272#issuecomment-632327533
Something just occurred to me - are there any tests that use the DATE Type
in an aggregation (e.g. MAX)?
I'd think that would run into the same issue I have in
apilloud commented on pull request #11272:
URL: https://github.com/apache/beam/pull/11272#issuecomment-632330703
Interesting question. You should probably add a test for JOIN as well, which
will have a similar class of problems.
robinyqiu commented on pull request #11272:
URL: https://github.com/apache/beam/pull/11272#issuecomment-632331823
> are there any tests that use the DATE Type in an aggregation (e.g. MAX)?
No. Thanks for bringing this up. I think it is likely to run into the
problem.
--
reuvenlax commented on a change in pull request #11456:
URL: https://github.com/apache/beam/pull/11456#discussion_r428901750
##
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/logicaltypes/MillisInstant.java
##
@@ -0,0 +1,44 @@
+/*
+ * Licensed to the Apach
TheNeuralBit commented on pull request #11781:
URL: https://github.com/apache/beam/pull/11781#issuecomment-632335607
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, plea
TheNeuralBit commented on pull request #11778:
URL: https://github.com/apache/beam/pull/11778#issuecomment-632335448
Run Python PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, pl
TheNeuralBit commented on pull request #11770:
URL: https://github.com/apache/beam/pull/11770#issuecomment-632335832
Run Python 3.7 PostCommit
This is an automated message from the Apache Git Service.
To respond to the messag
lukecwik commented on pull request #11781:
URL: https://github.com/apache/beam/pull/11781#issuecomment-632342320
Test coverage is by existing IOs that enable these features which we don't
have enough of in Beam (since it requires portable runners to implement SDF to
a greater extent then t
chamikaramj commented on pull request #11781:
URL: https://github.com/apache/beam/pull/11781#issuecomment-632347848
LGTM. Thanks.
Ran the Kafka test few times and it seems to be working.
This is an automated message fr
1 - 100 of 161 matches
Mail list logo
