[GitHub] [beam] aaltay commented on pull request #11580: [BEAM-9861] Reject fractional values outside of (0.0, 1.0)

2020-05-21 Thread GitBox
aaltay commented on pull request #11580: URL: https://github.com/apache/beam/pull/11580#issuecomment-632271494 @kmjung - What is the next step for this PR? This is an automated message from the Apache Git Service. To respond

[GitHub] [beam] lostluck opened a new pull request #11782: [BEAM-10056] Fix validation for struct CoGBKs

2020-05-21 Thread GitBox
lostluck opened a new pull request #11782: URL: https://github.com/apache/beam/pull/11782 We were a bit too strict for CoGBKs with multiple value streams with Structural DoFns. This PR expands the validation to support precise validation at construction time, and relaxes the execution

[GitHub] [beam] lostluck commented on pull request #11782: [BEAM-10056] Fix validation for struct CoGBKs

2020-05-21 Thread GitBox
lostluck commented on pull request #11782: URL: https://github.com/apache/beam/pull/11782#issuecomment-632304959 R: @youngoli This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [beam] chamikaramj commented on pull request #11781: [BEAM-2939, BEAM-10057] Ensure that we can process an EmptyUnboundedSource and also prevent splitting on it.

2020-05-21 Thread GitBox
chamikaramj commented on pull request #11781: URL: https://github.com/apache/beam/pull/11781#issuecomment-632314627 I'm doing a manual validation for now. This is an automated message from the Apache Git Service. To respond

[GitHub] [beam] chamikaramj commented on pull request #11781: [BEAM-2939, BEAM-10057] Ensure that we can process an EmptyUnboundedSource and also prevent splitting on it.

2020-05-21 Thread GitBox
chamikaramj commented on pull request #11781: URL: https://github.com/apache/beam/pull/11781#issuecomment-632314521 I suspect test coverage will be internal to Dataflow (hence during import). This is an automated message

[GitHub] [beam] TheNeuralBit commented on pull request #11781: [BEAM-2939, BEAM-10057] Ensure that we can process an EmptyUnboundedSource and also prevent splitting on it.

2020-05-21 Thread GitBox
TheNeuralBit commented on pull request #11781: URL: https://github.com/apache/beam/pull/11781#issuecomment-632318843 Got it, thanks This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] TheNeuralBit commented on pull request #11272: [BEAM-9641] Support ZetaSQL DATE type as a Beam LogicalType

2020-05-21 Thread GitBox
TheNeuralBit commented on pull request #11272: URL: https://github.com/apache/beam/pull/11272#issuecomment-632327533 Something just occurred to me - are there any tests that use the DATE Type in an aggregation (e.g. MAX)? I'd think that would run into the same issue I have in #11456

[GitHub] [beam] TheNeuralBit edited a comment on pull request #11272: [BEAM-9641] Support ZetaSQL DATE type as a Beam LogicalType

2020-05-21 Thread GitBox
TheNeuralBit edited a comment on pull request #11272: URL: https://github.com/apache/beam/pull/11272#issuecomment-632327533 Something just occurred to me - are there any tests that use the DATE Type in an aggregation (e.g. MAX)? I'd think that would run into the same issue I have in

[GitHub] [beam] mxm commented on pull request #11777: [BEAM-10054] Fix watermark hold for on_time_pane in DirectRunner

2020-05-21 Thread GitBox
mxm commented on pull request #11777: URL: https://github.com/apache/beam/pull/11777#issuecomment-632181899 Please have a look @rohdesamuel if you consider the fix valid. I'm not very familiar with the Python SDK triggering code.

[GitHub] [beam] TheNeuralBit commented on pull request #11770: [DO NOT MERGE] Run all PostCommit and PreCommit Tests against Release Branch

2020-05-21 Thread GitBox
TheNeuralBit commented on pull request #11770: URL: https://github.com/apache/beam/pull/11770#issuecomment-632187939 Run Python 3.6 PostCommit This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] TheNeuralBit commented on pull request #11770: [DO NOT MERGE] Run all PostCommit and PreCommit Tests against Release Branch

2020-05-21 Thread GitBox
TheNeuralBit commented on pull request #11770: URL: https://github.com/apache/beam/pull/11770#issuecomment-632187854 Run Python 2 PostCommit This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] TheNeuralBit commented on pull request #11770: [DO NOT MERGE] Run all PostCommit and PreCommit Tests against Release Branch

2020-05-21 Thread GitBox
TheNeuralBit commented on pull request #11770: URL: https://github.com/apache/beam/pull/11770#issuecomment-632188019 Run Python 3.7 PostCommit This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] tedromer opened a new pull request #11779: [BEAM-10055] Add --region to python examples where it was missing

2020-05-21 Thread GitBox
tedromer opened a new pull request #11779: URL: https://github.com/apache/beam/pull/11779 Add --region to python examples where it was missing. R: ibzib This is an automated message from the Apache Git Service. To

[GitHub] [beam] kmjung commented on pull request #11580: [BEAM-9861] Reject fractional values outside of (0.0, 1.0)

2020-05-21 Thread GitBox
kmjung commented on pull request #11580: URL: https://github.com/apache/beam/pull/11580#issuecomment-632272486 The next step is to merge this PR, I believe. I don't believe there's anything blocking other than a review from @chamikaramj.

[GitHub] [beam] chamikaramj commented on pull request #11771: [BEAM-10052] check hash and avoid duplicated artifacts

2020-05-21 Thread GitBox
chamikaramj commented on pull request #11771: URL: https://github.com/apache/beam/pull/11771#issuecomment-632271987 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [beam] udim commented on a change in pull request #11661: [BEAM-7774] Remove perfkit benchmarking tool from python performance …

2020-05-21 Thread GitBox
udim commented on a change in pull request #11661: URL: https://github.com/apache/beam/pull/11661#discussion_r428838484 ## File path: sdks/python/test-suites/dataflow/common.gradle ## @@ -109,4 +109,21 @@ task validatesRunnerStreamingTests { args '-c', ".

[GitHub] [beam] chamikaramj commented on pull request #11771: [BEAM-10052] check hash and avoid duplicated artifacts

2020-05-21 Thread GitBox
chamikaramj commented on pull request #11771: URL: https://github.com/apache/beam/pull/11771#issuecomment-632272181 Retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] chamikaramj commented on pull request #11771: [BEAM-10052] check hash and avoid duplicated artifacts

2020-05-21 Thread GitBox
chamikaramj commented on pull request #11771: URL: https://github.com/apache/beam/pull/11771#issuecomment-632279237 Retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] rohdesamuel commented on pull request #11765: [BEAM-9322] Remove passthrough_pcollection_output_ids and force_generated_pcollection_output_ids flags

2020-05-21 Thread GitBox
rohdesamuel commented on pull request #11765: URL: https://github.com/apache/beam/pull/11765#issuecomment-632299883 R: @robertwb This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] aaltay commented on pull request #11682: [BEAM-9946] | added new api in Partition Transform

2020-05-21 Thread GitBox
aaltay commented on pull request #11682: URL: https://github.com/apache/beam/pull/11682#issuecomment-632313052 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] reuvenlax merged pull request #11774: [BEAM-1589] Added @OnWindowExpiration annotation.

2020-05-21 Thread GitBox
reuvenlax merged pull request #11774: URL: https://github.com/apache/beam/pull/11774 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [beam] reuvenlax commented on pull request #11774: [BEAM-1589] Added @OnWindowExpiration annotation.

2020-05-21 Thread GitBox
reuvenlax commented on pull request #11774: URL: https://github.com/apache/beam/pull/11774#issuecomment-632168553 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [beam] mxm commented on pull request #11777: [BEAM-10054] Fix watermark hold for on_time_pane in DirectRunner

2020-05-21 Thread GitBox
mxm commented on pull request #11777: URL: https://github.com/apache/beam/pull/11777#issuecomment-632181118 R: @rohdesamuel This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [beam] TheNeuralBit commented on pull request #11770: [DO NOT MERGE] Run all PostCommit and PreCommit Tests against Release Branch

2020-05-21 Thread GitBox
TheNeuralBit commented on pull request #11770: URL: https://github.com/apache/beam/pull/11770#issuecomment-632190367 Run Release Gradle Build This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] ibzib commented on a change in pull request #11764: [BEAM-10048] Clean up release guide.

2020-05-21 Thread GitBox
ibzib commented on a change in pull request #11764: URL: https://github.com/apache/beam/pull/11764#discussion_r428770502 ## File path: release/src/main/scripts/build_release_candidate.sh ## @@ -113,7 +113,7 @@ if [[ $confirmation = "y" ]]; then echo "-Staging

[GitHub] [beam] ibzib commented on a change in pull request #11764: [BEAM-10048] Clean up release guide.

2020-05-21 Thread GitBox
ibzib commented on a change in pull request #11764: URL: https://github.com/apache/beam/pull/11764#discussion_r428769910 ## File path: website/www/site/content/en/contribute/release-guide.md ## @@ -583,189 +582,44 @@ For this step, we recommend you using automation script to

[GitHub] [beam] TheNeuralBit commented on pull request #11521: [BEAM-9577] Update Java Runners to handle dependency-based artifact staging.

2020-05-21 Thread GitBox
TheNeuralBit commented on pull request #11521: URL: https://github.com/apache/beam/pull/11521#issuecomment-632241122 [BEAM-9971](https://issues.apache.org/jira/browse/BEAM-9971) was filed to track This is an automated

[GitHub] [beam] amaliujia commented on pull request #11610: [BEAM-9825] | Implement Intersect,Union,Except transforms

2020-05-21 Thread GitBox
amaliujia commented on pull request #11610: URL: https://github.com/apache/beam/pull/11610#issuecomment-632249853 Tests retriggered. And it becomes a really big PR :-) Nice work! This is an automated message from the

[GitHub] [beam] pabloem commented on a change in pull request #11086: [BEAM-8910] Make custom BQ source read from Avro

2020-05-21 Thread GitBox
pabloem commented on a change in pull request #11086: URL: https://github.com/apache/beam/pull/11086#discussion_r428877884 ## File path: sdks/python/apache_beam/io/gcp/bigquery.py ## @@ -610,7 +611,8 @@ def __init__( coder=None, use_standard_sql=False,

[GitHub] [beam] boyuanzz commented on pull request #11756: [BEAM-9603] Add timer family support to FnApiDoFnRunner

2020-05-21 Thread GitBox
boyuanzz commented on pull request #11756: URL: https://github.com/apache/beam/pull/11756#issuecomment-632250772 retest all please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] boyuanzz commented on pull request #11756: [BEAM-9603] Add timer family support to FnApiDoFnRunner

2020-05-21 Thread GitBox
boyuanzz commented on pull request #11756: URL: https://github.com/apache/beam/pull/11756#issuecomment-632251027 Run Java Flink PortableValidatesRunner Batch This is an automated message from the Apache Git Service. To

[GitHub] [beam] boyuanzz commented on pull request #11756: [BEAM-9603] Add timer family support to FnApiDoFnRunner

2020-05-21 Thread GitBox
boyuanzz commented on pull request #11756: URL: https://github.com/apache/beam/pull/11756#issuecomment-632250883 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] boyuanzz commented on pull request #11756: [BEAM-9603] Add timer family support to FnApiDoFnRunner

2020-05-21 Thread GitBox
boyuanzz commented on pull request #11756: URL: https://github.com/apache/beam/pull/11756#issuecomment-632251140 Run Java Flink PortableValidatesRunner Streaming This is an automated message from the Apache Git Service. To

[GitHub] [beam] chamikaramj commented on pull request #11771: [BEAM-10052] check hash and avoid duplicated artifacts

2020-05-21 Thread GitBox
chamikaramj commented on pull request #11771: URL: https://github.com/apache/beam/pull/11771#issuecomment-632278144 Retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] aijamalnk opened a new pull request #11780: [WIP] Uploading mascot to the website

2020-05-21 Thread GitBox
aijamalnk opened a new pull request #11780: URL: https://github.com/apache/beam/pull/11780 **Please** add a meaningful description for your change here Thank you for your contribution! Follow this checklist to help us incorporate your contribution

[GitHub] [beam] TheNeuralBit commented on pull request #11778: [BEAM-8889][release-2.22.0] Upgrades gcsio to 2.1.3

2020-05-21 Thread GitBox
TheNeuralBit commented on pull request #11778: URL: https://github.com/apache/beam/pull/11778#issuecomment-632309156 Run Python2_PVR_Flink PreCommit This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] TheNeuralBit commented on pull request #11770: [DO NOT MERGE] Run all PostCommit and PreCommit Tests against Release Branch

2020-05-21 Thread GitBox
TheNeuralBit commented on pull request #11770: URL: https://github.com/apache/beam/pull/11770#issuecomment-632188678 Run Java Spark PortableValidatesRunner Batch This is an automated message from the Apache Git Service. To

[GitHub] [beam] TheNeuralBit commented on pull request #11770: [DO NOT MERGE] Run all PostCommit and PreCommit Tests against Release Branch

2020-05-21 Thread GitBox
TheNeuralBit commented on pull request #11770: URL: https://github.com/apache/beam/pull/11770#issuecomment-632191832 Run SQL_Java11 PreCommit This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] TheNeuralBit commented on pull request #11770: [DO NOT MERGE] Run all PostCommit and PreCommit Tests against Release Branch

2020-05-21 Thread GitBox
TheNeuralBit commented on pull request #11770: URL: https://github.com/apache/beam/pull/11770#issuecomment-632296307 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] pabloem commented on pull request #11780: [WIP] Uploading mascot to the website

2020-05-21 Thread GitBox
pabloem commented on pull request #11780: URL: https://github.com/apache/beam/pull/11780#issuecomment-632296533 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] lukecwik commented on pull request #11781: [BEAM-2939, BEAM-10057] Ensure that we can process an EmptyUnboundedSource and also prevent splitting on it.

2020-05-21 Thread GitBox
lukecwik commented on pull request #11781: URL: https://github.com/apache/beam/pull/11781#issuecomment-632303098 R: @ihji @chamikaramj CC: @TheNeuralBit (cherry pick into 2.22) This is an automated message from the

[GitHub] [beam] lukecwik opened a new pull request #11781: [BEAM-2939, BEAM-10057] Ensure that we can process an EmptyUnboundedSource and also prevent splitting on it.

2020-05-21 Thread GitBox
lukecwik opened a new pull request #11781: URL: https://github.com/apache/beam/pull/11781 Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] [**Choose

[GitHub] [beam] aaltay commented on pull request #11682: [BEAM-9946] | added new api in Partition Transform

2020-05-21 Thread GitBox
aaltay commented on pull request #11682: URL: https://github.com/apache/beam/pull/11682#issuecomment-632313262 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] rehmanmuradali commented on pull request #11774: [BEAM-1589] Added @OnWindowExpiration annotation.

2020-05-21 Thread GitBox
rehmanmuradali commented on pull request #11774: URL: https://github.com/apache/beam/pull/11774#issuecomment-632067025 R: @reuvenlax This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] rehmanmuradali opened a new pull request #11774: [BEAM-1589] Added @OnWindowExpiration annotation.

2020-05-21 Thread GitBox
rehmanmuradali opened a new pull request #11774: URL: https://github.com/apache/beam/pull/11774 Updated CHANGES.md Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ]

[GitHub] [beam] mwalenia opened a new pull request #11775: [BEAM-10050] Change labels checked in VideoIntelligenceIT

2020-05-21 Thread GitBox
mwalenia opened a new pull request #11775: URL: https://github.com/apache/beam/pull/11775 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [beam] harriskistpay opened a new pull request #11773: [BEAM-1589] Added @OnWindowExpiration annotation.

2020-05-21 Thread GitBox
harriskistpay opened a new pull request #11773: URL: https://github.com/apache/beam/pull/11773 Updated CHANGES.md file Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ]

[GitHub] [beam] harriskistpay closed pull request #11773: [BEAM-1589] Added @OnWindowExpiration annotation.

2020-05-21 Thread GitBox
harriskistpay closed pull request #11773: URL: https://github.com/apache/beam/pull/11773 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [beam] mwalenia commented on a change in pull request #11566: [BEAM-9723] Add DLP integration transforms

2020-05-21 Thread GitBox
mwalenia commented on a change in pull request #11566: URL: https://github.com/apache/beam/pull/11566#discussion_r428661780 ## File path: sdks/java/extensions/ml/src/main/java/org/apache/beam/sdk/extensions/ml/DLPDeidentifyText.java ## @@ -0,0 +1,215 @@ +/* + * Licensed to

[GitHub] [beam] mwalenia commented on a change in pull request #11566: [BEAM-9723] Add DLP integration transforms

2020-05-21 Thread GitBox
mwalenia commented on a change in pull request #11566: URL: https://github.com/apache/beam/pull/11566#discussion_r428676595 ## File path: sdks/java/extensions/ml/src/main/java/org/apache/beam/sdk/extensions/ml/DLPReidentifyText.java ## @@ -0,0 +1,206 @@ +/* + * Licensed to

[GitHub] [beam] mwalenia commented on a change in pull request #11566: [BEAM-9723] Add DLP integration transforms

2020-05-21 Thread GitBox
mwalenia commented on a change in pull request #11566: URL: https://github.com/apache/beam/pull/11566#discussion_r428679955 ## File path: sdks/java/extensions/ml/src/main/java/org/apache/beam/sdk/extensions/ml/DLPDeidentifyText.java ## @@ -0,0 +1,215 @@ +/* + * Licensed to

[GitHub] [beam] mwalenia commented on pull request #11566: [BEAM-9723] Add DLP integration transforms

2020-05-21 Thread GitBox
mwalenia commented on pull request #11566: URL: https://github.com/apache/beam/pull/11566#issuecomment-632113183 @tysonjh , @santhh Thanks for the review, I added the first batch of fixes. I'll take care of the Javadocs tomorrow.

[GitHub] [beam] kamilwu opened a new pull request #11776: [BEAM-9421] Better documentation of output results from AnnotateText transform

2020-05-21 Thread GitBox
kamilwu opened a new pull request #11776: URL: https://github.com/apache/beam/pull/11776 Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] [**Choose

[GitHub] [beam] mwalenia commented on a change in pull request #11566: [BEAM-9723] Add DLP integration transforms

2020-05-21 Thread GitBox
mwalenia commented on a change in pull request #11566: URL: https://github.com/apache/beam/pull/11566#discussion_r428666183 ## File path: sdks/java/extensions/ml/src/main/java/org/apache/beam/sdk/extensions/ml/MapStringToDlpRow.java ## @@ -0,0 +1,48 @@ +/* + * Licensed to the

[GitHub] [beam] henryken commented on pull request #11734: [BEAM-9679] Add Core Transforms section / GroupByKey lesson to the Go SDK katas

2020-05-21 Thread GitBox
henryken commented on pull request #11734: URL: https://github.com/apache/beam/pull/11734#issuecomment-632104571 Thanks @damondouglas! This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] kkucharc commented on pull request #11360: [BEAM-9722] added SnowflakeIO with Read operation

2020-05-21 Thread GitBox
kkucharc commented on pull request #11360: URL: https://github.com/apache/beam/pull/11360#issuecomment-632106649 I retested failing test - probably the previous one was timeouting. This is an automated message from the

<    1   2