[GitHub] [beam] aromanenko-dev commented on pull request #11396: [BEAM-9742] Add Configurable FluentBackoff to JdbcIO Write

2020-06-04 Thread GitBox
aromanenko-dev commented on pull request #11396: URL: https://github.com/apache/beam/pull/11396#issuecomment-638983908 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] aromanenko-dev commented on a change in pull request #11396: [BEAM-9742] Add Configurable FluentBackoff to JdbcIO Write

2020-06-04 Thread GitBox
aromanenko-dev commented on a change in pull request #11396: URL: https://github.com/apache/beam/pull/11396#discussion_r435399974 ## File path: sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcIO.java ## @@ -1217,6 +1297,16 @@ void set( return

[GitHub] [beam] aromanenko-dev commented on a change in pull request #11396: [BEAM-9742] Add Configurable FluentBackoff to JdbcIO Write

2020-06-04 Thread GitBox
aromanenko-dev commented on a change in pull request #11396: URL: https://github.com/apache/beam/pull/11396#discussion_r435399974 ## File path: sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcIO.java ## @@ -1217,6 +1297,16 @@ void set( return

[GitHub] [beam] jphalip opened a new pull request #11918: Add instructions to programmatically publish release to Github

2020-06-04 Thread GitBox
jphalip opened a new pull request #11918: URL: https://github.com/apache/beam/pull/11918 This fixes BEAM-10188. See discussion in the dev@ list: https://lists.apache.org/thread.html/re367d262333078501c47856e9b8a0fc3fd7db60c2d2ebb181275481a%40%3Cdev.beam.apache.org%3E This

[GitHub] [beam] robertwb commented on pull request #11835: Various fixes to allow Java PAssert to run on Python

2020-06-04 Thread GitBox
robertwb commented on pull request #11835: URL: https://github.com/apache/beam/pull/11835#issuecomment-638635136 Run Python PreCommit This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] robertwb commented on pull request #11913: Cleaner logging, explicit errors on unimplemented features.

2020-06-04 Thread GitBox
robertwb commented on pull request #11913: URL: https://github.com/apache/beam/pull/11913#issuecomment-638634063 Run Python PreCommit This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] mxm commented on pull request #11777: [BEAM-10054] Fix watermark hold for on_time_pane

2020-06-04 Thread GitBox
mxm commented on pull request #11777: URL: https://github.com/apache/beam/pull/11777#issuecomment-638750806 Since the test has been added and this was the missing piece here, I'm going to merge. This is an automated message

[GitHub] [beam] mxm merged pull request #11777: [BEAM-10054] Fix watermark hold for on_time_pane

2020-06-04 Thread GitBox
mxm merged pull request #11777: URL: https://github.com/apache/beam/pull/11777 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [beam] echauchot merged pull request #11732: [BEAM-10017] Expose Cassandra Connect and Read timeouts

2020-06-04 Thread GitBox
echauchot merged pull request #11732: URL: https://github.com/apache/beam/pull/11732 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [beam] echauchot commented on pull request #11732: [BEAM-10017] Expose Cassandra Connect and Read timeouts

2020-06-04 Thread GitBox
echauchot commented on pull request #11732: URL: https://github.com/apache/beam/pull/11732#issuecomment-638758007 Did the final minor touches myself and merged the PR. Thanks Nathan for your work! This is an automated

[GitHub] [beam] iemejia commented on pull request #11909: [BEAM-8134] Grafana dashboards for Nexmark tests

2020-06-04 Thread GitBox
iemejia commented on pull request #11909: URL: https://github.com/apache/beam/pull/11909#issuecomment-638789937 Wow I am impressed they look REALLY nice great job! There are some things I would like to refine e.g. to be able to choose which runners to compare or just to choose one

[GitHub] [beam] iemejia commented on pull request #11909: [BEAM-8134] Grafana dashboards for Nexmark tests

2020-06-04 Thread GitBox
iemejia commented on pull request #11909: URL: https://github.com/apache/beam/pull/11909#issuecomment-638790781 On extra nit pick: It would be nice if we could attribute a consistent color to each runner so in every view we can know the color corresponds to the runner.

[GitHub] [beam] TobKed commented on a change in pull request #11877: [BEAM-10184] Build python wheels on GitHub Actions for Linux/MacOS

2020-06-04 Thread GitBox
TobKed commented on a change in pull request #11877: URL: https://github.com/apache/beam/pull/11877#discussion_r435192970 ## File path: .github/workflows/build_wheels.yml ## @@ -0,0 +1,141 @@ +name: Build python wheels + +on: + push: +branches: + - master + -

[GitHub] [beam] TobKed commented on a change in pull request #11877: [BEAM-10184] Build python wheels on GitHub Actions for Linux/MacOS

2020-06-04 Thread GitBox
TobKed commented on a change in pull request #11877: URL: https://github.com/apache/beam/pull/11877#discussion_r435190449 ## File path: .github/workflows/build_wheels.yml ## @@ -0,0 +1,141 @@ +name: Build python wheels + +on: + push: +branches: + - master + -

[GitHub] [beam] kamilwu commented on a change in pull request #11877: [BEAM-10184] Build python wheels on GitHub Actions for Linux/MacOS

2020-06-04 Thread GitBox
kamilwu commented on a change in pull request #11877: URL: https://github.com/apache/beam/pull/11877#discussion_r435095271 ## File path: .github/workflows/build_wheels.yml ## @@ -0,0 +1,141 @@ +name: Build python wheels + +on: + push: +branches: + - master + -

[GitHub] [beam] kamilwu commented on a change in pull request #11877: [BEAM-10184] Build python wheels on GitHub Actions for Linux/MacOS

2020-06-04 Thread GitBox
kamilwu commented on a change in pull request #11877: URL: https://github.com/apache/beam/pull/11877#discussion_r435099607 ## File path: .github/workflows/build_wheels.yml ## @@ -0,0 +1,141 @@ +name: Build python wheels + +on: + push: +branches: + - master + -

[GitHub] [beam] kamilwu commented on a change in pull request #11877: [BEAM-10184] Build python wheels on GitHub Actions for Linux/MacOS

2020-06-04 Thread GitBox
kamilwu commented on a change in pull request #11877: URL: https://github.com/apache/beam/pull/11877#discussion_r435107715 ## File path: .github/workflows/build_wheels.yml ## @@ -0,0 +1,141 @@ +name: Build python wheels + +on: + push: +branches: + - master + -

[GitHub] [beam] TobKed commented on a change in pull request #11877: [BEAM-10184] Build python wheels on GitHub Actions for Linux/MacOS

2020-06-04 Thread GitBox
TobKed commented on a change in pull request #11877: URL: https://github.com/apache/beam/pull/11877#discussion_r435203092 ## File path: .github/workflows/build_wheels.yml ## @@ -0,0 +1,141 @@ +name: Build python wheels + +on: + push: +branches: + - master + -

[GitHub] [beam] TobKed commented on a change in pull request #11877: [BEAM-10184] Build python wheels on GitHub Actions for Linux/MacOS

2020-06-04 Thread GitBox
TobKed commented on a change in pull request #11877: URL: https://github.com/apache/beam/pull/11877#discussion_r435212390 ## File path: .github/workflows/build_wheels.yml ## @@ -0,0 +1,141 @@ +name: Build python wheels + +on: + push: +branches: + - master + -

[GitHub] [beam] kamilwu commented on pull request #11856: [BEAM-7505] SideInput Python Load Test job

2020-06-04 Thread GitBox
kamilwu commented on pull request #11856: URL: https://github.com/apache/beam/pull/11856#issuecomment-638816179 Run Seed Job This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [beam] kamilwu commented on pull request #11856: [BEAM-7505] SideInput Python Load Test job

2020-06-04 Thread GitBox
kamilwu commented on pull request #11856: URL: https://github.com/apache/beam/pull/11856#issuecomment-638825672 Run Python Load Tests SideInput Dataflow Batch This is an automated message from the Apache Git Service. To

[GitHub] [beam] TobKed commented on a change in pull request #11877: [BEAM-10184] Build python wheels on GitHub Actions for Linux/MacOS

2020-06-04 Thread GitBox
TobKed commented on a change in pull request #11877: URL: https://github.com/apache/beam/pull/11877#discussion_r435203092 ## File path: .github/workflows/build_wheels.yml ## @@ -0,0 +1,141 @@ +name: Build python wheels + +on: + push: +branches: + - master + -

<    1   2