[GitHub] [beam] pabloem commented on pull request #11929: [BEAM-10201] Add deadletter support to JsonToRow

2020-06-14 Thread GitBox
pabloem commented on pull request #11929: URL: https://github.com/apache/beam/pull/11929#issuecomment-643807255 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] pabloem commented on pull request #12000: BEAM-10221: Add in example tests cases of Kotlin cookbook

2020-06-14 Thread GitBox
pabloem commented on pull request #12000: URL: https://github.com/apache/beam/pull/12000#issuecomment-643807039 great! thanks for pointhing that out This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] pabloem commented on pull request #12000: BEAM-10221: Add in example tests cases of Kotlin cookbook

2020-06-14 Thread GitBox
pabloem commented on pull request #12000: URL: https://github.com/apache/beam/pull/12000#issuecomment-643807080 let me get a passing run for the tests and we'll merge This is an automated message from the Apache Git Service.

[GitHub] [beam] pabloem commented on pull request #12005: Update screen_diff deps and goldens as stable Chrome version advances.

2020-06-14 Thread GitBox
pabloem commented on pull request #12005: URL: https://github.com/apache/beam/pull/12005#issuecomment-643807184 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [beam] pabloem commented on pull request #11086: [BEAM-8910] Make custom BQ source read from Avro

2020-06-14 Thread GitBox
pabloem commented on pull request #11086: URL: https://github.com/apache/beam/pull/11086#issuecomment-643807122 Run Python PreCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] saavan-google-intern opened a new pull request #12009: [BEAM-10258] Support type hint annotations on PTransform's expand()

2020-06-14 Thread GitBox
saavan-google-intern opened a new pull request #12009: URL: https://github.com/apache/beam/pull/12009 This PR provides support for type hint annotations for PCollections in the _expand_ function of PTransforms. Thank you for your contribution! Follow

[GitHub] [beam] saavan-google-intern commented on pull request #12009: [BEAM-10258] Support type hint annotations on PTransform's expand()

2020-06-14 Thread GitBox
saavan-google-intern commented on pull request #12009: URL: https://github.com/apache/beam/pull/12009#issuecomment-643904266 R: @udim CC: @robertwb This PR is not ready for merge, but I'm making it available so we can track and discuss its progress. What do you think of

[GitHub] [beam] saavan-google-intern edited a comment on pull request #12009: [BEAM-10258] Support type hint annotations on PTransform's expand()

2020-06-14 Thread GitBox
saavan-google-intern edited a comment on pull request #12009: URL: https://github.com/apache/beam/pull/12009#issuecomment-643904266 R: @udim CC: @robertwb This PR is not ready for merge, but I'm making it available so we can track and discuss its progress. What do you

[GitHub] [beam] perkss commented on pull request #12000: BEAM-10221: Add in example tests cases of Kotlin cookbook

2020-06-14 Thread GitBox
perkss commented on pull request #12000: URL: https://github.com/apache/beam/pull/12000#issuecomment-643732433 They do actually seem to be running fine [here](https://builds.apache.org/job/beam_PreCommit_Java_Commit/lastCompletedBuild/testReport/org.apache.beam.examples.kotlin.cookbook/)

[GitHub] [beam] amaliujia commented on a change in pull request #11975: [BEAM-9198] BeamSQL aggregation analytics functionality

2020-06-14 Thread GitBox
amaliujia commented on a change in pull request #11975: URL: https://github.com/apache/beam/pull/11975#discussion_r439796555 ## File path: sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamWindowRel.java ## @@ -0,0 +1,270 @@ +/* + *

[GitHub] [beam] amaliujia commented on a change in pull request #11975: [BEAM-9198] BeamSQL aggregation analytics functionality

2020-06-14 Thread GitBox
amaliujia commented on a change in pull request #11975: URL: https://github.com/apache/beam/pull/11975#discussion_r439796682 ## File path: sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamWindowRel.java ## @@ -0,0 +1,270 @@ +/* + *

[GitHub] [beam] amaliujia commented on a change in pull request #11975: [BEAM-9198] BeamSQL aggregation analytics functionality

2020-06-14 Thread GitBox
amaliujia commented on a change in pull request #11975: URL: https://github.com/apache/beam/pull/11975#discussion_r439795971 ## File path: sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamWindowRel.java ## @@ -0,0 +1,270 @@ +/* + *

[GitHub] [beam] amaliujia commented on a change in pull request #11975: [BEAM-9198] BeamSQL aggregation analytics functionality

2020-06-14 Thread GitBox
amaliujia commented on a change in pull request #11975: URL: https://github.com/apache/beam/pull/11975#discussion_r439799050 ## File path: sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamWindowRel.java ## @@ -0,0 +1,270 @@ +/* + *

[GitHub] [beam] perkss commented on pull request #12000: BEAM-10221: Add in example tests cases of Kotlin cookbook

2020-06-14 Thread GitBox
perkss commented on pull request #12000: URL: https://github.com/apache/beam/pull/12000#issuecomment-643731912 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [beam] amaliujia commented on a change in pull request #11975: [BEAM-9198] BeamSQL aggregation analytics functionality

2020-06-14 Thread GitBox
amaliujia commented on a change in pull request #11975: URL: https://github.com/apache/beam/pull/11975#discussion_r439796776 ## File path: sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/BeamAnalyticFunctionsExperimentTest.java ## @@ -0,0 +1,187 @@