pabloem edited a comment on pull request #12147:
URL: https://github.com/apache/beam/pull/12147#issuecomment-656422531
@reubenvanammers thanks so much for your contribution!
can you please resolve the conflicts of your branch, so that we can review
the final result?
--
robinyqiu merged pull request #12214:
URL: https://github.com/apache/beam/pull/12214
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
robinyqiu commented on pull request #12214:
URL: https://github.com/apache/beam/pull/12214#issuecomment-656422978
Yes. Tested against the compliance tests.
This is an automated message from the Apache Git Service.
To respond
ihji commented on pull request #12060:
URL: https://github.com/apache/beam/pull/12060#issuecomment-656427767
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please log o
ihji removed a comment on pull request #12060:
URL: https://github.com/apache/beam/pull/12060#issuecomment-656427767
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, plea
youngoli opened a new pull request #12215:
URL: https://github.com/apache/beam/pull/12215
Pretty self-explanatory. The wrapper was basic enough that I don't think it
makes sense to test it with unit tests. You'd basically just be unit testing
the mutex. Instead, I'm testing it in practice
youngoli commented on pull request #12215:
URL: https://github.com/apache/beam/pull/12215#issuecomment-656430039
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
steveniemitz commented on pull request #12144:
URL: https://github.com/apache/beam/pull/12144#issuecomment-656431891
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, plea
saavannanavati commented on pull request #12009:
URL: https://github.com/apache/beam/pull/12009#issuecomment-656446634
Tests are passing - just need to resolve a few reviews now :D
This is an automated message from the Apache
pabloem commented on pull request #12144:
URL: https://github.com/apache/beam/pull/12144#issuecomment-656446787
Thanks Steve!
This is an automated message from the Apache Git Service.
To respond to the message, please log on
pabloem merged pull request #12144:
URL: https://github.com/apache/beam/pull/12144
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
pabloem commented on pull request #12203:
URL: https://github.com/apache/beam/pull/12203#issuecomment-656447455
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
kennknowles commented on pull request #11792:
URL: https://github.com/apache/beam/pull/11792#issuecomment-656448609
https://ci-beam.apache.org/job/beam_PreCommit_Python_Commit/13653/ appears
to be a failure in unrelated code. It does not look like something that would
flake. Perhaps `maste
kennknowles commented on pull request #11792:
URL: https://github.com/apache/beam/pull/11792#issuecomment-656448688
Run Python PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, ple
angoenka commented on pull request #12210:
URL: https://github.com/apache/beam/pull/12210#issuecomment-656450990
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please l
lostluck commented on a change in pull request #12215:
URL: https://github.com/apache/beam/pull/12215#discussion_r452600578
##
File path: sdks/go/pkg/beam/io/synthetic/source.go
##
@@ -124,8 +125,8 @@ func (fn *sourceFn) Setup() {
// ProcessElement creates a number of random e
piotr-szuberski commented on a change in pull request #12145:
URL: https://github.com/apache/beam/pull/12145#discussion_r452610919
##
File path: CHANGES.md
##
@@ -78,6 +78,8 @@
is experimental. It reads data from BigQuery by exporting data to Avro
files, and reading those f
piotr-szuberski commented on a change in pull request #12145:
URL: https://github.com/apache/beam/pull/12145#discussion_r452611151
##
File path: sdks/java/container/boot.go
##
@@ -122,6 +122,7 @@ func main() {
filepath.Join(jarsDir, "beam-sdks-java-harness.jar")
piotr-szuberski commented on a change in pull request #12145:
URL: https://github.com/apache/beam/pull/12145#discussion_r452611306
##
File path: sdks/java/io/jdbc/build.gradle
##
@@ -25,6 +25,7 @@ description = "Apache Beam :: SDKs :: Java :: IO :: JDBC"
ext.summary = "IO to r
piotr-szuberski commented on a change in pull request #12145:
URL: https://github.com/apache/beam/pull/12145#discussion_r452611468
##
File path:
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
##
@@ -1982,17 +1982,25 @@ class BeamModulePlugin implements
piotr-szuberski commented on pull request #12145:
URL: https://github.com/apache/beam/pull/12145#issuecomment-656471698
Run Python 3.8 PostCommit
This is an automated message from the Apache Git Service.
To respond to the mes
piotr-szuberski commented on a change in pull request #12145:
URL: https://github.com/apache/beam/pull/12145#discussion_r452611306
##
File path: sdks/java/io/jdbc/build.gradle
##
@@ -25,6 +25,7 @@ description = "Apache Beam :: SDKs :: Java :: IO :: JDBC"
ext.summary = "IO to r
piotr-szuberski commented on pull request #12145:
URL: https://github.com/apache/beam/pull/12145#issuecomment-656479859
Run Python 3.8 PostCommit
This is an automated message from the Apache Git Service.
To respond to the mes
chamikaramj commented on pull request #12071:
URL: https://github.com/apache/beam/pull/12071#issuecomment-656499289
@pskevin please let us know when comments here have been addressed.
This is an automated message from the Apa
chamikaramj commented on a change in pull request #11919:
URL: https://github.com/apache/beam/pull/11919#discussion_r452650942
##
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsublite/PubsubLiteIO.java
##
@@ -0,0 +1,75 @@
+/*
+ * Lic
piotr-szuberski commented on pull request #12145:
URL: https://github.com/apache/beam/pull/12145#issuecomment-656514840
Run Python 3.8 PostCommit
This is an automated message from the Apache Git Service.
To respond to the mes
piotr-szuberski commented on pull request #12145:
URL: https://github.com/apache/beam/pull/12145#issuecomment-656515114
Run Python PreCommit
This is an automated message from the Apache Git Service.
To respond to the message,
piotr-szuberski commented on pull request #12145:
URL: https://github.com/apache/beam/pull/12145#issuecomment-656515318
Run Python2_PVR_Flink PreCommit
This is an automated message from the Apache Git Service.
To respond to t
101 - 128 of 128 matches
Mail list logo