[GitHub] [beam] danielxjd commented on a change in pull request #12223: [Beam-4379] Make ParquetIO read splittable

2020-08-31 Thread GitBox
danielxjd commented on a change in pull request #12223: URL: https://github.com/apache/beam/pull/12223#discussion_r480763844 ## File path: sdks/java/io/parquet/src/main/java/org/apache/beam/sdk/io/parquet/ParquetIO.java ## @@ -229,15 +279,259 @@ public void

[GitHub] [beam] Mark-Zeng commented on a change in pull request #12735: [BEAM-9543] Add blog post for MATCH_RECOGNIZE

2020-08-31 Thread GitBox
Mark-Zeng commented on a change in pull request #12735: URL: https://github.com/apache/beam/pull/12735#discussion_r480846030 ## File path: website/www/site/content/en/blog/pattern-match-beam-sql.md ## @@ -0,0 +1,167 @@ +--- +title: "Pattern Matching with Beam SQL" +date:

[GitHub] [beam] saavannanavati commented on pull request #12739: [BEAM-10840] Don't run code coverage on microbenchmarks

2020-08-31 Thread GitBox
saavannanavati commented on pull request #12739: URL: https://github.com/apache/beam/pull/12739#issuecomment-684005479 R: @udim I noticed that most microbenchmarks have 0% coverage on Codecov, for example

[GitHub] [beam] KevinGG commented on pull request #12740: [BEAM-10775] Added nodejs installation and documentation

2020-08-31 Thread GitBox
KevinGG commented on pull request #12740: URL: https://github.com/apache/beam/pull/12740#issuecomment-684044675 Run Typescript PreCommit This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] suztomo commented on pull request #12695: [BEAM-8758] Google-cloud-spanner upgrade to 1.59.0 and google_cloud_bigtable_client_core to 1.16.0

2020-08-31 Thread GitBox
suztomo commented on pull request #12695: URL: https://github.com/apache/beam/pull/12695#issuecomment-684062474 Run Typescript Precommit This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] suztomo commented on pull request #12695: [BEAM-8758] Google-cloud-spanner upgrade to 1.59.0 and google_cloud_bigtable_client_core to 1.16.0

2020-08-31 Thread GitBox
suztomo commented on pull request #12695: URL: https://github.com/apache/beam/pull/12695#issuecomment-684062355 Run Python Precommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] lukecwik commented on pull request #12737: [BEAM-10825] Fix null pointer for non-Jenkins build.

2020-08-31 Thread GitBox
lukecwik commented on pull request #12737: URL: https://github.com/apache/beam/pull/12737#issuecomment-684075960 Thanks for the fix, this also broke the linkage checker. This is an automated message from the Apache Git

[GitHub] [beam] codecov[bot] edited a comment on pull request #12740: [BEAM-10775] Added nodejs installation and documentation

2020-08-31 Thread GitBox
codecov[bot] edited a comment on pull request #12740: URL: https://github.com/apache/beam/pull/12740#issuecomment-684052125 # [Codecov](https://codecov.io/gh/apache/beam/pull/12740?src=pr=h1) Report > Merging [#12740](https://codecov.io/gh/apache/beam/pull/12740?src=pr=desc) into

[GitHub] [beam] lukecwik commented on a change in pull request #12742: [BEAM-10843] Fix NPE in websites/build.gradle preventing linkage checker from working since the property isn't defined.

2020-08-31 Thread GitBox
lukecwik commented on a change in pull request #12742: URL: https://github.com/apache/beam/pull/12742#discussion_r480459505 ## File path: website/build.gradle ## @@ -75,7 +75,7 @@ task createDockerContainer(type: Exec) { // "jenkins" user ownership. BEAM-9737 //

[GitHub] [beam] y1chi commented on pull request #12727: [BEAM-10844] Add experiment option prebuild_sdk_container to prebuild python sdk container with dependencies.

2020-08-31 Thread GitBox
y1chi commented on pull request #12727: URL: https://github.com/apache/beam/pull/12727#issuecomment-684128579 R: @tvalentyn @robertwb @angoenka CC: @ananvay This is an automated message from the Apache Git Service. To

[GitHub] [beam] youngoli commented on pull request #12743: [DO NOT MERGE] Update Beam website to release 2.24.0.

2020-08-31 Thread GitBox
youngoli commented on pull request #12743: URL: https://github.com/apache/beam/pull/12743#issuecomment-684146158 R: @tvalentyn This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [beam] zeidoo commented on pull request #9779: [BEAM-8388] Updating avro dependency from 1.8.2 to 1.9.1

2020-08-31 Thread GitBox
zeidoo commented on pull request #9779: URL: https://github.com/apache/beam/pull/9779#issuecomment-684231771 Hi everyone, I think I managed to move (**not upgrade**) all the Avro logic from sdk.core to sdk.extensions.avro (right besides protobuf). I also updated all usages and most

[GitHub] [beam] piotr-szuberski commented on pull request #12297: [BEAM-10137] Add KinesisIO for cross-language usage with python wrapper

2020-08-31 Thread GitBox
piotr-szuberski commented on pull request #12297: URL: https://github.com/apache/beam/pull/12297#issuecomment-683591758 > Please resolve the conflict. @chamikaramj Done This is an automated message from the Apache Git

[GitHub] [beam] piotr-szuberski commented on pull request #12297: [BEAM-10137] Add KinesisIO for cross-language usage with python wrapper

2020-08-31 Thread GitBox
piotr-szuberski commented on pull request #12297: URL: https://github.com/apache/beam/pull/12297#issuecomment-683606541 Run Python 3.8 PostCommit This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] chamikaramj commented on pull request #12655: [BEAM-10779] Support multiple main inputs and side inputs for PTransformOverride

2020-08-31 Thread GitBox
chamikaramj commented on pull request #12655: URL: https://github.com/apache/beam/pull/12655#issuecomment-683610025 Retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] chamikaramj commented on pull request #12656: [BEAM-10781] Add PTransformOverride.get_replacement_transform_for_applied_ptransform()

2020-08-31 Thread GitBox
chamikaramj commented on pull request #12656: URL: https://github.com/apache/beam/pull/12656#issuecomment-683609986 Retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] piotr-szuberski commented on pull request #12297: [BEAM-10137] Add KinesisIO for cross-language usage with python wrapper

2020-08-31 Thread GitBox
piotr-szuberski commented on pull request #12297: URL: https://github.com/apache/beam/pull/12297#issuecomment-683609297 Run Typescript PreCommit This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] codecov[bot] edited a comment on pull request #12655: [BEAM-10779] Support multiple main inputs and side inputs for PTransformOverride

2020-08-31 Thread GitBox
codecov[bot] edited a comment on pull request #12655: URL: https://github.com/apache/beam/pull/12655#issuecomment-683610461 # [Codecov](https://codecov.io/gh/apache/beam/pull/12655?src=pr=h1) Report > Merging [#12655](https://codecov.io/gh/apache/beam/pull/12655?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12655: [BEAM-10779] Support multiple main inputs and side inputs for PTransformOverride

2020-08-31 Thread GitBox
codecov[bot] edited a comment on pull request #12655: URL: https://github.com/apache/beam/pull/12655#issuecomment-683610461 # [Codecov](https://codecov.io/gh/apache/beam/pull/12655?src=pr=h1) Report > Merging [#12655](https://codecov.io/gh/apache/beam/pull/12655?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12655: [BEAM-10779] Support multiple main inputs and side inputs for PTransformOverride

2020-08-31 Thread GitBox
codecov[bot] edited a comment on pull request #12655: URL: https://github.com/apache/beam/pull/12655#issuecomment-683610461 # [Codecov](https://codecov.io/gh/apache/beam/pull/12655?src=pr=h1) Report > Merging [#12655](https://codecov.io/gh/apache/beam/pull/12655?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12656: [BEAM-10781] Add PTransformOverride.get_replacement_transform_for_applied_ptransform()

2020-08-31 Thread GitBox
codecov[bot] edited a comment on pull request #12656: URL: https://github.com/apache/beam/pull/12656#issuecomment-683610379 # [Codecov](https://codecov.io/gh/apache/beam/pull/12656?src=pr=h1) Report > Merging [#12656](https://codecov.io/gh/apache/beam/pull/12656?src=pr=desc) into

[GitHub] [beam] codecov[bot] commented on pull request #12297: [BEAM-10137] Add KinesisIO for cross-language usage with python wrapper

2020-08-31 Thread GitBox
codecov[bot] commented on pull request #12297: URL: https://github.com/apache/beam/pull/12297#issuecomment-683598608 # [Codecov](https://codecov.io/gh/apache/beam/pull/12297?src=pr=h1) Report > Merging [#12297](https://codecov.io/gh/apache/beam/pull/12297?src=pr=desc) into

[GitHub] [beam] echauchot commented on pull request #12592: [BEAM-8025] Update tests to use TemporaryFolder instead of rolling their own implementation.

2020-08-31 Thread GitBox
echauchot commented on pull request #12592: URL: https://github.com/apache/beam/pull/12592#issuecomment-683620895 @lukecwik the change you did on cassandraIO was the one I reverted in [that PR](https://github.com/apache/beam/pull/9614#issuecomment-534164189). In short: cassandra running

[GitHub] [beam] codecov[bot] edited a comment on pull request #12656: [BEAM-10781] Add PTransformOverride.get_replacement_transform_for_applied_ptransform()

2020-08-31 Thread GitBox
codecov[bot] edited a comment on pull request #12656: URL: https://github.com/apache/beam/pull/12656#issuecomment-683610379 # [Codecov](https://codecov.io/gh/apache/beam/pull/12656?src=pr=h1) Report > Merging [#12656](https://codecov.io/gh/apache/beam/pull/12656?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12297: [BEAM-10137] Add KinesisIO for cross-language usage with python wrapper

2020-08-31 Thread GitBox
codecov[bot] edited a comment on pull request #12297: URL: https://github.com/apache/beam/pull/12297#issuecomment-683598608 # [Codecov](https://codecov.io/gh/apache/beam/pull/12297?src=pr=h1) Report > Merging [#12297](https://codecov.io/gh/apache/beam/pull/12297?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12656: [BEAM-10781] Add PTransformOverride.get_replacement_transform_for_applied_ptransform()

2020-08-31 Thread GitBox
codecov[bot] edited a comment on pull request #12656: URL: https://github.com/apache/beam/pull/12656#issuecomment-683610379 # [Codecov](https://codecov.io/gh/apache/beam/pull/12656?src=pr=h1) Report > Merging [#12656](https://codecov.io/gh/apache/beam/pull/12656?src=pr=desc) into

[GitHub] [beam] codecov[bot] commented on pull request #12611: [BEAM-10139][BEAM-10140] Add cross-language support for Java SpannerIO with python wrapper

2020-08-31 Thread GitBox
codecov[bot] commented on pull request #12611: URL: https://github.com/apache/beam/pull/12611#issuecomment-683611200 # [Codecov](https://codecov.io/gh/apache/beam/pull/12611?src=pr=h1) Report > :exclamation: No coverage uploaded for pull request head (`spanner-xlang@fed767a`). [Click

[GitHub] [beam] codecov[bot] edited a comment on pull request #12655: [BEAM-10779] Support multiple main inputs and side inputs for PTransformOverride

2020-08-31 Thread GitBox
codecov[bot] edited a comment on pull request #12655: URL: https://github.com/apache/beam/pull/12655#issuecomment-683610461 # [Codecov](https://codecov.io/gh/apache/beam/pull/12655?src=pr=h1) Report > Merging [#12655](https://codecov.io/gh/apache/beam/pull/12655?src=pr=desc) into

[GitHub] [beam] codecov[bot] commented on pull request #12656: [BEAM-10781] Add PTransformOverride.get_replacement_transform_for_applied_ptransform()

2020-08-31 Thread GitBox
codecov[bot] commented on pull request #12656: URL: https://github.com/apache/beam/pull/12656#issuecomment-683610379 # [Codecov](https://codecov.io/gh/apache/beam/pull/12656?src=pr=h1) Report > Merging [#12656](https://codecov.io/gh/apache/beam/pull/12656?src=pr=desc) into

[GitHub] [beam] codecov[bot] commented on pull request #12655: [BEAM-10779] Support multiple main inputs and side inputs for PTransformOverride

2020-08-31 Thread GitBox
codecov[bot] commented on pull request #12655: URL: https://github.com/apache/beam/pull/12655#issuecomment-683610461 # [Codecov](https://codecov.io/gh/apache/beam/pull/12655?src=pr=h1) Report > Merging [#12655](https://codecov.io/gh/apache/beam/pull/12655?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12297: [BEAM-10137] Add KinesisIO for cross-language usage with python wrapper

2020-08-31 Thread GitBox
codecov[bot] edited a comment on pull request #12297: URL: https://github.com/apache/beam/pull/12297#issuecomment-683598608 # [Codecov](https://codecov.io/gh/apache/beam/pull/12297?src=pr=h1) Report > Merging [#12297](https://codecov.io/gh/apache/beam/pull/12297?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12297: [BEAM-10137] Add KinesisIO for cross-language usage with python wrapper

2020-08-31 Thread GitBox
codecov[bot] edited a comment on pull request #12297: URL: https://github.com/apache/beam/pull/12297#issuecomment-683598608 # [Codecov](https://codecov.io/gh/apache/beam/pull/12297?src=pr=h1) Report > Merging [#12297](https://codecov.io/gh/apache/beam/pull/12297?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12656: [BEAM-10781] Add PTransformOverride.get_replacement_transform_for_applied_ptransform()

2020-08-31 Thread GitBox
codecov[bot] edited a comment on pull request #12656: URL: https://github.com/apache/beam/pull/12656#issuecomment-683610379 # [Codecov](https://codecov.io/gh/apache/beam/pull/12656?src=pr=h1) Report > Merging [#12656](https://codecov.io/gh/apache/beam/pull/12656?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12655: [BEAM-10779] Support multiple main inputs and side inputs for PTransformOverride

2020-08-31 Thread GitBox
codecov[bot] edited a comment on pull request #12655: URL: https://github.com/apache/beam/pull/12655#issuecomment-683610461 # [Codecov](https://codecov.io/gh/apache/beam/pull/12655?src=pr=h1) Report > Merging [#12655](https://codecov.io/gh/apache/beam/pull/12655?src=pr=desc) into

[GitHub] [beam] echauchot commented on pull request #12592: [BEAM-8025] Update tests to use TemporaryFolder instead of rolling their own implementation.

2020-08-31 Thread GitBox
echauchot commented on pull request #12592: URL: https://github.com/apache/beam/pull/12592#issuecomment-683613759 @lukecwik sorry I was on vacation. I just got back. Thanks @pabloem for reviewing/merging. This is an

[GitHub] [beam] codecov[bot] edited a comment on pull request #12656: [BEAM-10781] Add PTransformOverride.get_replacement_transform_for_applied_ptransform()

2020-08-31 Thread GitBox
codecov[bot] edited a comment on pull request #12656: URL: https://github.com/apache/beam/pull/12656#issuecomment-683610379 # [Codecov](https://codecov.io/gh/apache/beam/pull/12656?src=pr=h1) Report > Merging [#12656](https://codecov.io/gh/apache/beam/pull/12656?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12655: [BEAM-10779] Support multiple main inputs and side inputs for PTransformOverride

2020-08-31 Thread GitBox
codecov[bot] edited a comment on pull request #12655: URL: https://github.com/apache/beam/pull/12655#issuecomment-683610461 # [Codecov](https://codecov.io/gh/apache/beam/pull/12655?src=pr=h1) Report > Merging [#12655](https://codecov.io/gh/apache/beam/pull/12655?src=pr=desc) into

[GitHub] [beam] chamikaramj commented on pull request #12655: [BEAM-10779] Support multiple main inputs and side inputs for PTransformOverride

2020-08-31 Thread GitBox
chamikaramj commented on pull request #12655: URL: https://github.com/apache/beam/pull/12655#issuecomment-684003860 Yeah, seems like Python PreCommit is broken currently. We'll have to wait till HEAD is fixed to retry tests. cc: @ibzib

[GitHub] [beam] codecov[bot] edited a comment on pull request #12655: [BEAM-10779] Support multiple main inputs and side inputs for PTransformOverride

2020-08-31 Thread GitBox
codecov[bot] edited a comment on pull request #12655: URL: https://github.com/apache/beam/pull/12655#issuecomment-683610461 # [Codecov](https://codecov.io/gh/apache/beam/pull/12655?src=pr=h1) Report > Merging [#12655](https://codecov.io/gh/apache/beam/pull/12655?src=pr=desc) into

[GitHub] [beam] KevinGG opened a new pull request #12740: [BEAM-10775] Added nodejs installation and documentation

2020-08-31 Thread GitBox
KevinGG opened a new pull request #12740: URL: https://github.com/apache/beam/pull/12740 1. Added nodejs installation in scripts because Node.js is needed by jlpm. 2. Added documentation of the typescript job to pull request template and README.

[GitHub] [beam] KevinGG commented on pull request #12740: [BEAM-10775] Added nodejs installation and documentation

2020-08-31 Thread GitBox
KevinGG commented on pull request #12740: URL: https://github.com/apache/beam/pull/12740#issuecomment-684026949 Run Typescript PreCommit This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] yifanmai commented on pull request #12605: Copy subtransforms to output of translations.pipeline_from_stages()

2020-08-31 Thread GitBox
yifanmai commented on pull request #12605: URL: https://github.com/apache/beam/pull/12605#issuecomment-684026787 Is this ready to merge? This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] codecov[bot] commented on pull request #12740: [BEAM-10775] Added nodejs installation and documentation

2020-08-31 Thread GitBox
codecov[bot] commented on pull request #12740: URL: https://github.com/apache/beam/pull/12740#issuecomment-684052125 # [Codecov](https://codecov.io/gh/apache/beam/pull/12740?src=pr=h1) Report > Merging [#12740](https://codecov.io/gh/apache/beam/pull/12740?src=pr=desc) into

[GitHub] [beam] lukecwik opened a new pull request #12741: [BEAM-5002] Upgrade SLF4J version to latest 1.7 patch version

2020-08-31 Thread GitBox
lukecwik opened a new pull request #12741: URL: https://github.com/apache/beam/pull/12741 Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] [**Choose

[GitHub] [beam] ibzib commented on a change in pull request #12742: [BEAM-10843] Fix NPE in websites/build.gradle preventing linkage checker from working since the property isn't defined.

2020-08-31 Thread GitBox
ibzib commented on a change in pull request #12742: URL: https://github.com/apache/beam/pull/12742#discussion_r480441082 ## File path: website/build.gradle ## @@ -75,7 +75,7 @@ task createDockerContainer(type: Exec) { // "jenkins" user ownership. BEAM-9737 //

[GitHub] [beam] codecov[bot] edited a comment on pull request #12741: [BEAM-5002] Upgrade SLF4J version to latest 1.7 patch version

2020-08-31 Thread GitBox
codecov[bot] edited a comment on pull request #12741: URL: https://github.com/apache/beam/pull/12741#issuecomment-684076400 # [Codecov](https://codecov.io/gh/apache/beam/pull/12741?src=pr=h1) Report > Merging [#12741](https://codecov.io/gh/apache/beam/pull/12741?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12703: [BEAM-10603] Add describe and cancel to RecordingManager

2020-08-31 Thread GitBox
codecov[bot] edited a comment on pull request #12703: URL: https://github.com/apache/beam/pull/12703#issuecomment-684004590 # [Codecov](https://codecov.io/gh/apache/beam/pull/12703?src=pr=h1) Report > Merging [#12703](https://codecov.io/gh/apache/beam/pull/12703?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12740: [BEAM-10775] Added nodejs installation and documentation

2020-08-31 Thread GitBox
codecov[bot] edited a comment on pull request #12740: URL: https://github.com/apache/beam/pull/12740#issuecomment-684052125 # [Codecov](https://codecov.io/gh/apache/beam/pull/12740?src=pr=h1) Report > Merging [#12740](https://codecov.io/gh/apache/beam/pull/12740?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12727: Add option to prebuild python sdk container

2020-08-31 Thread GitBox
codecov[bot] edited a comment on pull request #12727: URL: https://github.com/apache/beam/pull/12727#issuecomment-683229966 # [Codecov](https://codecov.io/gh/apache/beam/pull/12727?src=pr=h1) Report > Merging [#12727](https://codecov.io/gh/apache/beam/pull/12727?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12727: [BEAM-10844] Add experiment option prebuild_sdk_container to prebuild python sdk container with dependencies.

2020-08-31 Thread GitBox
codecov[bot] edited a comment on pull request #12727: URL: https://github.com/apache/beam/pull/12727#issuecomment-683229966 # [Codecov](https://codecov.io/gh/apache/beam/pull/12727?src=pr=h1) Report > Merging [#12727](https://codecov.io/gh/apache/beam/pull/12727?src=pr=desc) into

[GitHub] [beam] KevinGG commented on pull request #12626: [BEAM-10545] Added the inspector of PCollections and pipelines

2020-08-31 Thread GitBox
KevinGG commented on pull request #12626: URL: https://github.com/apache/beam/pull/12626#issuecomment-684025308 Rebased to head to resolve failures in Python tests. This is an automated message from the Apache Git Service.

[GitHub] [beam] codecov[bot] edited a comment on pull request #12626: [BEAM-10545] Added the inspector of PCollections and pipelines

2020-08-31 Thread GitBox
codecov[bot] edited a comment on pull request #12626: URL: https://github.com/apache/beam/pull/12626#issuecomment-682133929 # [Codecov](https://codecov.io/gh/apache/beam/pull/12626?src=pr=h1) Report > Merging [#12626](https://codecov.io/gh/apache/beam/pull/12626?src=pr=desc) into

[GitHub] [beam] danielxjd commented on pull request #12223: [Beam-4379] Make ParquetIO read splittable

2020-08-31 Thread GitBox
danielxjd commented on pull request #12223: URL: https://github.com/apache/beam/pull/12223#issuecomment-684054730 A TODO for more precise progress update: [BEAM-10842](https://issues.apache.org/jira/browse/BEAM-10842 ) This

[GitHub] [beam] KevinGG commented on pull request #12740: [BEAM-10775] Added nodejs installation and documentation

2020-08-31 Thread GitBox
KevinGG commented on pull request #12740: URL: https://github.com/apache/beam/pull/12740#issuecomment-684060589 Run Typescript PreCommit This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] codecov[bot] edited a comment on pull request #12740: [BEAM-10775] Added nodejs installation and documentation

2020-08-31 Thread GitBox
codecov[bot] edited a comment on pull request #12740: URL: https://github.com/apache/beam/pull/12740#issuecomment-684052125 # [Codecov](https://codecov.io/gh/apache/beam/pull/12740?src=pr=h1) Report > Merging [#12740](https://codecov.io/gh/apache/beam/pull/12740?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12695: [BEAM-8758] Google-cloud-spanner upgrade to 1.59.0 and google_cloud_bigtable_client_core to 1.16.0

2020-08-31 Thread GitBox
codecov[bot] edited a comment on pull request #12695: URL: https://github.com/apache/beam/pull/12695#issuecomment-682258884 # [Codecov](https://codecov.io/gh/apache/beam/pull/12695?src=pr=h1) Report > :exclamation: No coverage uploaded for pull request base (`master@1019ef3`). [Click

[GitHub] [beam] codecov[bot] edited a comment on pull request #12741: [BEAM-5002] Upgrade SLF4J version to latest 1.7 patch version

2020-08-31 Thread GitBox
codecov[bot] edited a comment on pull request #12741: URL: https://github.com/apache/beam/pull/12741#issuecomment-684076400 # [Codecov](https://codecov.io/gh/apache/beam/pull/12741?src=pr=h1) Report > Merging [#12741](https://codecov.io/gh/apache/beam/pull/12741?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12741: [BEAM-5002] Upgrade SLF4J version to latest 1.7 patch version

2020-08-31 Thread GitBox
codecov[bot] edited a comment on pull request #12741: URL: https://github.com/apache/beam/pull/12741#issuecomment-684076400 # [Codecov](https://codecov.io/gh/apache/beam/pull/12741?src=pr=h1) Report > Merging [#12741](https://codecov.io/gh/apache/beam/pull/12741?src=pr=desc) into

[GitHub] [beam] KevinGG commented on pull request #12740: [BEAM-10775] Added nodejs installation and documentation

2020-08-31 Thread GitBox
KevinGG commented on pull request #12740: URL: https://github.com/apache/beam/pull/12740#issuecomment-684104673 Run Python PreCommit failed due to BEAM-10841. This PR does not contain Python code change and the `Typescript ("Run Typescript PreCommit")` has passed.

[GitHub] [beam] KevinGG commented on pull request #12740: [BEAM-10775] Added nodejs installation and documentation

2020-08-31 Thread GitBox
KevinGG commented on pull request #12740: URL: https://github.com/apache/beam/pull/12740#issuecomment-684104758 R: @pabloem PTAL, thx This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] codecov[bot] edited a comment on pull request #12727: [BEAM-10844] Add experiment option prebuild_sdk_container to prebuild python sdk container with dependencies.

2020-08-31 Thread GitBox
codecov[bot] edited a comment on pull request #12727: URL: https://github.com/apache/beam/pull/12727#issuecomment-683229966 # [Codecov](https://codecov.io/gh/apache/beam/pull/12727?src=pr=h1) Report > Merging [#12727](https://codecov.io/gh/apache/beam/pull/12727?src=pr=desc) into

[GitHub] [beam] tvalentyn commented on a change in pull request #12743: [DO NOT MERGE] Update Beam website to release 2.24.0.

2020-08-31 Thread GitBox
tvalentyn commented on a change in pull request #12743: URL: https://github.com/apache/beam/pull/12743#discussion_r480675501 ## File path: website/www/site/content/en/get-started/downloads.md ## @@ -87,16 +87,24 @@ versions denoted `0.x.y`. ## Releases +### 2.24.0

[GitHub] [beam] boyuanzz commented on a change in pull request #12223: [Beam-4379] Make ParquetIO read splittable

2020-08-31 Thread GitBox
boyuanzz commented on a change in pull request #12223: URL: https://github.com/apache/beam/pull/12223#discussion_r480654132 ## File path: sdks/java/io/parquet/src/main/java/org/apache/beam/sdk/io/parquet/ParquetIO.java ## @@ -229,15 +279,259 @@ public void

[GitHub] [beam] pabloem commented on pull request #12732: Supporting delimiter for GcsUtil.listObjects

2020-08-31 Thread GitBox
pabloem commented on pull request #12732: URL: https://github.com/apache/beam/pull/12732#issuecomment-684028890 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] codecov[bot] edited a comment on pull request #12695: [BEAM-8758] Google-cloud-spanner upgrade to 1.59.0 and google_cloud_bigtable_client_core to 1.16.0

2020-08-31 Thread GitBox
codecov[bot] edited a comment on pull request #12695: URL: https://github.com/apache/beam/pull/12695#issuecomment-682258884 # [Codecov](https://codecov.io/gh/apache/beam/pull/12695?src=pr=h1) Report > :exclamation: No coverage uploaded for pull request base (`master@1019ef3`). [Click

[GitHub] [beam] KevinGG commented on pull request #12740: [BEAM-10775] Added nodejs installation and documentation

2020-08-31 Thread GitBox
KevinGG commented on pull request #12740: URL: https://github.com/apache/beam/pull/12740#issuecomment-684085411 Run Typescript PreCommit This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] lukecwik commented on pull request #12741: [BEAM-5002] Upgrade SLF4J version to latest 1.7 patch version

2020-08-31 Thread GitBox
lukecwik commented on pull request #12741: URL: https://github.com/apache/beam/pull/12741#issuecomment-684085394 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] lukecwik commented on pull request #12741: [BEAM-5002] Upgrade SLF4J version to latest 1.7 patch version

2020-08-31 Thread GitBox
lukecwik commented on pull request #12741: URL: https://github.com/apache/beam/pull/12741#issuecomment-684085308 Linkage checker results: No new linkage errors. Full results: https://gist.github.com/lukecwik/4dc7e4428a66dbf2fe4b9bc770877995

[GitHub] [beam] lukecwik commented on pull request #12741: [BEAM-5002] Upgrade SLF4J version to latest 1.7 patch version

2020-08-31 Thread GitBox
lukecwik commented on pull request #12741: URL: https://github.com/apache/beam/pull/12741#issuecomment-684085421 Run Python PreCommit This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] saavannanavati edited a comment on pull request #12739: [BEAM-10840] Don't run code coverage on microbenchmarks

2020-08-31 Thread GitBox
saavannanavati edited a comment on pull request #12739: URL: https://github.com/apache/beam/pull/12739#issuecomment-684005479 R: @udim I noticed that most microbenchmarks have 0% coverage on Codecov, for example

[GitHub] [beam] pulasthi opened a new pull request #12744: [BEAM-10463] Twister2 Beam Runner Documentation

2020-08-31 Thread GitBox
pulasthi opened a new pull request #12744: URL: https://github.com/apache/beam/pull/12744 Adding Twister2 Beam Runner Documentation Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[GitHub] [beam] pulasthi commented on pull request #12744: [BEAM-10463] Twister2 Beam Runner Documentation

2020-08-31 Thread GitBox
pulasthi commented on pull request #12744: URL: https://github.com/apache/beam/pull/12744#issuecomment-684153940 R: @iemejia This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [beam] boyuanzz commented on pull request #12718: More logging for missing next work index.

2020-08-31 Thread GitBox
boyuanzz commented on pull request #12718: URL: https://github.com/apache/beam/pull/12718#issuecomment-684011092 Run Java_Examples_Dataflow_Java11 PreCommit This is an automated message from the Apache Git Service. To

[GitHub] [beam] boyuanzz commented on pull request #12718: More logging for missing next work index.

2020-08-31 Thread GitBox
boyuanzz commented on pull request #12718: URL: https://github.com/apache/beam/pull/12718#issuecomment-684010984 Run Java_Examples_Dataflow PreCommit This is an automated message from the Apache Git Service. To respond to

[GitHub] [beam] codecov[bot] edited a comment on pull request #12703: [BEAM-10603] Add describe and cancel to RecordingManager

2020-08-31 Thread GitBox
codecov[bot] edited a comment on pull request #12703: URL: https://github.com/apache/beam/pull/12703#issuecomment-684004590 # [Codecov](https://codecov.io/gh/apache/beam/pull/12703?src=pr=h1) Report > Merging [#12703](https://codecov.io/gh/apache/beam/pull/12703?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12703: [BEAM-10603] Add describe and cancel to RecordingManager

2020-08-31 Thread GitBox
codecov[bot] edited a comment on pull request #12703: URL: https://github.com/apache/beam/pull/12703#issuecomment-684004590 # [Codecov](https://codecov.io/gh/apache/beam/pull/12703?src=pr=h1) Report > Merging [#12703](https://codecov.io/gh/apache/beam/pull/12703?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12740: [BEAM-10775] Added nodejs installation and documentation

2020-08-31 Thread GitBox
codecov[bot] edited a comment on pull request #12740: URL: https://github.com/apache/beam/pull/12740#issuecomment-684052125 # [Codecov](https://codecov.io/gh/apache/beam/pull/12740?src=pr=h1) Report > Merging [#12740](https://codecov.io/gh/apache/beam/pull/12740?src=pr=desc) into

[GitHub] [beam] youngoli opened a new pull request #12743: [DO NOT MERGE] Update Beam website to release 2.24.0.

2020-08-31 Thread GitBox
youngoli opened a new pull request #12743: URL: https://github.com/apache/beam/pull/12743 Preparing a website update PR according to https://beam.apache.org/contribute/release-guide/#propose-pull-requests-for-website-updates This should not be merged until the release candidate is

[GitHub] [beam] codecov[bot] edited a comment on pull request #12703: [BEAM-10603] Add describe and cancel to RecordingManager

2020-08-31 Thread GitBox
codecov[bot] edited a comment on pull request #12703: URL: https://github.com/apache/beam/pull/12703#issuecomment-684004590 # [Codecov](https://codecov.io/gh/apache/beam/pull/12703?src=pr=h1) Report > Merging [#12703](https://codecov.io/gh/apache/beam/pull/12703?src=pr=desc) into

[GitHub] [beam] KevinGG commented on pull request #12740: [BEAM-10775] Added nodejs installation and documentation

2020-08-31 Thread GitBox
KevinGG commented on pull request #12740: URL: https://github.com/apache/beam/pull/12740#issuecomment-684030116 Run Typescript PreCommit This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] codecov[bot] edited a comment on pull request #12703: [BEAM-10603] Add describe and cancel to RecordingManager

2020-08-31 Thread GitBox
codecov[bot] edited a comment on pull request #12703: URL: https://github.com/apache/beam/pull/12703#issuecomment-684004590 # [Codecov](https://codecov.io/gh/apache/beam/pull/12703?src=pr=h1) Report > Merging [#12703](https://codecov.io/gh/apache/beam/pull/12703?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12740: [BEAM-10775] Added nodejs installation and documentation

2020-08-31 Thread GitBox
codecov[bot] edited a comment on pull request #12740: URL: https://github.com/apache/beam/pull/12740#issuecomment-684052125 # [Codecov](https://codecov.io/gh/apache/beam/pull/12740?src=pr=h1) Report > Merging [#12740](https://codecov.io/gh/apache/beam/pull/12740?src=pr=desc) into

[GitHub] [beam] rohdesamuel commented on pull request #12703: [BEAM-10603] Add describe and cancel to RecordingManager

2020-08-31 Thread GitBox
rohdesamuel commented on pull request #12703: URL: https://github.com/apache/beam/pull/12703#issuecomment-684058731 Run Python PreCommit This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] codecov[bot] edited a comment on pull request #12740: [BEAM-10775] Added nodejs installation and documentation

2020-08-31 Thread GitBox
codecov[bot] edited a comment on pull request #12740: URL: https://github.com/apache/beam/pull/12740#issuecomment-684052125 # [Codecov](https://codecov.io/gh/apache/beam/pull/12740?src=pr=h1) Report > Merging [#12740](https://codecov.io/gh/apache/beam/pull/12740?src=pr=desc) into

[GitHub] [beam] lukecwik commented on pull request #12741: [BEAM-5002] Upgrade SLF4J version to latest 1.7 patch version

2020-08-31 Thread GitBox
lukecwik commented on pull request #12741: URL: https://github.com/apache/beam/pull/12741#issuecomment-684077860 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [beam] codecov[bot] edited a comment on pull request #12740: [BEAM-10775] Added nodejs installation and documentation

2020-08-31 Thread GitBox
codecov[bot] edited a comment on pull request #12740: URL: https://github.com/apache/beam/pull/12740#issuecomment-684052125 # [Codecov](https://codecov.io/gh/apache/beam/pull/12740?src=pr=h1) Report > Merging [#12740](https://codecov.io/gh/apache/beam/pull/12740?src=pr=desc) into

[GitHub] [beam] amaliujia commented on pull request #12735: [BEAM-9543] Add blog post for MATCH_RECOGNIZE

2020-08-31 Thread GitBox
amaliujia commented on pull request #12735: URL: https://github.com/apache/beam/pull/12735#issuecomment-683999553 I guess what the `Whitespace` check is just formatting issue. This is an automated message from the Apache Git

[GitHub] [beam] amaliujia commented on pull request #12735: [BEAM-9543] Add blog post for MATCH_RECOGNIZE

2020-08-31 Thread GitBox
amaliujia commented on pull request #12735: URL: https://github.com/apache/beam/pull/12735#issuecomment-683999317 Run Whitespace PreCommit This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] codecov[bot] edited a comment on pull request #12695: [BEAM-8758] Google-cloud-spanner upgrade to 1.59.0 and google_cloud_bigtable_client_core to 1.16.0

2020-08-31 Thread GitBox
codecov[bot] edited a comment on pull request #12695: URL: https://github.com/apache/beam/pull/12695#issuecomment-682258884 # [Codecov](https://codecov.io/gh/apache/beam/pull/12695?src=pr=h1) Report > :exclamation: No coverage uploaded for pull request base (`master@1019ef3`). [Click

[GitHub] [beam] codecov[bot] edited a comment on pull request #12626: [BEAM-10545] Added the inspector of PCollections and pipelines

2020-08-31 Thread GitBox
codecov[bot] edited a comment on pull request #12626: URL: https://github.com/apache/beam/pull/12626#issuecomment-682133929 # [Codecov](https://codecov.io/gh/apache/beam/pull/12626?src=pr=h1) Report > Merging [#12626](https://codecov.io/gh/apache/beam/pull/12626?src=pr=desc) into

[GitHub] [beam] pabloem commented on pull request #12732: Supporting delimiter for GcsUtil.listObjects

2020-08-31 Thread GitBox
pabloem commented on pull request #12732: URL: https://github.com/apache/beam/pull/12732#issuecomment-684030767 Hi Robin! I am adding functionality here to support extra arguments from https://cloud.google.com/storage/docs/json_api/v1/objects/list - I use this utility for some CDC work,

[GitHub] [beam] KevinGG commented on pull request #12740: [BEAM-10775] Added nodejs installation and documentation

2020-08-31 Thread GitBox
KevinGG commented on pull request #12740: URL: https://github.com/apache/beam/pull/12740#issuecomment-684031306 Run Typescript PreCommit This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] KevinGG commented on pull request #12740: [BEAM-10775] Added nodejs installation and documentation

2020-08-31 Thread GitBox
KevinGG commented on pull request #12740: URL: https://github.com/apache/beam/pull/12740#issuecomment-684037796 Run Typescript PreCommit This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] codecov[bot] edited a comment on pull request #12703: [BEAM-10603] Add describe and cancel to RecordingManager

2020-08-31 Thread GitBox
codecov[bot] edited a comment on pull request #12703: URL: https://github.com/apache/beam/pull/12703#issuecomment-684004590 # [Codecov](https://codecov.io/gh/apache/beam/pull/12703?src=pr=h1) Report > Merging [#12703](https://codecov.io/gh/apache/beam/pull/12703?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12626: [BEAM-10545] Added the inspector of PCollections and pipelines

2020-08-31 Thread GitBox
codecov[bot] edited a comment on pull request #12626: URL: https://github.com/apache/beam/pull/12626#issuecomment-682133929 # [Codecov](https://codecov.io/gh/apache/beam/pull/12626?src=pr=h1) Report > Merging [#12626](https://codecov.io/gh/apache/beam/pull/12626?src=pr=desc) into

[GitHub] [beam] lukecwik opened a new pull request #12742: [BEAM-10843] Fix NPE in websites/build.gradle preventing linkage checker from working since the property isn't defined.

2020-08-31 Thread GitBox
lukecwik opened a new pull request #12742: URL: https://github.com/apache/beam/pull/12742 Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] [**Choose

[GitHub] [beam] codecov[bot] edited a comment on pull request #12727: [BEAM-10844] Add experiment option prebuild_sdk_container to prebuild python sdk container with dependencies.

2020-08-31 Thread GitBox
codecov[bot] edited a comment on pull request #12727: URL: https://github.com/apache/beam/pull/12727#issuecomment-683229966 # [Codecov](https://codecov.io/gh/apache/beam/pull/12727?src=pr=h1) Report > Merging [#12727](https://codecov.io/gh/apache/beam/pull/12727?src=pr=desc) into

[GitHub] [beam] pulasthi commented on pull request #12744: [BEAM-10463] Twister2 Beam Runner Documentation

2020-08-31 Thread GitBox
pulasthi commented on pull request #12744: URL: https://github.com/apache/beam/pull/12744#issuecomment-684155222 @iemejia The documentation as promised (with a little delay). I would need some help with figuring out what to tick on the compatibility matrix, 1. Is there some mapping

[GitHub] [beam] jayendra13 commented on pull request #12738: [BEAM-10615] Eliminate nullability errors from :sdks:java:extensions:sql:jdbc

2020-08-31 Thread GitBox
jayendra13 commented on pull request #12738: URL: https://github.com/apache/beam/pull/12738#issuecomment-684154741 R: @TheNeuralBit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] yifanmai commented on pull request #12655: [BEAM-10779] Support multiple main inputs and side inputs for PTransformOverride

2020-08-31 Thread GitBox
yifanmai commented on pull request #12655: URL: https://github.com/apache/beam/pull/12655#issuecomment-684000921 Run Portable_Python PreCommit This is an automated message from the Apache Git Service. To respond to the

  1   2   3   >