damondouglas commented on pull request #12941:
URL: https://github.com/apache/beam/pull/12941#issuecomment-701483518
The [stepik](https://stepik.org/course/70387) course has been updated with
relevant files committed to this PR. It is ready to merge into master.
codecov[bot] edited a comment on pull request #12969:
URL: https://github.com/apache/beam/pull/12969#issuecomment-701034584
# [Codecov](https://codecov.io/gh/apache/beam/pull/12969?src=pr=h1) Report
> Merging
[#12969](https://codecov.io/gh/apache/beam/pull/12969?src=pr=desc) into
codecov[bot] edited a comment on pull request #12941:
URL: https://github.com/apache/beam/pull/12941#issuecomment-698987193
# [Codecov](https://codecov.io/gh/apache/beam/pull/12941?src=pr=h1) Report
> Merging
[#12941](https://codecov.io/gh/apache/beam/pull/12941?src=pr=desc) into
codecov[bot] commented on pull request #12976:
URL: https://github.com/apache/beam/pull/12976#issuecomment-701505415
# [Codecov](https://codecov.io/gh/apache/beam/pull/12976?src=pr=h1) Report
> Merging
[#12976](https://codecov.io/gh/apache/beam/pull/12976?src=pr=desc) into
codecov[bot] edited a comment on pull request #12941:
URL: https://github.com/apache/beam/pull/12941#issuecomment-698987193
# [Codecov](https://codecov.io/gh/apache/beam/pull/12941?src=pr=h1) Report
> Merging
[#12941](https://codecov.io/gh/apache/beam/pull/12941?src=pr=desc) into
robinyqiu commented on pull request #12966:
URL: https://github.com/apache/beam/pull/12966#issuecomment-701607718
Is this fixing the performance regression mentioned in the other PR? Could
you please create a JIRA for this?
damondouglas commented on a change in pull request #12941:
URL: https://github.com/apache/beam/pull/12941#discussion_r497622720
##
File path: learning/katas/go/io/textio/read/testdata/path.go
##
@@ -0,0 +1,40 @@
+// Licensed to the Apache Software Foundation (ASF) under one or
codecov[bot] edited a comment on pull request #12941:
URL: https://github.com/apache/beam/pull/12941#issuecomment-698987193
# [Codecov](https://codecov.io/gh/apache/beam/pull/12941?src=pr=h1) Report
> Merging
[#12941](https://codecov.io/gh/apache/beam/pull/12941?src=pr=desc) into
TheNeuralBit opened a new pull request #12976:
URL: https://github.com/apache/beam/pull/12976
Cherrypick https://github.com/apache/beam/pull/12969
R: @robinyqiu
Post-Commit Tests Status (on master branch)
boyuanzz commented on pull request #12957:
URL: https://github.com/apache/beam/pull/12957#issuecomment-701548729
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
ibzib commented on pull request #12868:
URL: https://github.com/apache/beam/pull/12868#issuecomment-701548224
I think this PR may have caused an issue where Jenkins can't find the test
report when the task is marked up-to-date. BEAM-10985
robinyqiu merged pull request #12976:
URL: https://github.com/apache/beam/pull/12976
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
codecov[bot] edited a comment on pull request #12977:
URL: https://github.com/apache/beam/pull/12977#issuecomment-701570639
# [Codecov](https://codecov.io/gh/apache/beam/pull/12977?src=pr=h1) Report
> Merging
[#12977](https://codecov.io/gh/apache/beam/pull/12977?src=pr=desc) into
codecov[bot] edited a comment on pull request #12978:
URL: https://github.com/apache/beam/pull/12978#issuecomment-701573827
# [Codecov](https://codecov.io/gh/apache/beam/pull/12978?src=pr=h1) Report
> Merging
[#12978](https://codecov.io/gh/apache/beam/pull/12978?src=pr=desc) into
codecov[bot] edited a comment on pull request #12957:
URL: https://github.com/apache/beam/pull/12957#issuecomment-700276403
# [Codecov](https://codecov.io/gh/apache/beam/pull/12957?src=pr=h1) Report
> Merging
[#12957](https://codecov.io/gh/apache/beam/pull/12957?src=pr=desc) into
damondouglas commented on pull request #12941:
URL: https://github.com/apache/beam/pull/12941#issuecomment-701615012
Run Python PreCommit
This is an automated message from the Apache Git Service.
To respond to the message,
codecov[bot] commented on pull request #12978:
URL: https://github.com/apache/beam/pull/12978#issuecomment-701573827
# [Codecov](https://codecov.io/gh/apache/beam/pull/12978?src=pr=h1) Report
> Merging
[#12978](https://codecov.io/gh/apache/beam/pull/12978?src=pr=desc) into
ibzib merged pull request #12977:
URL: https://github.com/apache/beam/pull/12977
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
codecov[bot] edited a comment on pull request #12976:
URL: https://github.com/apache/beam/pull/12976#issuecomment-701505415
# [Codecov](https://codecov.io/gh/apache/beam/pull/12976?src=pr=h1) Report
> Merging
[#12976](https://codecov.io/gh/apache/beam/pull/12976?src=pr=desc) into
runningcode commented on pull request #12974:
URL: https://github.com/apache/beam/pull/12974#issuecomment-701507957
Wrong module!
This is an automated message from the Apache Git Service.
To respond to the message, please
pabloem merged pull request #12966:
URL: https://github.com/apache/beam/pull/12966
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
kennknowles opened a new pull request #12978:
URL: https://github.com/apache/beam/pull/12978
I came across this while trying to launch the local job service for running
Java ValidatesRunner against ULR.
Thank you for your contribution! Follow this
dpcollins-google commented on a change in pull request #12957:
URL: https://github.com/apache/beam/pull/12957#discussion_r497739796
##
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsublite/TranslatingPullSubscriber.java
##
@@ -17,12
codecov[bot] edited a comment on pull request #12957:
URL: https://github.com/apache/beam/pull/12957#issuecomment-700276403
# [Codecov](https://codecov.io/gh/apache/beam/pull/12957?src=pr=h1) Report
> Merging
[#12957](https://codecov.io/gh/apache/beam/pull/12957?src=pr=desc) into
codecov[bot] edited a comment on pull request #12957:
URL: https://github.com/apache/beam/pull/12957#issuecomment-700276403
# [Codecov](https://codecov.io/gh/apache/beam/pull/12957?src=pr=h1) Report
> Merging
[#12957](https://codecov.io/gh/apache/beam/pull/12957?src=pr=desc) into
robertwb commented on pull request #12819:
URL: https://github.com/apache/beam/pull/12819#issuecomment-701611934
Run Python PreCommit
This is an automated message from the Apache Git Service.
To respond to the message,
boyuanzz merged pull request #12965:
URL: https://github.com/apache/beam/pull/12965
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
runningcode commented on pull request #12969:
URL: https://github.com/apache/beam/pull/12969#issuecomment-701490134
Ah, in that case perhaps in the new versions of the plugin the `build` task
doens't depend any more on the `shadowJar` task.
To fix this, we can add the following:
```
codecov[bot] edited a comment on pull request #12941:
URL: https://github.com/apache/beam/pull/12941#issuecomment-698987193
# [Codecov](https://codecov.io/gh/apache/beam/pull/12941?src=pr=h1) Report
> Merging
[#12941](https://codecov.io/gh/apache/beam/pull/12941?src=pr=desc) into
kennknowles commented on a change in pull request #6707:
URL: https://github.com/apache/beam/pull/6707#discussion_r497728357
##
File path:
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
##
@@ -1492,5 +1492,79 @@ artifactId=${project.name}
udim commented on a change in pull request #6707:
URL: https://github.com/apache/beam/pull/6707#discussion_r497754511
##
File path:
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
##
@@ -1492,5 +1492,79 @@ artifactId=${project.name}
dependsOn
TheNeuralBit commented on pull request #12969:
URL: https://github.com/apache/beam/pull/12969#issuecomment-701495344
I think we should just rollback for now to get the 2.25.0 branch unblocked.
Let's talk about options for upgrading back to 5.x in BEAM-10986
codecov[bot] edited a comment on pull request #12941:
URL: https://github.com/apache/beam/pull/12941#issuecomment-698987193
# [Codecov](https://codecov.io/gh/apache/beam/pull/12941?src=pr=h1) Report
> Merging
[#12941](https://codecov.io/gh/apache/beam/pull/12941?src=pr=desc) into
runningcode closed pull request #12974:
URL: https://github.com/apache/beam/pull/12974
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
codecov[bot] edited a comment on pull request #12976:
URL: https://github.com/apache/beam/pull/12976#issuecomment-701505415
# [Codecov](https://codecov.io/gh/apache/beam/pull/12976?src=pr=h1) Report
> Merging
[#12976](https://codecov.io/gh/apache/beam/pull/12976?src=pr=desc) into
codecov[bot] commented on pull request #12977:
URL: https://github.com/apache/beam/pull/12977#issuecomment-701570639
# [Codecov](https://codecov.io/gh/apache/beam/pull/12977?src=pr=h1) Report
> Merging
[#12977](https://codecov.io/gh/apache/beam/pull/12977?src=pr=desc) into
pabloem commented on pull request #12966:
URL: https://github.com/apache/beam/pull/12966#issuecomment-701578317
oops my bad, not @youngoli but @robinyqiu
This is an automated message from the Apache Git Service.
To respond
boyuanzz commented on a change in pull request #12957:
URL: https://github.com/apache/beam/pull/12957#discussion_r497752546
##
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsublite/TranslatingPullSubscriber.java
##
@@ -23,6 +23,10
codecov[bot] edited a comment on pull request #12819:
URL: https://github.com/apache/beam/pull/12819#issuecomment-691336298
# [Codecov](https://codecov.io/gh/apache/beam/pull/12819?src=pr=h1) Report
> Merging
[#12819](https://codecov.io/gh/apache/beam/pull/12819?src=pr=desc) into
runningcode removed a comment on pull request #12969:
URL: https://github.com/apache/beam/pull/12969#issuecomment-701481384
Ah, that is confusing. In that case it looks like the apache beam module
plugin is not applied to that module. `plugins { id 'org.apache.beam.module' }`
Which
codecov[bot] edited a comment on pull request #12976:
URL: https://github.com/apache/beam/pull/12976#issuecomment-701505415
# [Codecov](https://codecov.io/gh/apache/beam/pull/12976?src=pr=h1) Report
> Merging
[#12976](https://codecov.io/gh/apache/beam/pull/12976?src=pr=desc) into
y1chi commented on pull request #12956:
URL: https://github.com/apache/beam/pull/12956#issuecomment-701525965
@pabloem do you mind help merge this?
This is an automated message from the Apache Git Service.
To respond to the
pabloem commented on pull request #12966:
URL: https://github.com/apache/beam/pull/12966#issuecomment-701544509
FYI @youngoli I am a little concerned that this may be a issue that we
should cherrypick for 2.25
This is
ibzib opened a new pull request #12977:
URL: https://github.com/apache/beam/pull/12977
This reverts commit 093bea6407f8879d5c9bd8e55b4c833718e956c9.
R: @udim
cc: @runningcode @mxm
Thank you for your contribution! Follow this checklist to
boyuanzz commented on a change in pull request #12957:
URL: https://github.com/apache/beam/pull/12957#discussion_r497706527
##
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsublite/TranslatingPullSubscriber.java
##
@@ -17,12 +17,28
codecov[bot] edited a comment on pull request #12977:
URL: https://github.com/apache/beam/pull/12977#issuecomment-701570639
# [Codecov](https://codecov.io/gh/apache/beam/pull/12977?src=pr=h1) Report
> Merging
[#12977](https://codecov.io/gh/apache/beam/pull/12977?src=pr=desc) into
codecov[bot] edited a comment on pull request #12957:
URL: https://github.com/apache/beam/pull/12957#issuecomment-700276403
# [Codecov](https://codecov.io/gh/apache/beam/pull/12957?src=pr=h1) Report
> Merging
[#12957](https://codecov.io/gh/apache/beam/pull/12957?src=pr=desc) into
kileys commented on pull request #12946:
URL: https://github.com/apache/beam/pull/12946#issuecomment-701613094
Discarding the change since this is to test Java 11 users can use Beam that
was built with Java 8
This is an
kileys closed pull request #12946:
URL: https://github.com/apache/beam/pull/12946
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
kennknowles commented on pull request #12978:
URL: https://github.com/apache/beam/pull/12978#issuecomment-701613240
Looks like https://issues.apache.org/jira/browse/BEAM-10968 for Java
precommit
This is an automated message
codecov[bot] edited a comment on pull request #12941:
URL: https://github.com/apache/beam/pull/12941#issuecomment-698987193
# [Codecov](https://codecov.io/gh/apache/beam/pull/12941?src=pr=h1) Report
> Merging
[#12941](https://codecov.io/gh/apache/beam/pull/12941?src=pr=desc) into
runningcode commented on pull request #12969:
URL: https://github.com/apache/beam/pull/12969#issuecomment-701481384
Ah, that is confusing. In that case it looks like the apache beam module
plugin is not applied to that module. `plugins { id 'org.apache.beam.module' }`
Which means, I
TheNeuralBit merged pull request #12969:
URL: https://github.com/apache/beam/pull/12969
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
tysonjh commented on a change in pull request #12915:
URL: https://github.com/apache/beam/pull/12915#discussion_r497696164
##
File path:
sdks/java/extensions/join-library/src/main/java/org/apache/beam/sdk/extensions/joinlibrary/Join.java
##
@@ -350,6 +368,276 @@ public void
codecov[bot] edited a comment on pull request #12978:
URL: https://github.com/apache/beam/pull/12978#issuecomment-701573827
# [Codecov](https://codecov.io/gh/apache/beam/pull/12978?src=pr=h1) Report
> Merging
[#12978](https://codecov.io/gh/apache/beam/pull/12978?src=pr=desc) into
codecov[bot] edited a comment on pull request #12957:
URL: https://github.com/apache/beam/pull/12957#issuecomment-700276403
# [Codecov](https://codecov.io/gh/apache/beam/pull/12957?src=pr=h1) Report
> Merging
[#12957](https://codecov.io/gh/apache/beam/pull/12957?src=pr=desc) into
kennknowles merged pull request #12978:
URL: https://github.com/apache/beam/pull/12978
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
codecov[bot] edited a comment on pull request #12819:
URL: https://github.com/apache/beam/pull/12819#issuecomment-691336298
# [Codecov](https://codecov.io/gh/apache/beam/pull/12819?src=pr=h1) Report
> Merging
[#12819](https://codecov.io/gh/apache/beam/pull/12819?src=pr=desc) into
yichuan66 edited a comment on pull request #12987:
URL: https://github.com/apache/beam/pull/12987#issuecomment-701893996
@TheNeuralBit I'm new and not sure who to look. Can you please take a look?
Thanks!
This is an
yichuan66 commented on pull request #12987:
URL: https://github.com/apache/beam/pull/12987#issuecomment-701893996
@TheNeuralBit
This is an automated message from the Apache Git Service.
To respond to the message, please log
yichuan66 opened a new pull request #12987:
URL: https://github.com/apache/beam/pull/12987
Fixed a small typo. Getting familiar with Beam contribution routine.
Thank you for your contribution! Follow this checklist to help us
incorporate your
yichuan66 edited a comment on pull request #12987:
URL: https://github.com/apache/beam/pull/12987#issuecomment-701893996
@TheNeuralBit I'm new and not sure who to look for. Can you please take a
look? Thanks!
This is an
codecov[bot] edited a comment on pull request #12975:
URL: https://github.com/apache/beam/pull/12975#issuecomment-701452806
# [Codecov](https://codecov.io/gh/apache/beam/pull/12975?src=pr=h1) Report
> Merging
[#12975](https://codecov.io/gh/apache/beam/pull/12975?src=pr=desc) into
codecov[bot] commented on pull request #12975:
URL: https://github.com/apache/beam/pull/12975#issuecomment-701452806
# [Codecov](https://codecov.io/gh/apache/beam/pull/12975?src=pr=h1) Report
> Merging
[#12975](https://codecov.io/gh/apache/beam/pull/12975?src=pr=desc) into
codecov[bot] edited a comment on pull request #12975:
URL: https://github.com/apache/beam/pull/12975#issuecomment-701452806
# [Codecov](https://codecov.io/gh/apache/beam/pull/12975?src=pr=h1) Report
> Merging
[#12975](https://codecov.io/gh/apache/beam/pull/12975?src=pr=desc) into
codecov[bot] edited a comment on pull request #12975:
URL: https://github.com/apache/beam/pull/12975#issuecomment-701452806
# [Codecov](https://codecov.io/gh/apache/beam/pull/12975?src=pr=h1) Report
> Merging
[#12975](https://codecov.io/gh/apache/beam/pull/12975?src=pr=desc) into
codecov[bot] edited a comment on pull request #12975:
URL: https://github.com/apache/beam/pull/12975#issuecomment-701452806
# [Codecov](https://codecov.io/gh/apache/beam/pull/12975?src=pr=h1) Report
> Merging
[#12975](https://codecov.io/gh/apache/beam/pull/12975?src=pr=desc) into
TheNeuralBit commented on pull request #12969:
URL: https://github.com/apache/beam/pull/12969#issuecomment-701462306
BEAM-10986 is (confusingly) about
[io/expansion-service/build.gradle](https://github.com/apache/beam/blob/master/sdks/java/io/expansion-service/build.gradle#L27)
TheNeuralBit commented on pull request #12969:
URL: https://github.com/apache/beam/pull/12969#issuecomment-701462683
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message,
codecov[bot] edited a comment on pull request #12975:
URL: https://github.com/apache/beam/pull/12975#issuecomment-701452806
# [Codecov](https://codecov.io/gh/apache/beam/pull/12975?src=pr=h1) Report
> Merging
[#12975](https://codecov.io/gh/apache/beam/pull/12975?src=pr=desc) into
codecov[bot] edited a comment on pull request #12975:
URL: https://github.com/apache/beam/pull/12975#issuecomment-701452806
# [Codecov](https://codecov.io/gh/apache/beam/pull/12975?src=pr=h1) Report
> Merging
[#12975](https://codecov.io/gh/apache/beam/pull/12975?src=pr=desc) into
mxm merged pull request #12576:
URL: https://github.com/apache/beam/pull/12576
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
codecov[bot] edited a comment on pull request #12964:
URL: https://github.com/apache/beam/pull/12964#issuecomment-701370267
# [Codecov](https://codecov.io/gh/apache/beam/pull/12964?src=pr=h1) Report
> Merging
[#12964](https://codecov.io/gh/apache/beam/pull/12964?src=pr=desc) into
kamilwu commented on pull request #12966:
URL: https://github.com/apache/beam/pull/12966#issuecomment-701414837
Run BigQueryIO Read Performance Test Python
This is an automated message from the Apache Git Service.
To respond
piotr-szuberski commented on pull request #12975:
URL: https://github.com/apache/beam/pull/12975#issuecomment-701440595
Run Python PreCommit
This is an automated message from the Apache Git Service.
To respond to the
codecov[bot] edited a comment on pull request #12964:
URL: https://github.com/apache/beam/pull/12964#issuecomment-701370267
# [Codecov](https://codecov.io/gh/apache/beam/pull/12964?src=pr=h1) Report
> Merging
[#12964](https://codecov.io/gh/apache/beam/pull/12964?src=pr=desc) into
101 - 176 of 176 matches
Mail list logo