Re: [I] adding extra_header causing issue while reading GCS file in colab [beam]

2024-04-02 Thread via GitHub
minhajpasha commented on issue #30416: URL: https://github.com/apache/beam/issues/30416#issuecomment-2031512233 @ajitsonawane1 - Google recommendation :We'd recommend that you install v2.16.0 (the latest version) of the google-cloud-storage to resolve this issue. It worked for me --

Re: [PR] Add SpannerIO Stress test [beam]

2024-04-02 Thread via GitHub
akashorabek commented on PR #30800: URL: https://github.com/apache/beam/pull/30800#issuecomment-2031360719 > Looks like it has only 100-50 MB/s even for 20 workers, > > and there are errors in log: > > ``` > DEADLINE_EXCEEDED writing batch of 25 mutations to Cloud Spanner,

Re: [PR] Docker - Remove Deprecated Types [beam]

2024-04-02 Thread via GitHub
github-actions[bot] commented on PR #30826: URL: https://github.com/apache/beam/pull/30826#issuecomment-2031714010 Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`: R: @riteshghorse for label go. Available commands: - `stop

Re: [PR] add channel cache [beam]

2024-04-02 Thread via GitHub
m-trieu commented on PR #30765: URL: https://github.com/apache/beam/pull/30765#issuecomment-2031323700 @Abacn was able to get the test to pass, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[PR] Docker - Remove Deprecated Types [beam]

2024-04-02 Thread via GitHub
evan-burrell opened a new pull request, #30826: URL: https://github.com/apache/beam/pull/30826 When upgrading to 2.55, the Docker deprecated types in Docker - `github.com/docker/docker v26.0.0`, have been removed. Migrate them to the new types. [Docker Go

Re: [PR] [Java] ManagedIO [beam]

2024-04-02 Thread via GitHub
ahmedabu98 commented on code in PR #30808: URL: https://github.com/apache/beam/pull/30808#discussion_r1548031412 ## sdks/java/managed/src/main/java/org/apache/beam/sdk/managed/Managed.java: ## @@ -0,0 +1,160 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] [Java] ManagedIO [beam]

2024-04-02 Thread via GitHub
ahmedabu98 commented on code in PR #30808: URL: https://github.com/apache/beam/pull/30808#discussion_r1548031412 ## sdks/java/managed/src/main/java/org/apache/beam/sdk/managed/Managed.java: ## @@ -0,0 +1,160 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] add channel cache [beam]

2024-04-02 Thread via GitHub
Abacn commented on PR #30765: URL: https://github.com/apache/beam/pull/30765#issuecomment-2032128361 @m-trieu if you download "JUnit Test Results" in https://github.com/apache/beam/actions/runs/8519333281?pr=30765, and check runners/google-cloud-dataflow-java/, it is missing worker/ folder

Re: [PR] Duet ai code prompts for gcloud services [beam]

2024-04-02 Thread via GitHub
damccorm merged PR #30749: URL: https://github.com/apache/beam/pull/30749 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Duet AI code prompts final [beam]

2024-04-02 Thread via GitHub
damccorm commented on PR #30785: URL: https://github.com/apache/beam/pull/30785#issuecomment-2032274065 Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Include everit_json_schema in schemaio expansion service uber jar (#30779) [beam]

2024-04-02 Thread via GitHub
damccorm merged PR #30823: URL: https://github.com/apache/beam/pull/30823 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [Java] ManagedIO [beam]

2024-04-02 Thread via GitHub
robertwb commented on code in PR #30808: URL: https://github.com/apache/beam/pull/30808#discussion_r1548103214 ## sdks/java/managed/src/main/java/org/apache/beam/sdk/managed/Managed.java: ## @@ -0,0 +1,160 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

Re: [PR] Add WaitOn transform to Python, analogous to Java's Wait.on. [beam]

2024-04-02 Thread via GitHub
robertwb merged PR #30807: URL: https://github.com/apache/beam/pull/30807 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Update dataflow containers on release branch [beam]

2024-04-02 Thread via GitHub
github-actions[bot] commented on PR #30827: URL: https://github.com/apache/beam/pull/30827#issuecomment-2032551628 Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control -- This is an automated message from the Apache Git

Re: [PR] Update dataflow containers on release branch [beam]

2024-04-02 Thread via GitHub
Abacn commented on PR #30827: URL: https://github.com/apache/beam/pull/30827#issuecomment-2032572504 and there is python container also? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Add identity function as default to FlatMap [beam]

2024-04-02 Thread via GitHub
tvalentyn commented on PR #30744: URL: https://github.com/apache/beam/pull/30744#issuecomment-2032585563 Looks like lint is still failing, PTAL and feel free to ping when it's ready to merge. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] [Java] ManagedIO [beam]

2024-04-02 Thread via GitHub
ahmedabu98 commented on code in PR #30808: URL: https://github.com/apache/beam/pull/30808#discussion_r1548048553 ## sdks/java/managed/src/main/java/org/apache/beam/sdk/managed/Managed.java: ## @@ -0,0 +1,160 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] [Java] ManagedIO [beam]

2024-04-02 Thread via GitHub
ahmedabu98 commented on code in PR #30808: URL: https://github.com/apache/beam/pull/30808#discussion_r1548051734 ## sdks/java/managed/src/main/java/org/apache/beam/sdk/managed/Managed.java: ## @@ -0,0 +1,160 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] [Java] ManagedIO [beam]

2024-04-02 Thread via GitHub
robertwb commented on code in PR #30808: URL: https://github.com/apache/beam/pull/30808#discussion_r1548099563 ## sdks/java/managed/src/main/java/org/apache/beam/sdk/managed/Managed.java: ## @@ -0,0 +1,160 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

Re: [I] [Feature Request]: Support for Apache Flink 1.18 in Beam Runners [beam]

2024-04-02 Thread via GitHub
danielmfinn commented on issue #30789: URL: https://github.com/apache/beam/issues/30789#issuecomment-2032408828 +1. Would help support of Java 17. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [I] [Feature Request]: Support for Apache Flink 1.18 in Beam Runners [beam]

2024-04-02 Thread via GitHub
aniinbkln commented on issue #30789: URL: https://github.com/apache/beam/issues/30789#issuecomment-2032443059 +1 for this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Export gcs options [beam]

2024-04-02 Thread via GitHub
github-actions[bot] commented on PR #30772: URL: https://github.com/apache/beam/pull/30772#issuecomment-2032521498 Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`: R: @bvolpato for label java. Available commands: - `stop

[PR] Update dataflow containers on release branch [beam]

2024-04-02 Thread via GitHub
damccorm opened a new pull request, #30827: URL: https://github.com/apache/beam/pull/30827 Will probably need to go to rc2 because I forgot to do this before generating rc1 Thank you for your contribution! Follow this checklist to help us incorporate

Re: [PR] Update dataflow containers on release branch [beam]

2024-04-02 Thread via GitHub
damccorm commented on PR #30827: URL: https://github.com/apache/beam/pull/30827#issuecomment-2032549535 R: @Abacn -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [Java] ManagedIO [beam]

2024-04-02 Thread via GitHub
ahmedabu98 commented on code in PR #30808: URL: https://github.com/apache/beam/pull/30808#discussion_r1548051734 ## sdks/java/managed/src/main/java/org/apache/beam/sdk/managed/Managed.java: ## @@ -0,0 +1,160 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Duet AI code prompts final [beam]

2024-04-02 Thread via GitHub
damccorm merged PR #30785: URL: https://github.com/apache/beam/pull/30785 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [Java] ManagedIO [beam]

2024-04-02 Thread via GitHub
robertwb commented on code in PR #30808: URL: https://github.com/apache/beam/pull/30808#discussion_r1548098968 ## sdks/java/managed/src/main/java/org/apache/beam/sdk/managed/Managed.java: ## @@ -0,0 +1,160 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

Re: [PR] Add SpannerIO Stress test [beam]

2024-04-02 Thread via GitHub
Abacn merged PR #30800: URL: https://github.com/apache/beam/pull/30800 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Export gcs options [beam]

2024-04-02 Thread via GitHub
Naireen commented on PR #30772: URL: https://github.com/apache/beam/pull/30772#issuecomment-2032518589 assign set of reviewers -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Update dataflow containers on release branch [beam]

2024-04-02 Thread via GitHub
damccorm commented on PR #30827: URL: https://github.com/apache/beam/pull/30827#issuecomment-2032578938 That one gets auto-updated when we tag the RC -

Re: [PR] Duet ai code prompts for gcloud services [beam]

2024-04-02 Thread via GitHub
dariabezkorovaina commented on code in PR #30749: URL: https://github.com/apache/beam/pull/30749#discussion_r1542030855 ## learning/prompts/code-generation/java/03_io_bigquery.md: ## @@ -0,0 +1,96 @@ +Prompt: +Write a sample Java code snippet that writes data to a Google

[PR] Elasticsearch enable Point In Time based searches [beam]

2024-04-02 Thread via GitHub
prodriguezdefino opened a new pull request, #30824: URL: https://github.com/apache/beam/pull/30824 This change adds a BoundedReader implementation based on the newer Point In Time search API (see

Re: [PR] Add direct path code path [beam]

2024-04-02 Thread via GitHub
m-trieu commented on PR #30764: URL: https://github.com/apache/beam/pull/30764#issuecomment-2031242823 @scwhittle still wrapping up the unit tests, just would like an initial pass thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log

[PR] Add /job/cancel endpoint to prism web server. [beam]

2024-04-02 Thread via GitHub
damondouglas opened a new pull request, #30825: URL: https://github.com/apache/beam/pull/30825 This PR addresses #30810 adding a /job/cancel endpoint to the prism web server. This endpoint will receive calls from the UI's cancel action (#30811). Thank

Re: [PR] Duet ai code prompts for gcloud services [beam]

2024-04-02 Thread via GitHub
dariabezkorovaina commented on code in PR #30749: URL: https://github.com/apache/beam/pull/30749#discussion_r1542034794 ## learning/prompts/code-generation/java/04_io_bigtable.md: ## @@ -0,0 +1,132 @@ +Prompt: +Write a sample Java code snippet that writes data to a Google

Re: [PR] Duet ai code prompts for gcloud services [beam]

2024-04-02 Thread via GitHub
dariabezkorovaina commented on code in PR #30749: URL: https://github.com/apache/beam/pull/30749#discussion_r1542045126 ## learning/prompts/code-generation/java/05_io_spanner.md: ## @@ -0,0 +1,113 @@ +Prompt: +Write a sample Java code snippet that writes data to a Google

Re: [PR] [Java] ManagedIO [beam]

2024-04-02 Thread via GitHub
chamikaramj commented on code in PR #30808: URL: https://github.com/apache/beam/pull/30808#discussion_r1548287322 ## sdks/java/managed/src/main/java/org/apache/beam/sdk/managed/Managed.java: ## @@ -0,0 +1,160 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [I] Performance Regression or Improvement: test_cloudml_benchmark_cirteo_no_shuffle_10GB-runtime_sec:runtime_sec [beam]

2024-04-02 Thread via GitHub
damccorm closed issue #30726: Performance Regression or Improvement: test_cloudml_benchmark_cirteo_no_shuffle_10GB-runtime_sec:runtime_sec URL: https://github.com/apache/beam/issues/30726 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [I] Performance Regression or Improvement: cogbk_python_batch_load_test_reiterate_4times_10KB_values:runtime [beam]

2024-04-02 Thread via GitHub
damccorm closed issue #30682: Performance Regression or Improvement: cogbk_python_batch_load_test_reiterate_4times_10KB_values:runtime URL: https://github.com/apache/beam/issues/30682 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [I] Performance Regression or Improvement: gbk_python_batch_load_test_fanout_8_times_with_2GB_10byte_records_total:runtime [beam]

2024-04-02 Thread via GitHub
damccorm closed issue #30814: Performance Regression or Improvement: gbk_python_batch_load_test_fanout_8_times_with_2GB_10byte_records_total:runtime URL: https://github.com/apache/beam/issues/30814 -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [I] Performance Regression or Improvement: sideinpts_python_batch_1gb_1kb_10workers_1000window_1key_percent_dict:runtime [beam]

2024-04-02 Thread via GitHub
damccorm closed issue #30711: Performance Regression or Improvement: sideinpts_python_batch_1gb_1kb_10workers_1000window_1key_percent_dict:runtime URL: https://github.com/apache/beam/issues/30711 -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [I] Performance Regression or Improvement: sideinpts_python_batch_1gb_1kb_10workers_1000window_99key_percent_dict:runtime [beam]

2024-04-02 Thread via GitHub
damccorm closed issue #30697: Performance Regression or Improvement: sideinpts_python_batch_1gb_1kb_10workers_1000window_99key_percent_dict:runtime URL: https://github.com/apache/beam/issues/30697 -- This is an automated message from the Apache Git Service. To respond to the message,

[I] [Failing Test]: JS2PY not supporting Python 3.12 [beam]

2024-04-02 Thread via GitHub
tvalentyn opened a new issue, #30829: URL: https://github.com/apache/beam/issues/30829 ### What happened? Beam YAML added added a dependency on js2py library:

Re: [PR] Add cancel button to Prism UI [beam]

2024-04-02 Thread via GitHub
jrmccluskey commented on code in PR #30811: URL: https://github.com/apache/beam/pull/30811#discussion_r1548426206 ## sdks/go/pkg/beam/runners/prism/internal/web/assets/job-action.js: ## @@ -0,0 +1,97 @@ +/** + Licensed under the Apache License, Version 2.0 (the "License"); +

Re: [PR] [Java] ManagedIO [beam]

2024-04-02 Thread via GitHub
ahmedabu98 commented on code in PR #30808: URL: https://github.com/apache/beam/pull/30808#discussion_r1548488911 ## sdks/java/managed/src/main/java/org/apache/beam/sdk/managed/Managed.java: ## @@ -0,0 +1,160 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Bump github.com/docker/docker from 25.0.5+incompatible to 26.0.0+incompatible in /sdks [beam]

2024-04-02 Thread via GitHub
jrmccluskey commented on PR #30763: URL: https://github.com/apache/beam/pull/30763#issuecomment-2032973290 dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [I] Performance Regression or Improvement: test_cloudml_benchmark_criteo_10GB-runtime_sec:runtime_sec [beam]

2024-04-02 Thread via GitHub
damccorm closed issue #30710: Performance Regression or Improvement: test_cloudml_benchmark_criteo_10GB-runtime_sec:runtime_sec URL: https://github.com/apache/beam/issues/30710 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [I] Performance Regression or Improvement: cogbk_python_batch_load_test_reiterate_4times_2MB_values:runtime [beam]

2024-04-02 Thread via GitHub
damccorm closed issue #30722: Performance Regression or Improvement: cogbk_python_batch_load_test_reiterate_4times_2MB_values:runtime URL: https://github.com/apache/beam/issues/30722 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] Update dataflow containers on release branch [beam]

2024-04-02 Thread via GitHub
damccorm merged PR #30827: URL: https://github.com/apache/beam/pull/30827 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [Java] ManagedIO [beam]

2024-04-02 Thread via GitHub
chamikaramj commented on code in PR #30808: URL: https://github.com/apache/beam/pull/30808#discussion_r1548328971 ## sdks/java/managed/src/main/java/org/apache/beam/sdk/managed/Managed.java: ## @@ -0,0 +1,160 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] add channel cache [beam]

2024-04-02 Thread via GitHub
m-trieu commented on PR #30765: URL: https://github.com/apache/beam/pull/30765#issuecomment-2032707203 > @m-trieu if you download "JUnit Test Results" in https://github.com/apache/beam/actions/runs/8519333281?pr=30765, and check runners/google-cloud-dataflow-java/, it is missing worker/

Re: [PR] [Java] ManagedIO [beam]

2024-04-02 Thread via GitHub
chamikaramj commented on code in PR #30808: URL: https://github.com/apache/beam/pull/30808#discussion_r1548330330 ## sdks/java/managed/src/main/java/org/apache/beam/sdk/managed/Managed.java: ## @@ -0,0 +1,160 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] [Java] ManagedIO [beam]

2024-04-02 Thread via GitHub
github-actions[bot] commented on PR #30808: URL: https://github.com/apache/beam/pull/30808#issuecomment-2032957731 Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment `assign set of reviewers` -- This is an automated

Re: [PR] Bump github.com/tetratelabs/wazero from 1.6.0 to 1.7.0 in /sdks [beam]

2024-04-02 Thread via GitHub
codecov-commenter commented on PR #30731: URL: https://github.com/apache/beam/pull/30731#issuecomment-2032960449 ## [Codecov](https://app.codecov.io/gh/apache/beam/pull/30731?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report

[PR] Add Python 3.12 support [beam]

2024-04-02 Thread via GitHub
tvalentyn opened a new pull request, #30828: URL: https://github.com/apache/beam/pull/30828 **Please** add a meaningful description for your change here Thank you for your contribution! Follow this checklist to help us incorporate your contribution

Re: [PR] [Java] ManagedIO [beam]

2024-04-02 Thread via GitHub
robertwb commented on code in PR #30808: URL: https://github.com/apache/beam/pull/30808#discussion_r1548319363 ## sdks/java/managed/src/main/java/org/apache/beam/sdk/managed/Managed.java: ## @@ -0,0 +1,160 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

Re: [PR] add channel cache [beam]

2024-04-02 Thread via GitHub
Abacn merged PR #30765: URL: https://github.com/apache/beam/pull/30765 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Add /job/cancel endpoint to prism web server. [beam]

2024-04-02 Thread via GitHub
codecov-commenter commented on PR #30825: URL: https://github.com/apache/beam/pull/30825#issuecomment-2032793616 ## [Codecov](https://app.codecov.io/gh/apache/beam/pull/30825?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report

Re: [PR] Bump github.com/tetratelabs/wazero from 1.6.0 to 1.7.0 in /sdks [beam]

2024-04-02 Thread via GitHub
github-actions[bot] commented on PR #30731: URL: https://github.com/apache/beam/pull/30731#issuecomment-2032958054 Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`: R: @jrmccluskey for label go. Available commands: - `stop

Re: [PR] Bump github.com/tetratelabs/wazero from 1.6.0 to 1.7.0 in /sdks [beam]

2024-04-02 Thread via GitHub
jrmccluskey merged PR #30731: URL: https://github.com/apache/beam/pull/30731 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Protect 2.55.1 branch [beam]

2024-04-02 Thread via GitHub
github-actions[bot] commented on PR #30832: URL: https://github.com/apache/beam/pull/30832#issuecomment-2033012156 Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control -- This is an automated message from the Apache Git

Re: [PR] Add /job/cancel endpoint to prism web server. [beam]

2024-04-02 Thread via GitHub
github-actions[bot] commented on PR #30825: URL: https://github.com/apache/beam/pull/30825#issuecomment-2033184481 Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`: R: @lostluck for label go. Available commands: - `stop

Re: [PR] Add back Avro 1.8.2 to test [beam]

2024-04-02 Thread via GitHub
github-actions[bot] commented on PR #30833: URL: https://github.com/apache/beam/pull/30833#issuecomment-2033184382 Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`: R: @robertwb for label java. Available commands: - `stop

Re: [PR] Elasticsearch enable Point In Time based searches [beam]

2024-04-02 Thread via GitHub
prodriguezdefino commented on PR #30824: URL: https://github.com/apache/beam/pull/30824#issuecomment-2033191290 Run Java_ElasticSearch_IO_Direct PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] [Python] Add a couple quality-of-life improvemenets to `testing.util.assert_that` [beam]

2024-04-02 Thread via GitHub
hjtran commented on PR #30771: URL: https://github.com/apache/beam/pull/30771#issuecomment-2032996182 Bump @liferoad whenever you have a moment -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[I] [Task]: Read using JDBCIO in Python does not return helpful error message if a coder was not registered [beam]

2024-04-02 Thread via GitHub
andreigurau opened a new issue, #30831: URL: https://github.com/apache/beam/issues/30831 ### What needs to happen? Attempting to use ReadFromJdbc without [registering a

[PR] Protect 2.55.1 branch [beam]

2024-04-02 Thread via GitHub
damccorm opened a new pull request, #30832: URL: https://github.com/apache/beam/pull/30832 Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Mention the appropriate issue

Re: [PR] Protect 2.55.1 branch [beam]

2024-04-02 Thread via GitHub
damccorm commented on PR #30832: URL: https://github.com/apache/beam/pull/30832#issuecomment-2033010651 R: @Abacn -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[PR] Add back Avro 1.8.2 to test [beam]

2024-04-02 Thread via GitHub
Abacn opened a new pull request, #30833: URL: https://github.com/apache/beam/pull/30833 After #30638, Beam repo tests no longer exercises with avro 1.8.2. We should add it back as the support for old avro hasn't discontinued yet. **Please** add a meaningful description for your

Re: [PR] [Python] Add a couple quality-of-life improvemenets to `testing.util.assert_that` [beam]

2024-04-02 Thread via GitHub
liferoad commented on code in PR #30771: URL: https://github.com/apache/beam/pull/30771#discussion_r1548608617 ## sdks/python/apache_beam/examples/snippets/transforms/aggregation/groupby_test.py: ## @@ -226,7 +230,7 @@ def check_global_aggregate_result(grouped): grouped

Re: [PR] [Python] Add a couple quality-of-life improvemenets to `testing.util.assert_that` [beam]

2024-04-02 Thread via GitHub
liferoad commented on code in PR #30771: URL: https://github.com/apache/beam/pull/30771#discussion_r1548607544 ## sdks/python/apache_beam/examples/snippets/transforms/aggregation/groupby_test.py: ## @@ -38,6 +38,10 @@ from .groupby_simple_aggregate import simple_aggregate

Re: [PR] [Python] Add a couple quality-of-life improvemenets to `testing.util.assert_that` [beam]

2024-04-02 Thread via GitHub
hjtran commented on code in PR #30771: URL: https://github.com/apache/beam/pull/30771#discussion_r1548610226 ## sdks/python/apache_beam/examples/snippets/transforms/aggregation/groupby_test.py: ## @@ -226,7 +230,7 @@ def check_global_aggregate_result(grouped): grouped |

Re: [PR] [Python] Add a couple quality-of-life improvemenets to `testing.util.assert_that` [beam]

2024-04-02 Thread via GitHub
hjtran commented on code in PR #30771: URL: https://github.com/apache/beam/pull/30771#discussion_r1548609730 ## sdks/python/apache_beam/examples/snippets/transforms/aggregation/groupby_test.py: ## @@ -38,6 +38,10 @@ from .groupby_simple_aggregate import simple_aggregate from

Re: [PR] Protect 2.55.1 branch [beam]

2024-04-02 Thread via GitHub
damccorm merged PR #30832: URL: https://github.com/apache/beam/pull/30832 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Add cancel button to Prism UI [beam]

2024-04-02 Thread via GitHub
jrmccluskey merged PR #30811: URL: https://github.com/apache/beam/pull/30811 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] [prism]: Add cancel button to Prism UI [beam]

2024-04-02 Thread via GitHub
jrmccluskey closed issue #30810: [prism]: Add cancel button to Prism UI URL: https://github.com/apache/beam/issues/30810 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Add back Avro 1.8.2 to test [beam]

2024-04-02 Thread via GitHub
Abacn commented on code in PR #30833: URL: https://github.com/apache/beam/pull/30833#discussion_r1548592709 ## sdks/java/extensions/avro/build.gradle: ## @@ -35,10 +35,11 @@ avro { description = "Apache Beam :: SDKs :: Java :: Extensions :: Avro" +// additional avro

Re: [PR] [Python] Add a couple quality-of-life improvemenets to `testing.util.assert_that` [beam]

2024-04-02 Thread via GitHub
hjtran commented on code in PR #30771: URL: https://github.com/apache/beam/pull/30771#discussion_r1548610226 ## sdks/python/apache_beam/examples/snippets/transforms/aggregation/groupby_test.py: ## @@ -226,7 +230,7 @@ def check_global_aggregate_result(grouped): grouped |

Re: [PR] [Python] Add a couple quality-of-life improvemenets to `testing.util.assert_that` [beam]

2024-04-02 Thread via GitHub
robertwb commented on code in PR #30771: URL: https://github.com/apache/beam/pull/30771#discussion_r1548638602 ## sdks/python/apache_beam/testing/util.py: ## @@ -261,6 +261,19 @@ def assert_that( """ assert isinstance(actual, pvalue.PCollection), ( '%s is not a

Re: [PR] Add back Avro 1.8.2 to test [beam]

2024-04-02 Thread via GitHub
Abacn commented on PR #30833: URL: https://github.com/apache/beam/pull/30833#issuecomment-2033245863 R: @tilgalas -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Add back Avro 1.8.2 to test [beam]

2024-04-02 Thread via GitHub
github-actions[bot] commented on PR #30833: URL: https://github.com/apache/beam/pull/30833#issuecomment-2033248776 Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control -- This is an automated message from the Apache Git

Re: [PR] Add back Avro 1.8.2 to test [beam]

2024-04-02 Thread via GitHub
codecov-commenter commented on PR #30833: URL: https://github.com/apache/beam/pull/30833#issuecomment-2033255337 ## [Codecov](https://app.codecov.io/gh/apache/beam/pull/30833?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report

Re: [PR] Create YAML Join Trasnform [beam]

2024-04-02 Thread via GitHub
robertwb commented on code in PR #30734: URL: https://github.com/apache/beam/pull/30734#discussion_r1548659033 ## sdks/python/apache_beam/yaml/yaml_join.py: ## @@ -0,0 +1,161 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license

Re: [I] [Failing Test]: JS2PY not supporting Python 3.12 [beam]

2024-04-02 Thread via GitHub
Polber commented on issue #30829: URL: https://github.com/apache/beam/issues/30829#issuecomment-205471 There are actually some known performance issues with that library that were recently discovered after running some load tests. I was planning on revisiting and possibly using a

Re: [PR] [Python] Add a couple quality-of-life improvemenets to `testing.util.assert_that` [beam]

2024-04-02 Thread via GitHub
hjtran commented on code in PR #30771: URL: https://github.com/apache/beam/pull/30771#discussion_r1548823514 ## sdks/python/apache_beam/testing/util.py: ## @@ -261,6 +261,19 @@ def assert_that( """ assert isinstance(actual, pvalue.PCollection), ( '%s is not a

Re: [PR] [yaml] add --providers and --providers_file flags [beam]

2024-04-02 Thread via GitHub
Polber commented on PR #30835: URL: https://github.com/apache/beam/pull/30835#issuecomment-2033365253 R: @robertwb -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [yaml] add --providers and --providers_file flags [beam]

2024-04-02 Thread via GitHub
github-actions[bot] commented on PR #30835: URL: https://github.com/apache/beam/pull/30835#issuecomment-2033366061 Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control -- This is an automated message from the Apache Git

[PR] [yaml] add --providers and --providers_file flags [beam]

2024-04-02 Thread via GitHub
Polber opened a new pull request, #30835: URL: https://github.com/apache/beam/pull/30835 Allows a user to separate the pipeline spec from the providers spec. This is particularly useful when creating a catalog of transforms that is defined in a shared file that can be passed as an

Re: [PR] [Python] Add a couple quality-of-life improvemenets to `testing.util.assert_that` [beam]

2024-04-02 Thread via GitHub
hjtran commented on code in PR #30771: URL: https://github.com/apache/beam/pull/30771#discussion_r1548612791 ## sdks/python/apache_beam/examples/snippets/transforms/aggregation/groupby_test.py: ## @@ -38,6 +38,10 @@ from .groupby_simple_aggregate import simple_aggregate from

Re: [PR] [Python] Add a couple quality-of-life improvemenets to `testing.util.assert_that` [beam]

2024-04-02 Thread via GitHub
codecov-commenter commented on PR #30771: URL: https://github.com/apache/beam/pull/30771#issuecomment-2033406792 ## [Codecov](https://app.codecov.io/gh/apache/beam/pull/30771?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report

Re: [PR] [Python] Add a couple quality-of-life improvemenets to `testing.util.assert_that` [beam]

2024-04-02 Thread via GitHub
hjtran commented on code in PR #30771: URL: https://github.com/apache/beam/pull/30771#discussion_r1548824012 ## sdks/python/apache_beam/testing/util.py: ## @@ -261,6 +261,19 @@ def assert_that( """ assert isinstance(actual, pvalue.PCollection), ( '%s is not a

Re: [PR] [Python] Add a couple quality-of-life improvemenets to `testing.util.assert_that` [beam]

2024-04-02 Thread via GitHub
hjtran commented on code in PR #30771: URL: https://github.com/apache/beam/pull/30771#discussion_r1548824551 ## sdks/python/apache_beam/testing/util.py: ## @@ -261,6 +261,19 @@ def assert_that( """ assert isinstance(actual, pvalue.PCollection), ( '%s is not a

[PR] Bump com.gradle.enterprise from 3.15.1 to 3.17 [beam]

2024-04-02 Thread via GitHub
dependabot[bot] opened a new pull request, #30836: URL: https://github.com/apache/beam/pull/30836 Bumps com.gradle.enterprise from 3.15.1 to 3.17. [![Dependabot compatibility

Re: [PR] Bump com.gradle.enterprise from 3.15.1 to 3.16.2 [beam]

2024-04-02 Thread via GitHub
dependabot[bot] closed pull request #30142: Bump com.gradle.enterprise from 3.15.1 to 3.16.2 URL: https://github.com/apache/beam/pull/30142 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Bump com.gradle.enterprise from 3.15.1 to 3.16.2 [beam]

2024-04-02 Thread via GitHub
dependabot[bot] commented on PR #30142: URL: https://github.com/apache/beam/pull/30142#issuecomment-2033500199 Superseded by #30836. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[PR] Bump cloud.google.com/go/bigquery from 1.59.1 to 1.60.0 in /sdks [beam]

2024-04-02 Thread via GitHub
dependabot[bot] opened a new pull request, #30837: URL: https://github.com/apache/beam/pull/30837 Bumps [cloud.google.com/go/bigquery](https://github.com/googleapis/google-cloud-go) from 1.59.1 to 1.60.0. Release notes Sourced from

Re: [PR] Bump cloud.google.com/go/bigquery from 1.59.1 to 1.60.0 in /sdks [beam]

2024-04-02 Thread via GitHub
codecov-commenter commented on PR #30837: URL: https://github.com/apache/beam/pull/30837#issuecomment-2033504630 ## [Codecov](https://app.codecov.io/gh/apache/beam/pull/30837?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report

Re: [PR] Bump cloud.google.com/go/bigquery from 1.59.1 to 1.60.0 in /sdks [beam]

2024-04-02 Thread via GitHub
github-actions[bot] commented on PR #30837: URL: https://github.com/apache/beam/pull/30837#issuecomment-2033537169 Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`: R: @riteshghorse for label go. Available commands: - `stop

Re: [PR] Bump com.gradle.enterprise from 3.15.1 to 3.17 [beam]

2024-04-02 Thread via GitHub
github-actions[bot] commented on PR #30836: URL: https://github.com/apache/beam/pull/30836#issuecomment-2033537234 Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment `assign set of reviewers` -- This is an automated