tvalentyn commented on pull request #11726:
URL: https://github.com/apache/beam/pull/11726#issuecomment-629590663
R: @chamikaramj
This is an automated message from the Apache Git Service.
To respond to the message, please
youngoli merged pull request #11728:
URL: https://github.com/apache/beam/pull/11728
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
youngoli commented on a change in pull request #11728:
URL: https://github.com/apache/beam/pull/11728#discussion_r426104694
##
File path: sdks/go/pkg/beam/io/synthetic/step.go
##
@@ -0,0 +1,191 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+//
youngoli commented on a change in pull request #11728:
URL: https://github.com/apache/beam/pull/11728#discussion_r426103916
##
File path: sdks/go/pkg/beam/io/synthetic/step.go
##
@@ -0,0 +1,191 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+//
ibzib opened a new pull request #11729:
URL: https://github.com/apache/beam/pull/11729
This should not be merged until the 2.21.0 release is finalized.
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution
ibzib merged pull request #11717:
URL: https://github.com/apache/beam/pull/11717
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
aaltay commented on pull request #11437:
URL: https://github.com/apache/beam/pull/11437#issuecomment-629549790
Run Java_Examples_Dataflow PreCommit
This is an automated message from the Apache Git Service.
To respond to the
aaltay commented on pull request #11437:
URL: https://github.com/apache/beam/pull/11437#issuecomment-629549669
Run Java_Examples_Dataflow PreCommit
This is an automated message from the Apache Git Service.
To respond to the
rehmanmuradali commented on pull request #11725:
URL: https://github.com/apache/beam/pull/11725#issuecomment-629545286
LGTM. Thanks for taking care of it.
This is an automated message from the Apache Git Service.
To respond
lostluck commented on a change in pull request #11728:
URL: https://github.com/apache/beam/pull/11728#discussion_r426072025
##
File path: sdks/go/pkg/beam/io/synthetic/step.go
##
@@ -0,0 +1,191 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+//
reuvenlax commented on pull request #11725:
URL: https://github.com/apache/beam/pull/11725#issuecomment-629539505
run dataflow validatesrunner
This is an automated message from the Apache Git Service.
To respond to the
reuvenlax commented on pull request #11725:
URL: https://github.com/apache/beam/pull/11725#issuecomment-629539400
R: @rehmanmuradali
This is an automated message from the Apache Git Service.
To respond to the message,
ibzib commented on a change in pull request #11708:
URL: https://github.com/apache/beam/pull/11708#discussion_r426075525
##
File path: sdks/python/apache_beam/runners/portability/abstract_job_service.py
##
@@ -288,6 +289,9 @@ def close(self):
self._zipfile_handle.close()
kennknowles commented on a change in pull request #10946:
URL: https://github.com/apache/beam/pull/10946#discussion_r426073628
##
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamTableFunctionScanRel.java
##
@@ -0,0 +1,162 @@
youngoli commented on pull request #11728:
URL: https://github.com/apache/beam/pull/11728#issuecomment-629520803
R: @lostluck
This is an automated message from the Apache Git Service.
To respond to the message, please log
chamikaramj edited a comment on pull request #11039:
URL: https://github.com/apache/beam/pull/11039#issuecomment-629519752
Yes, I think we need this. Heejong, can you make the JIRA a blocker for beam
2.22 ?
This is an
chamikaramj commented on pull request #11039:
URL: https://github.com/apache/beam/pull/11039#issuecomment-629519752
Yes, I think we need this. Heejong, can you make the jar a blocker for beam
2.22 ?
This is an automated
youngoli opened a new pull request #11728:
URL: https://github.com/apache/beam/pull/11728
Building off the synthetic source, adding a synthetic step. Still need
to update the way the configs are built though.
Thank you for your contribution! Follow
robertwb commented on a change in pull request #11708:
URL: https://github.com/apache/beam/pull/11708#discussion_r426061393
##
File path: sdks/python/apache_beam/runners/portability/abstract_job_service.py
##
@@ -313,39 +329,62 @@ def prepare(self):
with
aaltay commented on pull request #11437:
URL: https://github.com/apache/beam/pull/11437#issuecomment-629507774
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
ibzib opened a new pull request #11727:
URL: https://github.com/apache/beam/pull/11727
This PR should only be merged after the 2.21.0 release is finalized.
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution
youngoli merged pull request #11665:
URL: https://github.com/apache/beam/pull/11665
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
aaltay commented on pull request #11437:
URL: https://github.com/apache/beam/pull/11437#issuecomment-629504732
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
chadrik commented on pull request #11070:
URL: https://github.com/apache/beam/pull/11070#issuecomment-629498648
> Meanwhile, if you make suggestions I think that'd be easiest. (I hope)
Done!
This is an automated
chadrik commented on a change in pull request #11070:
URL: https://github.com/apache/beam/pull/11070#discussion_r426054969
##
File path: website/src/_posts/2020-03-06-python-typing.md
##
@@ -0,0 +1,117 @@
+---
+layout: post
+title: "Python SDK Typing Changes"
+date:
chadrik commented on a change in pull request #11070:
URL: https://github.com/apache/beam/pull/11070#discussion_r426055296
##
File path: website/src/_posts/2020-03-06-python-typing.md
##
@@ -0,0 +1,117 @@
+---
+layout: post
+title: "Python SDK Typing Changes"
+date:
chadrik commented on a change in pull request #11070:
URL: https://github.com/apache/beam/pull/11070#discussion_r426055142
##
File path: website/src/_posts/2020-03-06-python-typing.md
##
@@ -0,0 +1,117 @@
+---
+layout: post
+title: "Python SDK Typing Changes"
+date:
rezarokni commented on pull request #11437:
URL: https://github.com/apache/beam/pull/11437#issuecomment-629487986
added back the stuff removed by merge , so hopefully this can now go in.
And then I will raise PR num two for the website changes.
tvalentyn removed a comment on pull request #11726:
URL: https://github.com/apache/beam/pull/11726#issuecomment-629478846
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
tvalentyn removed a comment on pull request #11726:
URL: https://github.com/apache/beam/pull/11726#issuecomment-629478755
Run Python2 PostCommit
This is an automated message from the Apache Git Service.
To respond to the
rezarokni commented on pull request #11437:
URL: https://github.com/apache/beam/pull/11437#issuecomment-629484336
Merge got rid of changes to snippits.java adding that back
This is an automated message from the Apache Git
tvalentyn commented on pull request #11726:
URL: https://github.com/apache/beam/pull/11726#issuecomment-629478942
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
tvalentyn commented on pull request #11726:
URL: https://github.com/apache/beam/pull/11726#issuecomment-629478755
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
tvalentyn opened a new pull request #11726:
URL: https://github.com/apache/beam/pull/11726
Post-Commit Tests Status (on master branch)
Lang | SDK | Apex | Dataflow | Flink |
pabloem merged pull request #11634:
URL: https://github.com/apache/beam/pull/11634
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
pabloem commented on pull request #11634:
URL: https://github.com/apache/beam/pull/11634#issuecomment-629477820
LGTM
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
pabloem merged pull request #11710:
URL: https://github.com/apache/beam/pull/11710
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
pabloem commented on pull request #11710:
URL: https://github.com/apache/beam/pull/11710#issuecomment-629476263
thanks @omarismail94 !
This is an automated message from the Apache Git Service.
To respond to the message,
pabloem merged pull request #11719:
URL: https://github.com/apache/beam/pull/11719
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
pabloem commented on pull request #11719:
URL: https://github.com/apache/beam/pull/11719#issuecomment-629456417
thank you @bntnam !
This is an automated message from the Apache Git Service.
To respond to the message, please
tvalentyn commented on pull request #11707:
URL: https://github.com/apache/beam/pull/11707#issuecomment-629456098
re:
> I didn't change py37-lint to py38-lint, because this requires updating
dependencies (for example, our current version of pycodestyle doesn't support
Python 3.8
ananvay commented on pull request #11720:
URL: https://github.com/apache/beam/pull/11720#issuecomment-629455295
LGTM. Thanks Robert!
This is an automated message from the Apache Git Service.
To respond to the message, please
robertwb commented on a change in pull request #11720:
URL: https://github.com/apache/beam/pull/11720#discussion_r426020019
##
File path:
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnHarness.java
##
@@ -206,18 +205,16 @@ public static void main(
pabloem commented on pull request #11710:
URL: https://github.com/apache/beam/pull/11710#issuecomment-629454663
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
robertwb commented on a change in pull request #11720:
URL: https://github.com/apache/beam/pull/11720#discussion_r426018974
##
File path:
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnHarness.java
##
@@ -206,18 +205,16 @@ public static void main(
ananvay commented on pull request #11720:
URL: https://github.com/apache/beam/pull/11720#issuecomment-629447440
Thanks a lot Robert! Overall LGTM. Just a few minor comments, PTAL.
This is an automated message from the Apache
ananvay commented on a change in pull request #11720:
URL: https://github.com/apache/beam/pull/11720#discussion_r426013359
##
File path:
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnHarness.java
##
@@ -206,18 +205,16 @@ public static void main(
ananvay commented on a change in pull request #11720:
URL: https://github.com/apache/beam/pull/11720#discussion_r426012824
##
File path:
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnHarness.java
##
@@ -206,18 +205,16 @@ public static void main(
apilloud merged pull request #11698:
URL: https://github.com/apache/beam/pull/11698
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
apilloud commented on pull request #11698:
URL: https://github.com/apache/beam/pull/11698#issuecomment-629438381
At very least you left comments on the bug.
This is an automated message from the Apache Git Service.
To
pabloem commented on pull request #11086:
URL: https://github.com/apache/beam/pull/11086#issuecomment-629436995
Run Python 3.7 PostCommit
This is an automated message from the Apache Git Service.
To respond to the message,
boyuanzz commented on a change in pull request #11715:
URL: https://github.com/apache/beam/pull/11715#discussion_r425995961
##
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/splittabledofn/GrowableOffsetRangeTracker.java
##
@@ -0,0 +1,103 @@
+/*
+ *
pabloem commented on pull request #11339:
URL: https://github.com/apache/beam/pull/11339#issuecomment-629426161
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
pabloem commented on pull request #11712:
URL: https://github.com/apache/beam/pull/11712#issuecomment-629425913
lgtm given that the we can get precommit to pass before merging
This is an automated message from the Apache Git
TheNeuralBit commented on pull request #11272:
URL: https://github.com/apache/beam/pull/11272#issuecomment-629422818
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message,
reuvenlax commented on pull request #11725:
URL: https://github.com/apache/beam/pull/11725#issuecomment-629422623
run dataflow validatesrunner
This is an automated message from the Apache Git Service.
To respond to the
reuvenlax opened a new pull request #11725:
URL: https://github.com/apache/beam/pull/11725
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
ibzib commented on a change in pull request #11708:
URL: https://github.com/apache/beam/pull/11708#discussion_r425987361
##
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/io/ClassLoaderFileSystem.java
##
@@ -0,0 +1,154 @@
+/*
+ * Licensed to the Apache Software
ibzib commented on a change in pull request #11708:
URL: https://github.com/apache/beam/pull/11708#discussion_r425986977
##
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/io/ClassLoaderFileSystem.java
##
@@ -0,0 +1,161 @@
+/*
+ * Licensed to the Apache Software
TheNeuralBit commented on pull request #11272:
URL: https://github.com/apache/beam/pull/11272#issuecomment-629421832
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message,
boyuanzz commented on a change in pull request #11715:
URL: https://github.com/apache/beam/pull/11715#discussion_r425986350
##
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/splittabledofn/GrowableOffsetRangeTracker.java
##
@@ -0,0 +1,103 @@
+/*
+ *
robinyqiu commented on pull request #11272:
URL: https://github.com/apache/beam/pull/11272#issuecomment-629420575
Java PreCommit failed due to a build failure. Please help run again.
This is an automated message from the
lukecwik commented on pull request #11721:
URL: https://github.com/apache/beam/pull/11721#issuecomment-629419737
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
aaltay opened a new pull request #11723:
URL: https://github.com/apache/beam/pull/11723
**Please** add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution
aaltay closed pull request #11723:
URL: https://github.com/apache/beam/pull/11723
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
aaltay opened a new pull request #11724:
URL: https://github.com/apache/beam/pull/11724
**Please** add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution
ananvay commented on pull request #11721:
URL: https://github.com/apache/beam/pull/11721#issuecomment-629411984
Thanks Luke! LGTM
This is an automated message from the Apache Git Service.
To respond to the message, please
Hannah-Jiang commented on pull request #11717:
URL: https://github.com/apache/beam/pull/11717#issuecomment-629411176
> R: @ibzib
Oops, thank you.
This is an automated message from the Apache Git Service.
To respond
Hannah-Jiang merged pull request #11584:
URL: https://github.com/apache/beam/pull/11584
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
jaketf commented on pull request #11596:
URL: https://github.com/apache/beam/pull/11596#issuecomment-629406986
@pabloem bump ^. please retest this.
This is an automated message from the Apache Git Service.
To respond to the
ibzib commented on pull request #11722:
URL: https://github.com/apache/beam/pull/11722#issuecomment-629406842
> But I would not recommend redoing the RC if you are already done. Just
merge it to the branch and include it if you have to roll another RC.
Thanks Thomas. I have already
tweise commented on pull request #11722:
URL: https://github.com/apache/beam/pull/11722#issuecomment-629405793
We are internally running 2.21 on Flink 1.10.1. There is little to no risk
including this.
But I would not recommend redoing the RC if you are already done. Just merge
it
amaliujia commented on pull request #10946:
URL: https://github.com/apache/beam/pull/10946#issuecomment-629403702
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
ibzib commented on pull request #11722:
URL: https://github.com/apache/beam/pull/11722#issuecomment-629401614
I'm nearly finished making a release candidate. Is there an important reason
to cherry-pick this?
This is an
mxm commented on pull request #11678:
URL: https://github.com/apache/beam/pull/11678#issuecomment-629396868
Based on the load test results, I'm not changing the default behavior here.
Instead, flushing the bundle output before a checkpoint can be turned on
optionally.
lukecwik edited a comment on pull request #11721:
URL: https://github.com/apache/beam/pull/11721#issuecomment-629393804
R: @ananvay @youngoli
This is an automated message from the Apache Git Service.
To respond to the
aaltay commented on pull request #11437:
URL: https://github.com/apache/beam/pull/11437#issuecomment-629396682
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
tweise opened a new pull request #11722:
URL: https://github.com/apache/beam/pull/11722
Backport of #11683
Post-Commit Tests Status (on master branch)
Lang | SDK | Apex |
robertwb commented on pull request #11039:
URL: https://github.com/apache/beam/pull/11039#issuecomment-629394803
@ihji Just thinking about timing, were we hoping to get this into 2.22?
This is an automated message from the
lukecwik commented on pull request #11721:
URL: https://github.com/apache/beam/pull/11721#issuecomment-629393804
R: @ananvay
This is an automated message from the Apache Git Service.
To respond to the message, please log on
aaltay commented on pull request #11437:
URL: https://github.com/apache/beam/pull/11437#issuecomment-629386383
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
lukecwik opened a new pull request #11721:
URL: https://github.com/apache/beam/pull/11721
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [ ] [**Choose
stale[bot] commented on pull request #10528:
URL: https://github.com/apache/beam/pull/10528#issuecomment-629380085
This pull request has been marked as stale due to 60 days of inactivity. It
will be closed in 1 week if no further activity occurs. If you think that’s
incorrect or this pull
jaketf commented on pull request #11339:
URL: https://github.com/apache/beam/pull/11339#issuecomment-629376974
@pabloem 843104d was a pretty simple fix for api surface test
```
git rev-parse HEAD && ./gradlew
:sdks:java:io:google-cloud-platform:cleanTest
robertwb edited a comment on pull request #11720:
URL: https://github.com/apache/beam/pull/11720#issuecomment-629376271
R: @ananvay
This is an automated message from the Apache Git Service.
To respond to the message, please
robertwb commented on pull request #11720:
URL: https://github.com/apache/beam/pull/11720#issuecomment-629376271
R: @ ananvay
This is an automated message from the Apache Git Service.
To respond to the message, please log on
robertwb opened a new pull request #11720:
URL: https://github.com/apache/beam/pull/11720
Instead always pull bundle descriptors from the runner.
This avoids having potentially duplicated caches of all bundle
Thank you for your contribution!
aaltay commented on pull request #11584:
URL: https://github.com/apache/beam/pull/11584#issuecomment-629369467
Run Python PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
aaltay commented on pull request #11717:
URL: https://github.com/apache/beam/pull/11717#issuecomment-629369332
R: @ibzib
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
aaltay commented on pull request #11705:
URL: https://github.com/apache/beam/pull/11705#issuecomment-629368448
> stepik is the platform where these courses are uploaded , an downloaded by
intellij
Thank you! :)
This
jaketf commented on pull request #11339:
URL: https://github.com/apache/beam/pull/11339#issuecomment-629367380
@pabloem re: api surface.
So the history here is that the client library executeBundle method is
broken so we were forced to use out own http client (and our own exceptions).
jaketf commented on pull request #11339:
URL: https://github.com/apache/beam/pull/11339#issuecomment-629364334
@mwalenia
> What exactly causes this
udim commented on pull request #11070:
URL: https://github.com/apache/beam/pull/11070#issuecomment-629360659
> > @chadrik, do you have the "edit file" option available?
>
> Nope :(
I think that maybe it's because you're not on
pabloem commented on pull request #11339:
URL: https://github.com/apache/beam/pull/11339#issuecomment-629357697
this test checks that we're not increasing the dependencies that we expose
in the API. We can add the Healthcare IO classes.
Other classes I think we should try to figure out
pabloem commented on pull request #11339:
URL: https://github.com/apache/beam/pull/11339#issuecomment-629356272
We have a failure from a test checking out the API surface for the gcp io
package:
mxm commented on pull request #11678:
URL: https://github.com/apache/beam/pull/11678#issuecomment-629353811
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
mxm removed a comment on pull request #11678:
URL: https://github.com/apache/beam/pull/11678#issuecomment-629351722
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
pabloem merged pull request #11718:
URL: https://github.com/apache/beam/pull/11718
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
pabloem commented on pull request #11718:
URL: https://github.com/apache/beam/pull/11718#issuecomment-629352608
Thanks @kamilwu
This is an automated message from the Apache Git Service.
To respond to the message, please log
mxm removed a comment on pull request #11678:
URL: https://github.com/apache/beam/pull/11678#issuecomment-629351467
Load Tests Python ParDo Flink Streaming
This is an automated message from the Apache Git Service.
To respond
1 - 100 of 137 matches
Mail list logo
