damondouglas commented on pull request #11883:
URL: https://github.com/apache/beam/pull/11883#issuecomment-639255195
@lostluck and @henryken I updated the [stepik
course](https://stepik.org/course/70387) and commited the updated
`*-remote.yaml` files to this PR. It is ready to merge.
rezarokni opened a new pull request #11929:
URL: https://github.com/apache/beam/pull/11929
Add deadletter support to JsonToRow.
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
amaliujia commented on pull request #11868:
URL: https://github.com/apache/beam/pull/11868#issuecomment-639251081
Thank you Andrew! Will address your comments soon!
This is an automated message from the Apache Git Service.
stale[bot] commented on pull request #9899:
URL: https://github.com/apache/beam/pull/9899#issuecomment-639246523
This pull request has been marked as stale due to 60 days of inactivity. It
will be closed in 1 week if no further activity occurs. If you think that’s
incorrect or this pull
henryken commented on pull request #11921:
URL: https://github.com/apache/beam/pull/11921#issuecomment-639237442
@pabloem, can help to merge?
This is an automated message from the Apache Git Service.
To respond to the
suztomo commented on pull request #11586:
URL: https://github.com/apache/beam/pull/11586#issuecomment-639232697
This idea was a bad idea; a hack on top of another hack.
This is an automated message from the Apache Git
aaltay commented on pull request #11804:
URL: https://github.com/apache/beam/pull/11804#issuecomment-639232691
Are not both `gcpTempLocation` or `tempLocation` both valid?
This is an automated message from the Apache Git
suztomo closed pull request #11586:
URL: https://github.com/apache/beam/pull/11586
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
aaltay commented on pull request #11805:
URL: https://github.com/apache/beam/pull/11805#issuecomment-639232145
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
aaltay commented on pull request #11882:
URL: https://github.com/apache/beam/pull/11882#issuecomment-639231673
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
aaltay commented on pull request #11706:
URL: https://github.com/apache/beam/pull/11706#issuecomment-639230979
@rosetn - did you have a chance to review this?
This is an automated message from the Apache Git Service.
To
lostluck commented on pull request #11927:
URL: https://github.com/apache/beam/pull/11927#issuecomment-639196604
Run Go PostCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
robertwb commented on a change in pull request #11766:
URL: https://github.com/apache/beam/pull/11766#discussion_r435632933
##
File path: sdks/python/apache_beam/dataframe/expressions.py
##
@@ -85,16 +87,10 @@ def evaluate_at(self, session): # type: (Session) -> T
aaltay commented on a change in pull request #11877:
URL: https://github.com/apache/beam/pull/11877#discussion_r435631141
##
File path: .github/workflows/build_wheels.yml
##
@@ -0,0 +1,141 @@
+name: Build python wheels
+
+on:
+ push:
+branches:
+ - master
+ -
aaltay commented on a change in pull request #11877:
URL: https://github.com/apache/beam/pull/11877#discussion_r435630823
##
File path: .github/workflows/build_wheels.yml
##
@@ -0,0 +1,141 @@
+name: Build python wheels
+
+on:
+ push:
+branches:
+ - master
+ -
chamikaramj commented on pull request #11928:
URL: https://github.com/apache/beam/pull/11928#issuecomment-639190896
R: @robertwb
CC: @mxm
This is an automated message from the Apache Git Service.
To respond to the
aaltay commented on pull request #11877:
URL: https://github.com/apache/beam/pull/11877#issuecomment-639190586
> > How can I preview the action on the fork:
[TobKed#3](https://github.com/TobKed/beam/pull/3) ?
>
> @aaltay
chamikaramj opened a new pull request #11928:
URL: https://github.com/apache/beam/pull/11928
Also removes it from in-progress IO connectors list now that it's supported
by portable runners as well as Dataflow.
Thank you for your contribution! Follow
lostluck commented on pull request #11927:
URL: https://github.com/apache/beam/pull/11927#issuecomment-639183557
R: @tysonjh
cc: @youngoli
This is an automated message from the Apache Git Service.
To respond to the
lostluck opened a new pull request #11927:
URL: https://github.com/apache/beam/pull/11927
I noticed that there were several stranglers that were not following the
import name conventions, and this PR completes that work.
pipepb, fnpb, jobpb for the Pipeline protos, Fn Execution
kennknowles commented on a change in pull request #11820:
URL: https://github.com/apache/beam/pull/11820#discussion_r435594096
##
File path:
sdks/java/testing/nexmark/src/main/java/org/apache/beam/sdk/nexmark/queries/zetasql/ZetaSqlQuery0.java
##
@@ -0,0 +1,92 @@
+/*
+ *
apilloud commented on a change in pull request #11820:
URL: https://github.com/apache/beam/pull/11820#discussion_r435598706
##
File path:
sdks/java/testing/nexmark/src/main/java/org/apache/beam/sdk/nexmark/queries/zetasql/ZetaSqlQuery0.java
##
@@ -0,0 +1,92 @@
+/*
+ *
robertwb commented on pull request #11884:
URL: https://github.com/apache/beam/pull/11884#issuecomment-639161004
There's a lot of files there that don't seem relevant; I think we should go
through and figure out what's needed for the actual plugin vs. what's "extras"
that just got copied
kennknowles commented on a change in pull request #11820:
URL: https://github.com/apache/beam/pull/11820#discussion_r435597049
##
File path:
sdks/java/testing/nexmark/src/main/java/org/apache/beam/sdk/nexmark/queries/zetasql/ZetaSqlQuery0.java
##
@@ -0,0 +1,92 @@
+/*
+ *
kennknowles commented on a change in pull request #11820:
URL: https://github.com/apache/beam/pull/11820#discussion_r435597049
##
File path:
sdks/java/testing/nexmark/src/main/java/org/apache/beam/sdk/nexmark/queries/zetasql/ZetaSqlQuery0.java
##
@@ -0,0 +1,92 @@
+/*
+ *
robertwb commented on a change in pull request #11894:
URL: https://github.com/apache/beam/pull/11894#discussion_r435595283
##
File path:
sdks/python/apache_beam/runners/portability/fn_api_runner/fn_runner_test.py
##
@@ -377,11 +377,6 @@ def process_timer(
robertwb commented on pull request #11835:
URL: https://github.com/apache/beam/pull/11835#issuecomment-639152041
Run Python2_PVR_Flink PreCommit
This is an automated message from the Apache Git Service.
To respond to the
lostluck opened a new pull request #11926:
URL: https://github.com/apache/beam/pull/11926
Adds a unit test for the "user side" type encoders /decoders. This will help
avoiding having a broken state as we change the string coder, and default
custom type coders.
Also adjusts the
lostluck commented on pull request #11926:
URL: https://github.com/apache/beam/pull/11926#issuecomment-639122665
R: @tysonjh
cc: @youngoli
This is an automated message from the Apache Git Service.
To respond to the
lostluck commented on pull request #11925:
URL: https://github.com/apache/beam/pull/11925#issuecomment-639119430
R: @tysonjh
cc: @youngoli
This is an automated message from the Apache Git Service.
To respond to the
lostluck opened a new pull request #11925:
URL: https://github.com/apache/beam/pull/11925
This adds initial utility functions for encoding and decoding utf8 strings
in the Go SDK.
Doesn't make use of them yet. In practice this is already how strings are
encoded in the Go SDK, but
lukecwik commented on a change in pull request #11922:
URL: https://github.com/apache/beam/pull/11922#discussion_r435546832
##
File path:
sdks/java/harness/src/test/java/org/apache/beam/fn/harness/FnApiDoFnRunnerTest.java
##
@@ -1593,6 +1601,391 @@ public void
apilloud commented on a change in pull request #11868:
URL: https://github.com/apache/beam/pull/11868#discussion_r435497089
##
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/TVFSlidingWindowFn.java
##
@@ -0,0 +1,101 @@
+/*
+ *
lukecwik commented on pull request #11821:
URL: https://github.com/apache/beam/pull/11821#issuecomment-639108631
R: @Ardagan @amaliujia
This is an automated message from the Apache Git Service.
To respond to the message,
pabloem merged pull request #11920:
URL: https://github.com/apache/beam/pull/11920
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
chamikaramj commented on pull request #11846:
URL: https://github.com/apache/beam/pull/11846#issuecomment-639098591
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message,
TheNeuralBit merged pull request #11918:
URL: https://github.com/apache/beam/pull/11918
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
boyuanzz commented on a change in pull request #11922:
URL: https://github.com/apache/beam/pull/11922#discussion_r435521657
##
File path:
sdks/java/harness/src/test/java/org/apache/beam/fn/harness/FnApiDoFnRunnerTest.java
##
@@ -1593,6 +1601,391 @@ public void
vmarquez commented on a change in pull request #10546:
URL: https://github.com/apache/beam/pull/10546#discussion_r434870508
##
File path:
sdks/java/io/cassandra/src/main/java/org/apache/beam/sdk/io/cassandra/CassandraIO.java
##
@@ -1170,4 +898,44 @@ private void
rehmanmuradali commented on pull request #11924:
URL: https://github.com/apache/beam/pull/11924#issuecomment-639088647
R: @reuvenlax
Could you please take a look that I am on right track?
This is an automated message
rehmanmuradali opened a new pull request #11924:
URL: https://github.com/apache/beam/pull/11924
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [ ] [**Choose
pabloem commented on pull request #11920:
URL: https://github.com/apache/beam/pull/11920#issuecomment-639065558
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
jphalip commented on pull request #11918:
URL: https://github.com/apache/beam/pull/11918#issuecomment-639064988
Ok, I've loaded `script.config`. I've also added a confirmation message
before submitting the API request.
This
ibzib commented on pull request #11918:
URL: https://github.com/apache/beam/pull/11918#issuecomment-639062174
> All the variables used should already be set in script.config. Does that
work?
That's probably fine, but if that's the expectation we need to `source
script.config`.
bashir2 commented on pull request #11617:
URL: https://github.com/apache/beam/pull/11617#issuecomment-639060524
Closing this for now; will try to recreate another one later if I come back
to Beam documentation.
This is an
bashir2 closed pull request #11617:
URL: https://github.com/apache/beam/pull/11617
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
pabloem merged pull request #11893:
URL: https://github.com/apache/beam/pull/11893
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
pabloem commented on pull request #11893:
URL: https://github.com/apache/beam/pull/11893#issuecomment-639059270
Ah great observation! I'll merge. I am not aware of it being flaky otherwise.
This is an automated message from
jphalip commented on pull request #11918:
URL: https://github.com/apache/beam/pull/11918#issuecomment-639058954
@ibzib @TheNeuralBit Thank you both for the feedback. I've moved the code to
a separate script. All the variables used should already be set in
`script.config`. Does that work?
jaketf edited a comment on pull request #11893:
URL: https://github.com/apache/beam/pull/11893#issuecomment-639055068
Hmmm my latest commit was just `spotlessApply` and this entire PR's change
(how we pass the auth token for HCAPI requests for FHIR) seems unrelated to the
GCS object
jaketf commented on pull request #11893:
URL: https://github.com/apache/beam/pull/11893#issuecomment-639055068
Hmmm my latest commit was just `spotlessApply` and this entire PR's change
(how we pass the auth token for HCAPI requests for FHIR) seems unrelated to the
GCS object moving logic
chunyang commented on pull request #11923:
URL: https://github.com/apache/beam/pull/11923#issuecomment-639047436
R: @pabloem
This is an automated message from the Apache Git Service.
To respond to the message, please log on
chunyang opened a new pull request #11923:
URL: https://github.com/apache/beam/pull/11923
Support STRUCT, FLOAT64, INT64 BigQuery types in BIgQuery to Avro schema
conversion.
We already support RECORD, FLOAT, and INTEGER, which are aliases of the
three types being added.
apilloud merged pull request #11836:
URL: https://github.com/apache/beam/pull/11836
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
apilloud commented on pull request #11836:
URL: https://github.com/apache/beam/pull/11836#issuecomment-639023595
I get `No new linkage errors`.
This is an automated message from the Apache Git Service.
To respond to the
lukecwik commented on pull request #11922:
URL: https://github.com/apache/beam/pull/11922#issuecomment-639020928
R: @boyuanzz @chamikaramj
This is an automated message from the Apache Git Service.
To respond to the message,
lukecwik opened a new pull request #11922:
URL: https://github.com/apache/beam/pull/11922
This fixes a bug where we would output within all the windows instead of
just the current window.
This would not impact any SDF that used only a single window while
processing.
TheNeuralBit commented on a change in pull request #11766:
URL: https://github.com/apache/beam/pull/11766#discussion_r435426414
##
File path: sdks/python/apache_beam/dataframe/partitionings.py
##
@@ -0,0 +1,136 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under
suztomo commented on pull request #11836:
URL: https://github.com/apache/beam/pull/11836#issuecomment-639010785
Does `sdks/java/build-tools/beam-linkage-check.sh`
([wiki](https://cwiki.apache.org/confluence/display/BEAM/Dependency+Upgrades)),
without arguments, complain anything now?
Zhangyx39 commented on pull request #11915:
URL: https://github.com/apache/beam/pull/11915#issuecomment-639009096
Thank you, Likasz and Xinyu.
This is an automated message from the Apache Git Service.
To respond to the
apilloud commented on pull request #11836:
URL: https://github.com/apache/beam/pull/11836#issuecomment-639007691
R: @suztomo
This is an automated message from the Apache Git Service.
To respond to the message, please log on
xinyuiscool commented on pull request #11915:
URL: https://github.com/apache/beam/pull/11915#issuecomment-639006539
@lukecwik : thanks for merging it!
This is an automated message from the Apache Git Service.
To respond to
TheNeuralBit commented on a change in pull request #11766:
URL: https://github.com/apache/beam/pull/11766#discussion_r435422511
##
File path: sdks/python/apache_beam/dataframe/expressions.py
##
@@ -85,16 +87,10 @@ def evaluate_at(self, session): # type: (Session) -> T
damondouglas commented on pull request #11883:
URL: https://github.com/apache/beam/pull/11883#issuecomment-638992758
I've incorporated all the helpful comments. I'll wait for Henry's final
approval before updating stepik/committing `*-remote.yaml` files. Thank you,
both.
chamikaramj commented on pull request #11846:
URL: https://github.com/apache/beam/pull/11846#issuecomment-638992107
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
aromanenko-dev commented on pull request #11396:
URL: https://github.com/apache/beam/pull/11396#issuecomment-638984073
retest this please
This is an automated message from the Apache Git Service.
To respond to the message,
aromanenko-dev removed a comment on pull request #11396:
URL: https://github.com/apache/beam/pull/11396#issuecomment-638983908
retest this please
This is an automated message from the Apache Git Service.
To respond to the
aromanenko-dev commented on pull request #11396:
URL: https://github.com/apache/beam/pull/11396#issuecomment-638984333
retest this please
This is an automated message from the Apache Git Service.
To respond to the message,
aromanenko-dev removed a comment on pull request #11396:
URL: https://github.com/apache/beam/pull/11396#issuecomment-638984073
retest this please
This is an automated message from the Apache Git Service.
To respond to the
aromanenko-dev commented on pull request #11396:
URL: https://github.com/apache/beam/pull/11396#issuecomment-638983908
retest this please
This is an automated message from the Apache Git Service.
To respond to the message,
aromanenko-dev commented on a change in pull request #11396:
URL: https://github.com/apache/beam/pull/11396#discussion_r435399974
##
File path:
sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcIO.java
##
@@ -1217,6 +1297,16 @@ void set(
return
aromanenko-dev commented on a change in pull request #11396:
URL: https://github.com/apache/beam/pull/11396#discussion_r435399974
##
File path:
sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcIO.java
##
@@ -1217,6 +1297,16 @@ void set(
return
TobKed commented on a change in pull request #11877:
URL: https://github.com/apache/beam/pull/11877#discussion_r435407993
##
File path: .github/workflows/build_wheels.yml
##
@@ -0,0 +1,141 @@
+name: Build python wheels
+
+on:
+ push:
+branches:
+ - master
+ -
TobKed commented on pull request #11877:
URL: https://github.com/apache/beam/pull/11877#issuecomment-638978380
> How can I preview the action on the fork:
[TobKed#3](https://github.com/TobKed/beam/pull/3) ?
@aaltay
lukecwik commented on pull request #11915:
URL: https://github.com/apache/beam/pull/11915#issuecomment-638977891
Nice article on the performance impact of the different string concatenation
methods.
This is an automated
ibzib commented on pull request #11921:
URL: https://github.com/apache/beam/pull/11921#issuecomment-638977383
> @ibzib, may I know what kind of error that you encountered that needs this
fix?
Please see the related jira: https://issues.apache.org/jira/browse/BEAM-10194
lukecwik merged pull request #11915:
URL: https://github.com/apache/beam/pull/11915
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
TobKed commented on a change in pull request #11877:
URL: https://github.com/apache/beam/pull/11877#discussion_r435404202
##
File path: .github/workflows/build_wheels.yml
##
@@ -0,0 +1,141 @@
+name: Build python wheels
+
+on:
+ push:
+branches:
+ - master
+ -
TobKed commented on a change in pull request #11877:
URL: https://github.com/apache/beam/pull/11877#discussion_r435403856
##
File path: .github/workflows/build_wheels.yml
##
@@ -0,0 +1,141 @@
+name: Build python wheels
+
+on:
+ push:
+branches:
+ - master
+ -
henryken commented on pull request #11921:
URL: https://github.com/apache/beam/pull/11921#issuecomment-638976587
@ibzib, may I know what kind of error that you encountered that needs this
fix?
This is an automated message
ibzib opened a new pull request #11921:
URL: https://github.com/apache/beam/pull/11921
R: @henryken
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [ ] [**Choose
lostluck commented on a change in pull request #11883:
URL: https://github.com/apache/beam/pull/11883#discussion_r435397313
##
File path: learning/katas/go/Core Transforms/Combine/CombineFn/pkg/task/task.go
##
@@ -47,9 +47,9 @@ func (c *averageFn) MergeAccumulators(accumA,
robertwb commented on pull request #11835:
URL: https://github.com/apache/beam/pull/11835#issuecomment-638952489
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
robertwb commented on a change in pull request #11766:
URL: https://github.com/apache/beam/pull/11766#discussion_r435373732
##
File path: sdks/python/apache_beam/dataframe/expressions.py
##
@@ -85,16 +87,10 @@ def evaluate_at(self, session): # type: (Session) -> T
robertwb commented on a change in pull request #11787:
URL: https://github.com/apache/beam/pull/11787#discussion_r435370735
##
File path: sdks/python/apache_beam/dataframe/doctests.py
##
@@ -66,30 +93,19 @@ def __init__(self):
self._all_frames = {}
def
pabloem commented on pull request #11920:
URL: https://github.com/apache/beam/pull/11920#issuecomment-638947008
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
ibzib commented on pull request #11918:
URL: https://github.com/apache/beam/pull/11918#issuecomment-638943733
I didn't realize Brian had already reviewed... and we had almost the exact
same comments
This is an automated
ibzib commented on a change in pull request #11918:
URL: https://github.com/apache/beam/pull/11918#discussion_r435356754
##
File path: website/www/site/content/en/contribute/release-guide.md
##
@@ -1134,12 +1134,29 @@ Create and push a new signed tag for the released
version
pabloem merged pull request #11898:
URL: https://github.com/apache/beam/pull/11898
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
TheNeuralBit commented on a change in pull request #11918:
URL: https://github.com/apache/beam/pull/11918#discussion_r435351070
##
File path: website/www/site/content/en/contribute/release-guide.md
##
@@ -1134,12 +1134,29 @@ Create and push a new signed tag for the released
chamikaramj commented on pull request #11919:
URL: https://github.com/apache/beam/pull/11919#issuecomment-638938144
@dpmills @slavachernyak @reuvenlax are you interested in reviewing this ?
This is an automated message from
aromanenko-dev commented on a change in pull request #11749:
URL: https://github.com/apache/beam/pull/11749#discussion_r434729096
##
File path:
sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/ReadFromKafkaViaSDF.java
##
@@ -0,0 +1,697 @@
+/*
+ * Licensed to the
aromanenko-dev commented on a change in pull request #11749:
URL: https://github.com/apache/beam/pull/11749#discussion_r435354750
##
File path:
sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/ReadFromKafkaViaSDF.java
##
@@ -0,0 +1,697 @@
+/*
+ * Licensed to the
lastomato commented on pull request #11920:
URL: https://github.com/apache/beam/pull/11920#issuecomment-638928233
I am not entirely sure if I need to create a JIRA issue for such a trivial
change.
This is an automated
lastomato opened a new pull request #11920:
URL: https://github.com/apache/beam/pull/11920
- Chain constructors instead of assigning directly;
- Typo fixes.
The changes in this PR were from an internal code review.
R: @pabloem
cc @jaketf
damondouglas commented on a change in pull request #11883:
URL: https://github.com/apache/beam/pull/11883#discussion_r435349866
##
File path: learning/katas/go/Core Transforms/Combine/CombineFn/pkg/task/task.go
##
@@ -47,9 +47,9 @@ func (c *averageFn) MergeAccumulators(accumA,
lostluck commented on a change in pull request #11883:
URL: https://github.com/apache/beam/pull/11883#discussion_r435344008
##
File path: learning/katas/go/Core Transforms/Combine/CombineFn/pkg/task/task.go
##
@@ -0,0 +1,55 @@
+// Licensed to the Apache Software Foundation
dpcollins-google opened a new pull request #11919:
URL: https://github.com/apache/beam/pull/11919
Also adapt to beam conventions and restrictions.
This is staged here
https://github.com/googleapis/java-pubsublite/tree/master/pubsublite-beam-io
henryken commented on a change in pull request #11883:
URL: https://github.com/apache/beam/pull/11883#discussion_r435317881
##
File path: learning/katas/go/Core Transforms/Combine/CombineFn/pkg/task/task.go
##
@@ -47,9 +47,9 @@ func (c *averageFn) MergeAccumulators(accumA,
henryken commented on a change in pull request #11883:
URL: https://github.com/apache/beam/pull/11883#discussion_r435314757
##
File path: learning/katas/go/Core Transforms/Combine/CombineFn/pkg/task/task.go
##
@@ -0,0 +1,55 @@
+// Licensed to the Apache Software Foundation
1 - 100 of 122 matches
Mail list logo
