[GitHub] [beam] ihji commented on pull request #11942: [BEAM-10208] add cross-language KafkaIO integration test

2020-06-05 Thread GitBox
ihji commented on pull request #11942: URL: https://github.com/apache/beam/pull/11942#issuecomment-639983521 CC: @robertwb This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [beam] ihji commented on pull request #11942: [BEAM-10208] add cross-language KafkaIO integration test

2020-06-05 Thread GitBox
ihji commented on pull request #11942: URL: https://github.com/apache/beam/pull/11942#issuecomment-639966084 Please also run "Run Python 2 PostCommit" and "Run Python 3.7 PostCommit" This is an automated message from the

[GitHub] [beam] ihji commented on pull request #11942: [BEAM-10208] add cross-language KafkaIO integration test

2020-06-05 Thread GitBox
ihji commented on pull request #11942: URL: https://github.com/apache/beam/pull/11942#issuecomment-639965704 R: @chamikaramj This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [beam] ihji opened a new pull request #11942: [BEAM-10208] add cross-language KafkaIO integration test

2020-06-05 Thread GitBox
ihji opened a new pull request #11942: URL: https://github.com/apache/beam/pull/11942 Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] [**Choose

[GitHub] [beam] lukecwik commented on pull request #11941: [BEAM-2939] Fix splittable DoFn lifecycle.

2020-06-05 Thread GitBox
lukecwik commented on pull request #11941: URL: https://github.com/apache/beam/pull/11941#issuecomment-639964771 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] pabloem commented on pull request #11923: [BEAM-10176] Support STRUCT, FLOAT64, INT64 BigQuery types

2020-06-05 Thread GitBox
pabloem commented on pull request #11923: URL: https://github.com/apache/beam/pull/11923#issuecomment-639949346 Run Python 3.7 PostCommit This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] epicfaace commented on pull request #11824: [BEAM-10101] Add HttpIO / HttpFileSystem (Python)

2020-06-05 Thread GitBox
epicfaace commented on pull request #11824: URL: https://github.com/apache/beam/pull/11824#issuecomment-639946797 I'll be making changes soon. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] reuvenlax commented on a change in pull request #11929: [BEAM-10201] Add deadletter support to JsonToRow

2020-06-05 Thread GitBox
reuvenlax commented on a change in pull request #11929: URL: https://github.com/apache/beam/pull/11929#discussion_r436220739 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/JsonToRow.java ## @@ -72,10 +79,44 @@ @Experimental(Kind.SCHEMAS) public

[GitHub] [beam] pabloem commented on a change in pull request #11929: [BEAM-10201] Add deadletter support to JsonToRow

2020-06-05 Thread GitBox
pabloem commented on a change in pull request #11929: URL: https://github.com/apache/beam/pull/11929#discussion_r436215155 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/JsonToRow.java ## @@ -116,4 +157,65 @@ private ObjectMapper objectMapper() {

[GitHub] [beam] pabloem commented on a change in pull request #11929: [BEAM-10201] Add deadletter support to JsonToRow

2020-06-05 Thread GitBox
pabloem commented on a change in pull request #11929: URL: https://github.com/apache/beam/pull/11929#discussion_r436214157 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/JsonToRow.java ## @@ -116,4 +157,65 @@ private ObjectMapper objectMapper() {

[GitHub] [beam] aaltay commented on pull request #8457: [BEAM-3342] Create a Cloud Bigtable IO connector for Python

2020-06-05 Thread GitBox
aaltay commented on pull request #8457: URL: https://github.com/apache/beam/pull/8457#issuecomment-639912763 > There are still failing tests on #11295. @mf2199 - What is the next step for this PR? PIng on this? What is our plan for this PR?

[GitHub] [beam] pabloem commented on pull request #11923: [BEAM-10176] Support STRUCT, FLOAT64, INT64 BigQuery types

2020-06-05 Thread GitBox
pabloem commented on pull request #11923: URL: https://github.com/apache/beam/pull/11923#issuecomment-639911150 Run Python 3.7 PostCommit This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] pabloem commented on a change in pull request #11702: [BEAM-9990] Add Conditional Update and Conditional Create to FhirIO

2020-06-05 Thread GitBox
pabloem commented on a change in pull request #11702: URL: https://github.com/apache/beam/pull/11702#discussion_r436210077 ## File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare/FhirIO.java ## @@ -1173,4 +1276,339 @@ public void

[GitHub] [beam] lukecwik commented on pull request #11941: [BEAM-2939] Fix splittable DoFn lifecycle.

2020-06-05 Thread GitBox
lukecwik commented on pull request #11941: URL: https://github.com/apache/beam/pull/11941#issuecomment-639897770 R: @boyuanzz @youngoli This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] lukecwik opened a new pull request #11941: [BEAM-2939] Fix splittable DoFn lifecycle.

2020-06-05 Thread GitBox
lukecwik opened a new pull request #11941: URL: https://github.com/apache/beam/pull/11941 getInitialRestriction/splitAndSize should not be wrapped with startBundle/FinishBundle invocations. Instead of copying the stateAccessor initialization (used for side inputs) I made it so that it

[GitHub] [beam] pabloem commented on pull request #11824: [BEAM-10101] Add HttpIO / HttpFileSystem (Python)

2020-06-05 Thread GitBox
pabloem commented on pull request #11824: URL: https://github.com/apache/beam/pull/11824#issuecomment-639885325 @epicfaace lmk what are your plans for this PR This is an automated message from the Apache Git Service. To

[GitHub] [beam] pabloem commented on pull request #11940: [BEAM-6215] Additional tests for FlatMap label.

2020-06-05 Thread GitBox
pabloem commented on pull request #11940: URL: https://github.com/apache/beam/pull/11940#issuecomment-639884926 Run Python PreCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] pabloem commented on pull request #11929: [BEAM-10201] Add deadletter support to JsonToRow

2020-06-05 Thread GitBox
pabloem commented on pull request #11929: URL: https://github.com/apache/beam/pull/11929#issuecomment-639885056 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] pabloem commented on pull request #11923: [BEAM-10176] Support STRUCT, FLOAT64, INT64 BigQuery types

2020-06-05 Thread GitBox
pabloem commented on pull request #11923: URL: https://github.com/apache/beam/pull/11923#issuecomment-639882291 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] udim commented on a change in pull request #11939: [BEAM-10197] Support typehints for Python's frozenset

2020-06-05 Thread GitBox
udim commented on a change in pull request #11939: URL: https://github.com/apache/beam/pull/11939#discussion_r436187871 ## File path: sdks/python/apache_beam/typehints/typehints_test.py ## @@ -612,54 +613,70 @@ def test_match_type_variables(self):

[GitHub] [beam] pabloem merged pull request #11931: [BEAM-10145] Delete persistent disks after every KafkaIO performance test run

2020-06-05 Thread GitBox
pabloem merged pull request #11931: URL: https://github.com/apache/beam/pull/11931 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] apilloud commented on a change in pull request #11820: [BEAM-10093] ZetaSql Nexmark variant

2020-06-05 Thread GitBox
apilloud commented on a change in pull request #11820: URL: https://github.com/apache/beam/pull/11820#discussion_r436191652 ## File path: sdks/java/testing/nexmark/src/test/java/org/apache/beam/sdk/nexmark/queries/sql/SqlBoundedSideInputJoinTest.java ## @@ -48,166 +47,182 @@

[GitHub] [beam] udim commented on pull request #11939: [BEAM-10197] Support typehints for Python's frozenset

2020-06-05 Thread GitBox
udim commented on pull request #11939: URL: https://github.com/apache/beam/pull/11939#issuecomment-639864241 random comment to trigger tests This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] udim edited a comment on pull request #11939: [BEAM-10197] Support typehints for Python's frozenset

2020-06-05 Thread GitBox
udim edited a comment on pull request #11939: URL: https://github.com/apache/beam/pull/11939#issuecomment-639864241 arbitrary comment to trigger tests This is an automated message from the Apache Git Service. To respond to

[GitHub] [beam] amaliujia commented on a change in pull request #11868: [BEAM-9363] Support HOP and SESSION as TVF

2020-06-05 Thread GitBox
amaliujia commented on a change in pull request #11868: URL: https://github.com/apache/beam/pull/11868#discussion_r436188166 ## File path: sdks/java/extensions/sql/zetasql/src/test/java/org/apache/beam/sdk/extensions/sql/zetasql/ZetaSQLDialectSpecTest.java ## @@ -4805,6

[GitHub] [beam] boyuanzz commented on a change in pull request #11749: [BEAM-9977] Implement ReadFromKafkaViaSDF

2020-06-05 Thread GitBox
boyuanzz commented on a change in pull request #11749: URL: https://github.com/apache/beam/pull/11749#discussion_r436187245 ## File path: sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/ReadFromKafkaViaSDF.java ## @@ -0,0 +1,697 @@ +/* + * Licensed to the Apache

[GitHub] [beam] robinyqiu commented on a change in pull request #11868: [BEAM-9363] Support HOP and SESSION as TVF

2020-06-05 Thread GitBox
robinyqiu commented on a change in pull request #11868: URL: https://github.com/apache/beam/pull/11868#discussion_r436178923 ## File path: sdks/java/extensions/sql/zetasql/src/test/java/org/apache/beam/sdk/extensions/sql/zetasql/ZetaSQLDialectSpecTest.java ## @@ -4805,6

[GitHub] [beam] ibzib commented on a change in pull request #11932: [BEAM-9577] Migrate PortablePipelineJarCreator to new artifact service.

2020-06-05 Thread GitBox
ibzib commented on a change in pull request #11932: URL: https://github.com/apache/beam/pull/11932#discussion_r436178918 ## File path: runners/java-fn-execution/src/main/java/org/apache/beam/runners/fnexecution/artifact/ArtifactRetrievalService.java ## @@ -89,34 +92,41 @@

[GitHub] [beam] robertwb commented on pull request #11626: Cleanup ToString transforms.

2020-06-05 Thread GitBox
robertwb commented on pull request #11626: URL: https://github.com/apache/beam/pull/11626#issuecomment-639845882 R: @y1chi This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [beam] robertwb commented on pull request #11940: [BEAM-6215] Additional tests for FlatMap label.

2020-06-05 Thread GitBox
robertwb commented on pull request #11940: URL: https://github.com/apache/beam/pull/11940#issuecomment-639844043 R: @pabloem This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [beam] robertwb opened a new pull request #11940: [BEAM-6215] Additional tests for FlatMap label.

2020-06-05 Thread GitBox
robertwb opened a new pull request #11940: URL: https://github.com/apache/beam/pull/11940 This does not appear to be broken, but additional tests are good. Also cleaned up unneeded use of raw strings. Thank you for your contribution! Follow

[GitHub] [beam] amaliujia merged pull request #11933: [BEAM-10204] @Ignore: re-enable LIKE operator related unit tests.

2020-06-05 Thread GitBox
amaliujia merged pull request #11933: URL: https://github.com/apache/beam/pull/11933 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [beam] boyuanzz commented on a change in pull request #11749: [BEAM-9977] Implement ReadFromKafkaViaSDF

2020-06-05 Thread GitBox
boyuanzz commented on a change in pull request #11749: URL: https://github.com/apache/beam/pull/11749#discussion_r436179356 ## File path: sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaIO.java ## @@ -1055,29 +1144,6 @@ public void

[GitHub] [beam] boyuanzz commented on a change in pull request #11749: [BEAM-9977] Implement ReadFromKafkaViaSDF

2020-06-05 Thread GitBox
boyuanzz commented on a change in pull request #11749: URL: https://github.com/apache/beam/pull/11749#discussion_r436177315 ## File path: sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaIO.java ## @@ -949,45 +1077,6 @@ public void

[GitHub] [beam] kennknowles commented on a change in pull request #11924: [BEAM-8543] Dataflow streaming timers are not strictly time ordered when set earlier mid-bundle

2020-06-05 Thread GitBox
kennknowles commented on a change in pull request #11924: URL: https://github.com/apache/beam/pull/11924#discussion_r436173779 ## File path: sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/ParDoTest.java ## @@ -3938,10 +3939,11 @@ public void

[GitHub] [beam] saavan-google-intern opened a new pull request #11939: [BEAM-10197] Support typehints for Python's frozenset

2020-06-05 Thread GitBox
saavan-google-intern opened a new pull request #11939: URL: https://github.com/apache/beam/pull/11939 This PR improves Beam's parameterized type hint coverage by adding support for Python's frozenset container. Type annotations should now work with frozenset, typing.FrozenSet, and

[GitHub] [beam] saavan-google-intern commented on pull request #11939: [BEAM-10197] Support typehints for Python's frozenset

2020-06-05 Thread GitBox
saavan-google-intern commented on pull request #11939: URL: https://github.com/apache/beam/pull/11939#issuecomment-639824517 @udim This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] lukecwik merged pull request #11922: [BEAM-2939] Fix FnApiDoFnRunner to ensure that we output within the correct window when processing a splittable dofn

2020-06-05 Thread GitBox
lukecwik merged pull request #11922: URL: https://github.com/apache/beam/pull/11922 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] y1chi commented on pull request #11916: [BEAM-10189] Add ValueState user state to python sdk

2020-06-05 Thread GitBox
y1chi commented on pull request #11916: URL: https://github.com/apache/beam/pull/11916#issuecomment-639789507 > Yes, the plan was to consider changing Java too, though that's harder due to backwards compatibility issues. Renamed to ReadModifyWriteState.

[GitHub] [beam] reuvenlax commented on a change in pull request #11924: [BEAM-8543] Dataflow streaming timers are not strictly time ordered when set earlier mid-bundle

2020-06-05 Thread GitBox
reuvenlax commented on a change in pull request #11924: URL: https://github.com/apache/beam/pull/11924#discussion_r436147265 ## File path: runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/StreamingModeExecutionContext.java ## @@

[GitHub] [beam] lukecwik commented on pull request #11922: [BEAM-2939] Fix FnApiDoFnRunner to ensure that we output within the correct window when processing a splittable dofn

2020-06-05 Thread GitBox
lukecwik commented on pull request #11922: URL: https://github.com/apache/beam/pull/11922#issuecomment-639757431 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] boyuanzz commented on a change in pull request #11749: [BEAM-9977] Implement ReadFromKafkaViaSDF

2020-06-05 Thread GitBox
boyuanzz commented on a change in pull request #11749: URL: https://github.com/apache/beam/pull/11749#discussion_r436123330 ## File path: sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/ReadFromKafkaViaSDF.java ## @@ -0,0 +1,697 @@ +/* + * Licensed to the Apache

[GitHub] [beam] lostluck merged pull request #11937: [BEAM-9615] Remove LP indicator on string methods.

2020-06-05 Thread GitBox
lostluck merged pull request #11937: URL: https://github.com/apache/beam/pull/11937 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] boyuanzz commented on a change in pull request #11922: [BEAM-2939] Fix FnApiDoFnRunner to ensure that we output within the correct window when processing a splittable dofn

2020-06-05 Thread GitBox
boyuanzz commented on a change in pull request #11922: URL: https://github.com/apache/beam/pull/11922#discussion_r436116972 ## File path: sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnApiDoFnRunner.java ## @@ -577,26 +586,83 @@ public Instant timestamp(DoFn

[GitHub] [beam] robertwb opened a new pull request #11938: [BEAM-9577] Remove uses of legacy artifact service in Java.

2020-06-05 Thread GitBox
robertwb opened a new pull request #11938: URL: https://github.com/apache/beam/pull/11938 Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] [**Choose

[GitHub] [beam] lukecwik commented on a change in pull request #11922: [BEAM-2939] Fix FnApiDoFnRunner to ensure that we output within the correct window when processing a splittable dofn

2020-06-05 Thread GitBox
lukecwik commented on a change in pull request #11922: URL: https://github.com/apache/beam/pull/11922#discussion_r436113097 ## File path: sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnApiDoFnRunner.java ## @@ -296,6 +299,12 @@ public void accept(WindowedValue

[GitHub] [beam] chamikaramj merged pull request #11846: [BEAM-9869] adding self-contained Kafka service jar for testing

2020-06-05 Thread GitBox
chamikaramj merged pull request #11846: URL: https://github.com/apache/beam/pull/11846 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [beam] chamikaramj commented on pull request #11846: [BEAM-9869] adding self-contained Kafka service jar for testing

2020-06-05 Thread GitBox
chamikaramj commented on pull request #11846: URL: https://github.com/apache/beam/pull/11846#issuecomment-639725186 LGTM. Thanks. This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] lukecwik commented on a change in pull request #11922: [BEAM-2939] Fix FnApiDoFnRunner to ensure that we output within the correct window when processing a splittable dofn

2020-06-05 Thread GitBox
lukecwik commented on a change in pull request #11922: URL: https://github.com/apache/beam/pull/11922#discussion_r436112241 ## File path: sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnApiDoFnRunner.java ## @@ -941,20 +1047,59 @@ private Progress getProgress() {

[GitHub] [beam] lukecwik commented on a change in pull request #11922: [BEAM-2939] Fix FnApiDoFnRunner to ensure that we output within the correct window when processing a splittable dofn

2020-06-05 Thread GitBox
lukecwik commented on a change in pull request #11922: URL: https://github.com/apache/beam/pull/11922#discussion_r436111838 ## File path: sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnApiDoFnRunner.java ## @@ -632,6 +698,17 @@ public Object restriction() {

[GitHub] [beam] lukecwik commented on a change in pull request #11922: [BEAM-2939] Fix FnApiDoFnRunner to ensure that we output within the correct window when processing a splittable dofn

2020-06-05 Thread GitBox
lukecwik commented on a change in pull request #11922: URL: https://github.com/apache/beam/pull/11922#discussion_r43686 ## File path: sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnApiDoFnRunner.java ## @@ -577,26 +586,83 @@ public Instant timestamp(DoFn

[GitHub] [beam] lukecwik commented on a change in pull request #11922: [BEAM-2939] Fix FnApiDoFnRunner to ensure that we output within the correct window when processing a splittable dofn

2020-06-05 Thread GitBox
lukecwik commented on a change in pull request #11922: URL: https://github.com/apache/beam/pull/11922#discussion_r436111296 ## File path: sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnApiDoFnRunner.java ## @@ -577,26 +586,83 @@ public Instant timestamp(DoFn

[GitHub] [beam] lostluck commented on pull request #11937: [BEAM-9615] Remove LP indicator on string methods.

2020-06-05 Thread GitBox
lostluck commented on pull request #11937: URL: https://github.com/apache/beam/pull/11937#issuecomment-639718856 R: @tysonjh This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [beam] lostluck opened a new pull request #11937: [BEAM-9615] Remove LP indicator on string methods.

2020-06-05 Thread GitBox
lostluck opened a new pull request #11937: URL: https://github.com/apache/beam/pull/11937 Missed commit from PR 11925. Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ]

[GitHub] [beam] amaliujia commented on a change in pull request #11933: [BEAM-10204] @Ignore: re-enable LIKE operator related unit tests.

2020-06-05 Thread GitBox
amaliujia commented on a change in pull request #11933: URL: https://github.com/apache/beam/pull/11933#discussion_r436101952 ## File path: sdks/java/extensions/sql/zetasql/src/test/java/org/apache/beam/sdk/extensions/sql/zetasql/ZetaSQLDialectSpecTest.java ## @@ -837,7 +834,6

[GitHub] [beam] amaliujia commented on a change in pull request #11933: [BEAM-10204] @Ignore: re-enable LIKE operator related unit tests.

2020-06-05 Thread GitBox
amaliujia commented on a change in pull request #11933: URL: https://github.com/apache/beam/pull/11933#discussion_r436094165 ## File path: sdks/java/extensions/sql/zetasql/src/test/java/org/apache/beam/sdk/extensions/sql/zetasql/ZetaSQLDialectSpecTest.java ## @@ -837,7 +834,6

[GitHub] [beam] lostluck commented on pull request #11925: [BEAM-9615] Add string coder utility functions.

2020-06-05 Thread GitBox
lostluck commented on pull request #11925: URL: https://github.com/apache/beam/pull/11925#issuecomment-639698549 Ah dang it. I thought I had pushed the commit with the rename, but it was waiting on a password. I'll have that as another PR.

[GitHub] [beam] lostluck merged pull request #11927: [BEAM-9615] finish standardizing proto import names

2020-06-05 Thread GitBox
lostluck merged pull request #11927: URL: https://github.com/apache/beam/pull/11927 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] lostluck edited a comment on pull request #11927: [BEAM-9615] finish standardizing proto import names

2020-06-05 Thread GitBox
lostluck edited a comment on pull request #11927: URL: https://github.com/apache/beam/pull/11927#issuecomment-639695778 @lukecwik I'm 100% certain that the Java PreCommit failure here is unrelated to the change. 1. The short names are for programmer convenience and shouldn't

[GitHub] [beam] lostluck commented on pull request #11927: [BEAM-9615] finish standardizing proto import names

2020-06-05 Thread GitBox
lostluck commented on pull request #11927: URL: https://github.com/apache/beam/pull/11927#issuecomment-639695778 @lukecwik I'm 100% certain that the Java PreCommit failure here is unrelated to the change. 1. The short names are for programmer convenience and don't change the boot binary

[GitHub] [beam] boyuanzz commented on a change in pull request #11922: [BEAM-2939] Fix FnApiDoFnRunner to ensure that we output within the correct window when processing a splittable dofn

2020-06-05 Thread GitBox
boyuanzz commented on a change in pull request #11922: URL: https://github.com/apache/beam/pull/11922#discussion_r436072548 ## File path: sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnApiDoFnRunner.java ## @@ -296,6 +299,12 @@ public void accept(WindowedValue

[GitHub] [beam] amaliujia commented on a change in pull request #11933: [BEAM-10204] @Ignore: re-enable LIKE operator related unit tests.

2020-06-05 Thread GitBox
amaliujia commented on a change in pull request #11933: URL: https://github.com/apache/beam/pull/11933#discussion_r436094165 ## File path: sdks/java/extensions/sql/zetasql/src/test/java/org/apache/beam/sdk/extensions/sql/zetasql/ZetaSQLDialectSpecTest.java ## @@ -837,7 +834,6

[GitHub] [beam] lostluck commented on a change in pull request #11925: [BEAM-9615] Add string coder utility functions.

2020-06-05 Thread GitBox
lostluck commented on a change in pull request #11925: URL: https://github.com/apache/beam/pull/11925#discussion_r436095065 ## File path: sdks/go/pkg/beam/core/graph/coder/stringutf8_test.go ## @@ -0,0 +1,122 @@ +// Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [beam] lostluck merged pull request #11925: [BEAM-9615] Add string coder utility functions.

2020-06-05 Thread GitBox
lostluck merged pull request #11925: URL: https://github.com/apache/beam/pull/11925 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] robertwb commented on pull request #11932: [BEAM-9577] Migrate PortablePipelineJarCreator to new artifact service.

2020-06-05 Thread GitBox
robertwb commented on pull request #11932: URL: https://github.com/apache/beam/pull/11932#issuecomment-639691021 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] amaliujia commented on a change in pull request #11933: [BEAM-10204] @Ignore: re-enable LIKE operator related unit tests.

2020-06-05 Thread GitBox
amaliujia commented on a change in pull request #11933: URL: https://github.com/apache/beam/pull/11933#discussion_r436094165 ## File path: sdks/java/extensions/sql/zetasql/src/test/java/org/apache/beam/sdk/extensions/sql/zetasql/ZetaSQLDialectSpecTest.java ## @@ -837,7 +834,6

[GitHub] [beam] kennknowles commented on pull request #11820: [BEAM-10093] ZetaSql Nexmark variant

2020-06-05 Thread GitBox
kennknowles commented on pull request #11820: URL: https://github.com/apache/beam/pull/11820#issuecomment-639689286 PTAL. The first commit is unchanged, the second is a total rewrite (or unwrite, if you like). - Modified each `SqlQuery2`, etc, class to have just the amount of

[GitHub] [beam] tysonjh commented on a change in pull request #11925: [BEAM-9615] Add string coder utility functions.

2020-06-05 Thread GitBox
tysonjh commented on a change in pull request #11925: URL: https://github.com/apache/beam/pull/11925#discussion_r436092337 ## File path: sdks/go/pkg/beam/core/graph/coder/stringutf8_test.go ## @@ -0,0 +1,122 @@ +// Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [beam] lostluck commented on a change in pull request #11925: [BEAM-9615] Add string coder utility functions.

2020-06-05 Thread GitBox
lostluck commented on a change in pull request #11925: URL: https://github.com/apache/beam/pull/11925#discussion_r436091546 ## File path: sdks/go/pkg/beam/core/graph/coder/stringutf8_test.go ## @@ -0,0 +1,122 @@ +// Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [beam] damondouglas opened a new pull request #11936: [BEAM-9679] Add CombinePerKey to Core Transforms Go Katas

2020-06-05 Thread GitBox
damondouglas opened a new pull request #11936: URL: https://github.com/apache/beam/pull/11936 This pull requests adds a Combine/CombinePerKey lesson to the Go SDK katas. I would like to request the following reviewers: (R: @lostluck ) (R: @henryken ) If accepted by both

[GitHub] [beam] tysonjh commented on a change in pull request #11925: [BEAM-9615] Add string coder utility functions.

2020-06-05 Thread GitBox
tysonjh commented on a change in pull request #11925: URL: https://github.com/apache/beam/pull/11925#discussion_r436090874 ## File path: sdks/go/pkg/beam/core/graph/coder/stringutf8.go ## @@ -0,0 +1,83 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] [beam] lostluck commented on a change in pull request #11925: [BEAM-9615] Add string coder utility functions.

2020-06-05 Thread GitBox
lostluck commented on a change in pull request #11925: URL: https://github.com/apache/beam/pull/11925#discussion_r436090722 ## File path: sdks/go/pkg/beam/core/graph/coder/stringutf8.go ## @@ -0,0 +1,83 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] [beam] aaltay merged pull request #11882: [BEAM-10112] Add state and timer python examples to website

2020-06-05 Thread GitBox
aaltay merged pull request #11882: URL: https://github.com/apache/beam/pull/11882 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] aaltay merged pull request #11805: Add documentation for python apache-beam[aws] installation

2020-06-05 Thread GitBox
aaltay merged pull request #11805: URL: https://github.com/apache/beam/pull/11805 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] KevinGG commented on pull request #11884: [BEAM-7923] Initialize an empty Jupyter labextension with README

2020-06-05 Thread GitBox
KevinGG commented on pull request #11884: URL: https://github.com/apache/beam/pull/11884#issuecomment-639670746 > There's a lot of files there that don't seem relevant; I think we should go through and figure out what's needed for the actual plugin vs. what's "extras" that just got copied

[GitHub] [beam] lostluck commented on a change in pull request #11925: [BEAM-9615] Add string coder utility functions.

2020-06-05 Thread GitBox
lostluck commented on a change in pull request #11925: URL: https://github.com/apache/beam/pull/11925#discussion_r436076913 ## File path: sdks/go/pkg/beam/core/graph/coder/stringutf8.go ## @@ -0,0 +1,83 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] [beam] lostluck commented on a change in pull request #11925: [BEAM-9615] Add string coder utility functions.

2020-06-05 Thread GitBox
lostluck commented on a change in pull request #11925: URL: https://github.com/apache/beam/pull/11925#discussion_r436077202 ## File path: sdks/go/pkg/beam/core/graph/coder/stringutf8_test.go ## @@ -0,0 +1,122 @@ +// Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [beam] tysonjh commented on pull request #11927: [BEAM-9615] finish standardizing proto import names

2020-06-05 Thread GitBox
tysonjh commented on pull request #11927: URL: https://github.com/apache/beam/pull/11927#issuecomment-639668226 > @lukecwik There probably is, but I'm not shaving that yak today. The gradle commands don't meaningfully work for Go, and not when I'm ripping them apart in the next two months

[GitHub] [beam] TobKed commented on pull request #11877: [BEAM-10184] Build python wheels on GitHub Actions for Linux/MacOS

2020-06-05 Thread GitBox
TobKed commented on pull request #11877: URL: https://github.com/apache/beam/pull/11877#issuecomment-639667163 cc @potiuk This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [beam] lostluck commented on pull request #11927: [BEAM-9615] finish standardizing proto import names

2020-06-05 Thread GitBox
lostluck commented on pull request #11927: URL: https://github.com/apache/beam/pull/11927#issuecomment-639664788 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] amaliujia merged pull request #11934: [BEAM-10205] @Ignore:BYTES can work with UNION ALL

2020-06-05 Thread GitBox
amaliujia merged pull request #11934: URL: https://github.com/apache/beam/pull/11934 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [beam] tysonjh commented on a change in pull request #11933: [BEAM-10204] @Ignore: re-enable LIKE operator related unit tests.

2020-06-05 Thread GitBox
tysonjh commented on a change in pull request #11933: URL: https://github.com/apache/beam/pull/11933#discussion_r436071355 ## File path: sdks/java/extensions/sql/zetasql/src/test/java/org/apache/beam/sdk/extensions/sql/zetasql/ZetaSQLDialectSpecTest.java ## @@ -837,7 +834,6

[GitHub] [beam] robertwb opened a new pull request #11935: [BEAM-9577] Remove use of legacy artifact service in Python.

2020-06-05 Thread GitBox
robertwb opened a new pull request #11935: URL: https://github.com/apache/beam/pull/11935 Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] [**Choose

[GitHub] [beam] TobKed commented on a change in pull request #11877: [BEAM-10184] Build python wheels on GitHub Actions for Linux/MacOS

2020-06-05 Thread GitBox
TobKed commented on a change in pull request #11877: URL: https://github.com/apache/beam/pull/11877#discussion_r436068238 ## File path: .github/workflows/build_wheels.yml ## @@ -0,0 +1,141 @@ +name: Build python wheels + +on: + push: +branches: + - master + -

[GitHub] [beam] TobKed commented on a change in pull request #11877: [BEAM-10184] Build python wheels on GitHub Actions for Linux/MacOS

2020-06-05 Thread GitBox
TobKed commented on a change in pull request #11877: URL: https://github.com/apache/beam/pull/11877#discussion_r436068604 ## File path: .github/workflows/build_wheels.yml ## @@ -0,0 +1,141 @@ +name: Build python wheels + +on: + push: +branches: + - master + -

[GitHub] [beam] TobKed commented on a change in pull request #11877: [BEAM-10184] Build python wheels on GitHub Actions for Linux/MacOS

2020-06-05 Thread GitBox
TobKed commented on a change in pull request #11877: URL: https://github.com/apache/beam/pull/11877#discussion_r436068410 ## File path: .github/workflows/build_wheels.yml ## @@ -0,0 +1,141 @@ +name: Build python wheels + +on: + push: +branches: + - master + -

[GitHub] [beam] tysonjh commented on a change in pull request #11925: [BEAM-9615] Add string coder utility functions.

2020-06-05 Thread GitBox
tysonjh commented on a change in pull request #11925: URL: https://github.com/apache/beam/pull/11925#discussion_r436016818 ## File path: sdks/go/pkg/beam/core/graph/coder/stringutf8.go ## @@ -0,0 +1,83 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] [beam] boyuanzz commented on a change in pull request #11894: [BEAM-7074] Enable test_pardo_timers_clear for fn_runner

2020-06-05 Thread GitBox
boyuanzz commented on a change in pull request #11894: URL: https://github.com/apache/beam/pull/11894#discussion_r436068037 ## File path: sdks/python/apache_beam/runners/portability/fn_api_runner/fn_runner_test.py ## @@ -377,11 +377,6 @@ def process_timer(

[GitHub] [beam] TobKed commented on a change in pull request #11877: [BEAM-10184] Build python wheels on GitHub Actions for Linux/MacOS

2020-06-05 Thread GitBox
TobKed commented on a change in pull request #11877: URL: https://github.com/apache/beam/pull/11877#discussion_r436067638 ## File path: .github/workflows/build_wheels.yml ## @@ -0,0 +1,141 @@ +name: Build python wheels + +on: + push: +branches: + - master + -

[GitHub] [beam] amaliujia commented on pull request #11933: [BEAM-10204] @Ignore: re-enable LIKE operator related unit tests.

2020-06-05 Thread GitBox
amaliujia commented on pull request #11933: URL: https://github.com/apache/beam/pull/11933#issuecomment-639656091 Run SQL PreCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] amaliujia opened a new pull request #11934: [BEAM-10205] @Ignore:BYTES can work with UNION ALL

2020-06-05 Thread GitBox
amaliujia opened a new pull request #11934: URL: https://github.com/apache/beam/pull/11934 See: https://jira.apache.org/jira/browse/BEAM-10205 Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and

[GitHub] [beam] amaliujia opened a new pull request #11933: [BEAM-10204] @Ignore: re-enable LIKE operator related unit tests.

2020-06-05 Thread GitBox
amaliujia opened a new pull request #11933: URL: https://github.com/apache/beam/pull/11933 See https://issues.apache.org/jira/browse/BEAM-10204 Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly

[GitHub] [beam] apilloud merged pull request #11758: Old Fastjson has a serious security problem

2020-06-05 Thread GitBox
apilloud merged pull request #11758: URL: https://github.com/apache/beam/pull/11758 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] lostluck merged pull request #11926: [BEAM-9615] Additional coder unit tests

2020-06-05 Thread GitBox
lostluck merged pull request #11926: URL: https://github.com/apache/beam/pull/11926 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] lostluck commented on a change in pull request #11926: [BEAM-9615] Additional coder unit tests

2020-06-05 Thread GitBox
lostluck commented on a change in pull request #11926: URL: https://github.com/apache/beam/pull/11926#discussion_r436032240 ## File path: sdks/go/pkg/beam/coder_test.go ## @@ -63,3 +64,57 @@ func TestJSONCoder(t *testing.T) { } } } + +func TestCoders(t

[GitHub] [beam] robertwb merged pull request #11835: Various fixes to allow Java PAssert to run on Python

2020-06-05 Thread GitBox
robertwb merged pull request #11835: URL: https://github.com/apache/beam/pull/11835 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] robertwb merged pull request #11766: [BEAM-10036] More flexible dataframes partitioning.

2020-06-05 Thread GitBox
robertwb merged pull request #11766: URL: https://github.com/apache/beam/pull/11766 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] robertwb commented on pull request #11932: [BEAM-9577] Migrate PortablePipelineJarCreator to new artifact service.

2020-06-05 Thread GitBox
robertwb commented on pull request #11932: URL: https://github.com/apache/beam/pull/11932#issuecomment-639605068 R: @ibzib This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [beam] robertwb opened a new pull request #11932: [BEAM-9577] Migrate PortablePipelineJarCreator to new artifact service.

2020-06-05 Thread GitBox
robertwb opened a new pull request #11932: URL: https://github.com/apache/beam/pull/11932 Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] [**Choose

[GitHub] [beam] lostluck commented on pull request #11883: [BEAM-9679] Add CombineFn to Core Transforms

2020-06-05 Thread GitBox
lostluck commented on pull request #11883: URL: https://github.com/apache/beam/pull/11883#issuecomment-639594805 Thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on to

  1   2   >