[GitHub] [beam] lostluck commented on pull request #12045: [BEAM-9615] Generate Go Schema Protos

lostluck commented on pull request #12045: URL: https://github.com/apache/beam/pull/12045#issuecomment-646944278 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [beam] lostluck opened a new pull request #12045: [BEAM-9615] Generate Go Schema Protos

lostluck opened a new pull request #12045: URL: https://github.com/apache/beam/pull/12045 Update the Go SDK protos, in particular, include the schema protos in them. Thank you for your contribution! Follow this checklist to help us incorporate your

[GitHub] [beam] dpcollins-google commented on a change in pull request #11919: [BEAM-10114] Copy Pub/Sub Lite IO from Pub/Sub Lite github to beam.

dpcollins-google commented on a change in pull request #11919: URL: https://github.com/apache/beam/pull/11919#discussion_r443099695 ## File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsublite/CloudPubsubTransforms.java ## @@ -0,0 +1,95

[GitHub] [beam] dpcollins-google commented on a change in pull request #11919: [BEAM-10114] Copy Pub/Sub Lite IO from Pub/Sub Lite github to beam.

dpcollins-google commented on a change in pull request #11919: URL: https://github.com/apache/beam/pull/11919#discussion_r443098880 ## File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsublite/CloudPubsubTransforms.java ## @@ -0,0 +1,95

[GitHub] [beam] dpcollins-google commented on a change in pull request #11919: [BEAM-10114] Copy Pub/Sub Lite IO from Pub/Sub Lite github to beam.

dpcollins-google commented on a change in pull request #11919: URL: https://github.com/apache/beam/pull/11919#discussion_r443098835 ## File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsublite/CloudPubsubTransforms.java ## @@ -0,0 +1,95

[GitHub] [beam] dpcollins-google commented on a change in pull request #11919: [BEAM-10114] Copy Pub/Sub Lite IO from Pub/Sub Lite github to beam.

dpcollins-google commented on a change in pull request #11919: URL: https://github.com/apache/beam/pull/11919#discussion_r443097807 ## File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsublite/PubsubLiteIO.java ## @@ -0,0 +1,75 @@ +/* +

[GitHub] [beam] dpcollins-google commented on a change in pull request #11919: [BEAM-10114] Copy Pub/Sub Lite IO from Pub/Sub Lite github to beam.

dpcollins-google commented on a change in pull request #11919: URL: https://github.com/apache/beam/pull/11919#discussion_r443097299 ## File path: buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy ## @@ -555,6 +557,8 @@ class BeamModulePlugin implements

[GitHub] [beam] stale[bot] commented on pull request #11447: [BEAM-9502] makes Schema UUID generation deterministic

stale[bot] commented on pull request #11447: URL: https://github.com/apache/beam/pull/11447#issuecomment-646930775 This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull

[GitHub] [beam] apilloud commented on pull request #12036: [BEAM-10267] ZetaSQLCalc makes grpc call per row

apilloud commented on pull request #12036: URL: https://github.com/apache/beam/pull/12036#issuecomment-646927728 Perf numbers are in the PR description (this is 4.2x as fast on Nexmark Query 0), the biggest improvement here is that column count is no longer a factor in execution time.

[GitHub] [beam] chamikaramj commented on pull request #11911: [BEAM-10186] Sends an empty response to the runner instead of failing

chamikaramj commented on pull request #11911: URL: https://github.com/apache/beam/pull/11911#issuecomment-646920188 Thanks. PTAL. This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] chamikaramj commented on a change in pull request #11911: [BEAM-10186] Sends an empty response to the runner instead of failing

chamikaramj commented on a change in pull request #11911: URL: https://github.com/apache/beam/pull/11911#discussion_r443091935 ## File path: sdks/java/harness/src/main/java/org/apache/beam/fn/harness/control/BeamFnControlClient.java ## @@ -159,6 +159,16 @@ public void

[GitHub] [beam] ananvay commented on pull request #12044: [BEAM-9707] Remove hardcoded unified harness image

ananvay commented on pull request #12044: URL: https://github.com/apache/beam/pull/12044#issuecomment-646919961 lgtm. Thanks Ankur! This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] angoenka commented on pull request #12044: [BEAM-9707] Remove hardcoded unified harness image

angoenka commented on pull request #12044: URL: https://github.com/apache/beam/pull/12044#issuecomment-646919594 R: @ananvay @robertwb This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] angoenka opened a new pull request #12044: [BEAM-9707] Remove hardcoded unified harness image

angoenka opened a new pull request #12044: URL: https://github.com/apache/beam/pull/12044 **Please** add a meaningful description for your change here Thank you for your contribution! Follow this checklist to help us incorporate your contribution

[GitHub] [beam] robinyqiu merged pull request #12036: [BEAM-10267] ZetaSQLCalc makes grpc call per row

robinyqiu merged pull request #12036: URL: https://github.com/apache/beam/pull/12036 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [beam] dpcollins-google commented on a change in pull request #11919: [BEAM-10114] Copy Pub/Sub Lite IO from Pub/Sub Lite github to beam.

dpcollins-google commented on a change in pull request #11919: URL: https://github.com/apache/beam/pull/11919#discussion_r443085465 ## File path: sdks/java/build-tools/src/main/resources/beam/suppressions.xml ## @@ -88,6 +88,10 @@ + + + + Review comment:

[GitHub] [beam] y1chi commented on pull request #11916: [BEAM-10189] Add ReadModifyWriteState user state to python sdk

y1chi commented on pull request #11916: URL: https://github.com/apache/beam/pull/11916#issuecomment-646900931 @mxm Seems like flink runner is sending cache token per state, instead of one user state token per bundle. This will cause python sdk to fail

[GitHub] [beam] y1chi edited a comment on pull request #11916: [BEAM-10189] Add ReadModifyWriteState user state to python sdk

y1chi edited a comment on pull request #11916: URL: https://github.com/apache/beam/pull/11916#issuecomment-646900931 @mxm Seems like flink runner is sending cache token per state, instead of one user state token per bundle. This will cause python sdk to fail

[GitHub] [beam] udim commented on a change in pull request #12009: [BEAM-10258] Support type hint annotations on PTransform's expand()

udim commented on a change in pull request #12009: URL: https://github.com/apache/beam/pull/12009#discussion_r443073000 ## File path: sdks/python/apache_beam/pvalue.py ## @@ -158,6 +158,10 @@ def __ne__(self, other): def __hash__(self): return hash((self.tag,

[GitHub] [beam] udim commented on a change in pull request #12009: [BEAM-10258] Support type hint annotations on PTransform's expand()

udim commented on a change in pull request #12009: URL: https://github.com/apache/beam/pull/12009#discussion_r443069576 ## File path: sdks/python/apache_beam/pvalue.py ## @@ -425,8 +441,7 @@ def _from_runtime_iterable(it, options): def _view_options(self): return { -

[GitHub] [beam] apilloud commented on pull request #12036: [BEAM-10267] ZetaSQLCalc makes grpc call per row

apilloud commented on pull request #12036: URL: https://github.com/apache/beam/pull/12036#issuecomment-646883845 R: @robinyqiu This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [beam] tvalentyn merged pull request #12043: Update Dataflow Python container to 20200619

tvalentyn merged pull request #12043: URL: https://github.com/apache/beam/pull/12043 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [beam] udim commented on a change in pull request #12030: [BEAM-10270] Disable Pardo test with 200 iterations on Flink

udim commented on a change in pull request #12030: URL: https://github.com/apache/beam/pull/12030#discussion_r443060500 ## File path: .test-infra/jenkins/job_LoadTests_ParDo_Flink_Python.groovy ## @@ -79,29 +79,31 @@ def batchScenarios = { datasetName -> [

[GitHub] [beam] udim commented on a change in pull request #12030: [BEAM-10270] Disable Pardo test with 200 iterations on Flink

udim commented on a change in pull request #12030: URL: https://github.com/apache/beam/pull/12030#discussion_r443060213 ## File path: .test-infra/jenkins/job_LoadTests_ParDo_Flink_Python.groovy ## @@ -79,29 +79,31 @@ def batchScenarios = { datasetName -> [

[GitHub] [beam] lukecwik commented on a change in pull request #11749: [BEAM-9977] Implement ReadFromKafkaViaSDF

lukecwik commented on a change in pull request #11749: URL: https://github.com/apache/beam/pull/11749#discussion_r443059352 ## File path: sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/ReadViaSDF.java ## @@ -0,0 +1,742 @@ +/* + * Licensed to the Apache Software

[GitHub] [beam] lukecwik commented on a change in pull request #11749: [BEAM-9977] Implement ReadFromKafkaViaSDF

lukecwik commented on a change in pull request #11749: URL: https://github.com/apache/beam/pull/11749#discussion_r443059453 ## File path: sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/ReadViaSDF.java ## @@ -0,0 +1,742 @@ +/* + * Licensed to the Apache Software

[GitHub] [beam] boyuanzz merged pull request #11894: [BEAM-7074] Enable test_pardo_timers_clear for fn_runner

boyuanzz merged pull request #11894: URL: https://github.com/apache/beam/pull/11894 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] boyuanzz commented on pull request #11894: [BEAM-7074] Enable test_pardo_timers_clear for fn_runner

boyuanzz commented on pull request #11894: URL: https://github.com/apache/beam/pull/11894#issuecomment-646874614 I'm going to merge this PR since the code that was requested to change has been removed. This is an automated

[GitHub] [beam] boyuanzz commented on a change in pull request #11749: [BEAM-9977] Implement ReadFromKafkaViaSDF

boyuanzz commented on a change in pull request #11749: URL: https://github.com/apache/beam/pull/11749#discussion_r443052453 ## File path: sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/ReadViaSDF.java ## @@ -0,0 +1,742 @@ +/* + * Licensed to the Apache Software

[GitHub] [beam] lukecwik commented on a change in pull request #11919: [BEAM-10114] Copy Pub/Sub Lite IO from Pub/Sub Lite github to beam.

lukecwik commented on a change in pull request #11919: URL: https://github.com/apache/beam/pull/11919#discussion_r443052486 ## File path: sdks/java/build-tools/src/main/resources/beam/suppressions.xml ## @@ -88,6 +88,10 @@ + + + + Review comment: I

[GitHub] [beam] ajamato commented on a change in pull request #12043: Update Dataflow Python container to 20200619

ajamato commented on a change in pull request #12043: URL: https://github.com/apache/beam/pull/12043#discussion_r443051892 ## File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIO.java ## @@ -705,7 +705,7 @@ public Read

[GitHub] [beam] lukecwik commented on a change in pull request #11919: [BEAM-10114] Copy Pub/Sub Lite IO from Pub/Sub Lite github to beam.

lukecwik commented on a change in pull request #11919: URL: https://github.com/apache/beam/pull/11919#discussion_r443051440 ## File path: buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy ## @@ -480,6 +479,7 @@ class BeamModulePlugin implements Plugin {

[GitHub] [beam] dpcollins-google commented on a change in pull request #11919: [BEAM-10114] Copy Pub/Sub Lite IO from Pub/Sub Lite github to beam.

dpcollins-google commented on a change in pull request #11919: URL: https://github.com/apache/beam/pull/11919#discussion_r443050936 ## File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsublite/UuidDeduplicationTransform.java ## @@ -0,0

[GitHub] [beam] dpcollins-google commented on a change in pull request #11919: [BEAM-10114] Copy Pub/Sub Lite IO from Pub/Sub Lite github to beam.

dpcollins-google commented on a change in pull request #11919: URL: https://github.com/apache/beam/pull/11919#discussion_r443050763 ## File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsublite/UuidDeduplicationTransform.java ## @@ -0,0

[GitHub] [beam] dpcollins-google commented on a change in pull request #11919: [BEAM-10114] Copy Pub/Sub Lite IO from Pub/Sub Lite github to beam.

dpcollins-google commented on a change in pull request #11919: URL: https://github.com/apache/beam/pull/11919#discussion_r443050342 ## File path: sdks/java/build-tools/src/main/resources/beam/suppressions.xml ## @@ -88,6 +88,10 @@ + + + + Review comment:

[GitHub] [beam] tvalentyn commented on a change in pull request #12043: Update Dataflow Python container to 20200619

tvalentyn commented on a change in pull request #12043: URL: https://github.com/apache/beam/pull/12043#discussion_r443050063 ## File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIO.java ## @@ -705,7 +705,7 @@ public Read

[GitHub] [beam] tvalentyn commented on a change in pull request #12043: Update Dataflow Python container to 20200619

tvalentyn commented on a change in pull request #12043: URL: https://github.com/apache/beam/pull/12043#discussion_r443050063 ## File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIO.java ## @@ -705,7 +705,7 @@ public Read

[GitHub] [beam] lukecwik commented on a change in pull request #11919: [BEAM-10114] Copy Pub/Sub Lite IO from Pub/Sub Lite github to beam.

lukecwik commented on a change in pull request #11919: URL: https://github.com/apache/beam/pull/11919#discussion_r443049962 ## File path: buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy ## @@ -555,6 +557,8 @@ class BeamModulePlugin implements Plugin {

[GitHub] [beam] lukecwik commented on a change in pull request #11919: [BEAM-10114] Copy Pub/Sub Lite IO from Pub/Sub Lite github to beam.

lukecwik commented on a change in pull request #11919: URL: https://github.com/apache/beam/pull/11919#discussion_r443049730 ## File path: sdks/java/build-tools/src/main/resources/beam/suppressions.xml ## @@ -88,6 +88,10 @@ + + + + Review comment:

[GitHub] [beam] ajamato commented on pull request #12043: Update Dataflow Python container to 20200619

ajamato commented on pull request #12043: URL: https://github.com/apache/beam/pull/12043#issuecomment-646865658 R: @tvalentyn R: @aaltay This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] ajamato opened a new pull request #12043: Update Dataflow Python container to 20200619

ajamato opened a new pull request #12043: URL: https://github.com/apache/beam/pull/12043 Update Dataflow Python container to 20200619 Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily

[GitHub] [beam] lukecwik commented on a change in pull request #11919: [BEAM-10114] Copy Pub/Sub Lite IO from Pub/Sub Lite github to beam.

lukecwik commented on a change in pull request #11919: URL: https://github.com/apache/beam/pull/11919#discussion_r443048811 ## File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsublite/PubsubLiteIO.java ## @@ -0,0 +1,75 @@ +/* + *

[GitHub] [beam] JustineKoa opened a new pull request #12042: WIP: Jenkins Plugin

JustineKoa opened a new pull request #12042: URL: https://github.com/apache/beam/pull/12042 Currently able to get configurations from user: Java or Python, Gradle (show added build task) or Maven Working on: - testing python, maven, gradle commands work - getting google

[GitHub] [beam] boyuanzz commented on a change in pull request #11749: [BEAM-9977] Implement ReadFromKafkaViaSDF

boyuanzz commented on a change in pull request #11749: URL: https://github.com/apache/beam/pull/11749#discussion_r443040694 ## File path: sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/ReadViaSDF.java ## @@ -0,0 +1,742 @@ +/* + * Licensed to the Apache Software

[GitHub] [beam] dpmills commented on a change in pull request #11919: [BEAM-10114] Copy Pub/Sub Lite IO from Pub/Sub Lite github to beam.

dpmills commented on a change in pull request #11919: URL: https://github.com/apache/beam/pull/11919#discussion_r442969497 ## File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsublite/PubsubLiteIO.java ## @@ -0,0 +1,75 @@ +/* + *

[GitHub] [beam] chamikaramj commented on a change in pull request #12004: Enabling custom retry strategy for BQ streaming inserts.

chamikaramj commented on a change in pull request #12004: URL: https://github.com/apache/beam/pull/12004#discussion_r443023182 ## File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/InsertRetryPolicy.java ## @@ -33,7 +33,7 @@ */

[GitHub] [beam] aaltay commented on pull request #11877: [BEAM-10184] Build python wheels on GitHub Actions for Linux/MacOS

aaltay commented on pull request #11877: URL: https://github.com/apache/beam/pull/11877#issuecomment-646834753 @TobKed - please ping me if this is ready to be merged. This is an automated message from the Apache Git Service.

[GitHub] [beam] aaltay commented on pull request #10165: [BEAM-7390] Add code snippet for GroupIntoBatches

aaltay commented on pull request #10165: URL: https://github.com/apache/beam/pull/10165#issuecomment-646833472 Tests passed, merging this. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] aaltay merged pull request #10165: [BEAM-7390] Add code snippet for GroupIntoBatches

aaltay merged pull request #10165: URL: https://github.com/apache/beam/pull/10165 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] TheNeuralBit commented on a change in pull request #11981: [BEAM-8364] SchemaCoder is not consistent with equals

TheNeuralBit commented on a change in pull request #11981: URL: https://github.com/apache/beam/pull/11981#discussion_r442993899 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/SchemaCoder.java ## @@ -140,7 +140,14 @@ private void

[GitHub] [beam] davidcavazos commented on pull request #10165: [BEAM-7390] Add code snippet for GroupIntoBatches

davidcavazos commented on pull request #10165: URL: https://github.com/apache/beam/pull/10165#issuecomment-646809970 I have no idea, there are a bunch of unrelated errors like `ERROR:apache_beam.runners.worker.data_plane:Failed to read inputs in the data plane.`, as well as some errors

[GitHub] [beam] apilloud commented on pull request #12041: [BEAM-10286] Fix race in direct runner

apilloud commented on pull request #12041: URL: https://github.com/apache/beam/pull/12041#issuecomment-646802830 R: @lukecwik This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [beam] apilloud opened a new pull request #12041: [BEAM-10286] Fix race in direct runner

apilloud opened a new pull request #12041: URL: https://github.com/apache/beam/pull/12041 There is a race between checking `visibleUpdates` and `pipelineState` that leads to updates being dropped. This fixes that race. Thank you for your contribution!

[GitHub] [beam] boyuanzz commented on a change in pull request #11749: [BEAM-9977] Implement ReadFromKafkaViaSDF

boyuanzz commented on a change in pull request #11749: URL: https://github.com/apache/beam/pull/11749#discussion_r442980355 ## File path: sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/ReadViaSDF.java ## @@ -0,0 +1,742 @@ +/* + * Licensed to the Apache Software

[GitHub] [beam] chamikaramj merged pull request #11930: [BEAM-10202] make cross-language testing scripts OSX-compatible

chamikaramj merged pull request #11930: URL: https://github.com/apache/beam/pull/11930 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [beam] ibzib opened a new pull request #12040: Revert "Fix state handler for missing service descriptor."

ibzib opened a new pull request #12040: URL: https://github.com/apache/beam/pull/12040 This reverts commit e7833d64df6576cb3105a455db78b219dbd4dfef. Commit e7833d64df6576cb3105a455db78b219dbd4dfef broke internal Dataflow tests. R: @lukecwik cc: @ajamato

[GitHub] [beam] chamikaramj commented on pull request #12004: Enabling custom retry strategy for BQ streaming inserts.

chamikaramj commented on pull request #12004: URL: https://github.com/apache/beam/pull/12004#issuecomment-646794277 LGTM. Probably also add related documentation and unit tests (if not available) since seems like we are enabling a feature here.

[GitHub] [beam] KevinGG commented on a change in pull request #11884: [BEAM-7923] Initialize an empty Jupyter labextension with README

KevinGG commented on a change in pull request #11884: URL: https://github.com/apache/beam/pull/11884#discussion_r442967243 ## File path: sdks/python/apache_beam/runners/interactive/extensions/interactive_beam_side_panel/tsconfig.json ## @@ -0,0 +1,24 @@ +{ Review comment:

[GitHub] [beam] lukecwik commented on a change in pull request #11911: [BEAM-10186] Send an error to the runner for certain split and progress failures

lukecwik commented on a change in pull request #11911: URL: https://github.com/apache/beam/pull/11911#discussion_r442969768 ## File path: sdks/java/harness/src/main/java/org/apache/beam/fn/harness/control/BeamFnControlClient.java ## @@ -159,6 +159,16 @@ public void

[GitHub] [beam] lukecwik commented on a change in pull request #11911: [BEAM-10186] Send an error to the runner for certain split and progress failures

lukecwik commented on a change in pull request #11911: URL: https://github.com/apache/beam/pull/11911#discussion_r442969338 ## File path: sdks/java/harness/src/main/java/org/apache/beam/fn/harness/control/BeamFnControlClient.java ## @@ -159,6 +159,16 @@ public void

[GitHub] [beam] dpmills commented on a change in pull request #11919: [BEAM-10114] Copy Pub/Sub Lite IO from Pub/Sub Lite github to beam.

dpmills commented on a change in pull request #11919: URL: https://github.com/apache/beam/pull/11919#discussion_r442969230 ## File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsublite/PubsubLiteIO.java ## @@ -0,0 +1,75 @@ +/* + *

[GitHub] [beam] KevinGG commented on a change in pull request #11884: [BEAM-7923] Initialize an empty Jupyter labextension with README

KevinGG commented on a change in pull request #11884: URL: https://github.com/apache/beam/pull/11884#discussion_r442968583 ## File path: sdks/python/apache_beam/runners/interactive/extensions/interactive_beam_side_panel/package.json ## @@ -0,0 +1,75 @@ +{ + "name":

[GitHub] [beam] reuvenlax commented on a change in pull request #11981: [BEAM-8364] SchemaCoder is not consistent with equals

reuvenlax commented on a change in pull request #11981: URL: https://github.com/apache/beam/pull/11981#discussion_r442966866 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/SchemaCoder.java ## @@ -140,7 +140,14 @@ private void verifyDeterministic(Schema

[GitHub] [beam] KevinGG commented on a change in pull request #11884: [BEAM-7923] Initialize an empty Jupyter labextension with README

KevinGG commented on a change in pull request #11884: URL: https://github.com/apache/beam/pull/11884#discussion_r442967243 ## File path: sdks/python/apache_beam/runners/interactive/extensions/interactive_beam_side_panel/tsconfig.json ## @@ -0,0 +1,24 @@ +{ Review comment:

[GitHub] [beam] lukecwik commented on a change in pull request #11749: [BEAM-9977] Implement ReadFromKafkaViaSDF

lukecwik commented on a change in pull request #11749: URL: https://github.com/apache/beam/pull/11749#discussion_r442966047 ## File path: sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/ReadViaSDF.java ## @@ -0,0 +1,742 @@ +/* + * Licensed to the Apache Software

[GitHub] [beam] lukecwik commented on a change in pull request #11749: [BEAM-9977] Implement ReadFromKafkaViaSDF

lukecwik commented on a change in pull request #11749: URL: https://github.com/apache/beam/pull/11749#discussion_r442963985 ## File path: sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/ReadViaSDF.java ## @@ -0,0 +1,742 @@ +/* + * Licensed to the Apache Software

[GitHub] [beam] lukecwik commented on a change in pull request #11749: [BEAM-9977] Implement ReadFromKafkaViaSDF

lukecwik commented on a change in pull request #11749: URL: https://github.com/apache/beam/pull/11749#discussion_r442962378 ## File path: sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/ReadViaSDF.java ## @@ -0,0 +1,742 @@ +/* + * Licensed to the Apache Software

[GitHub] [beam] lukecwik commented on a change in pull request #11749: [BEAM-9977] Implement ReadFromKafkaViaSDF

lukecwik commented on a change in pull request #11749: URL: https://github.com/apache/beam/pull/11749#discussion_r442962149 ## File path: sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/ReadViaSDF.java ## @@ -0,0 +1,742 @@ +/* + * Licensed to the Apache Software

[GitHub] [beam] KevinGG commented on a change in pull request #11884: [BEAM-7923] Initialize an empty Jupyter labextension with README

KevinGG commented on a change in pull request #11884: URL: https://github.com/apache/beam/pull/11884#discussion_r442961235 ## File path: sdks/python/apache_beam/runners/interactive/extensions/interactive_beam_side_panel/src/index.ts ## @@ -0,0 +1,41 @@ +// Licensed under the

[GitHub] [beam] KevinGG commented on a change in pull request #11884: [BEAM-7923] Initialize an empty Jupyter labextension with README

KevinGG commented on a change in pull request #11884: URL: https://github.com/apache/beam/pull/11884#discussion_r442960390 ## File path: sdks/python/apache_beam/runners/interactive/extensions/interactive_beam_side_panel/setup.py ## @@ -0,0 +1,104 @@ +# Licensed to the Apache

[GitHub] [beam] tysonjh commented on pull request #12001: [BEAM-10082] Remove dependency on java.xml.ws.

tysonjh commented on pull request #12001: URL: https://github.com/apache/beam/pull/12001#issuecomment-646766782 > LGTM! Thanks for the changes, that's perfect. Last thing to do is clean review comments: can you squash the first 2 commits and leave only the comment about dependency. The

[GitHub] [beam] lukecwik commented on a change in pull request #11749: [BEAM-9977] Implement ReadFromKafkaViaSDF

lukecwik commented on a change in pull request #11749: URL: https://github.com/apache/beam/pull/11749#discussion_r442957543 ## File path: sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/ReadViaSDF.java ## @@ -0,0 +1,742 @@ +/* + * Licensed to the Apache Software

[GitHub] [beam] boyuanzz commented on a change in pull request #11749: [BEAM-9977] Implement ReadFromKafkaViaSDF

boyuanzz commented on a change in pull request #11749: URL: https://github.com/apache/beam/pull/11749#discussion_r442951203 ## File path: sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaIO.java ## @@ -681,11 +696,13 @@ public void

[GitHub] [beam] KevinGG commented on a change in pull request #11884: [BEAM-7923] Initialize an empty Jupyter labextension with README

KevinGG commented on a change in pull request #11884: URL: https://github.com/apache/beam/pull/11884#discussion_r442950980 ## File path: sdks/python/apache_beam/runners/interactive/extensions/interactive_beam_side_panel/interactive_beam_side_panel/_version.py ## @@ -0,0 +1,18

[GitHub] [beam] KevinGG commented on a change in pull request #11884: [BEAM-7923] Initialize an empty Jupyter labextension with README

KevinGG commented on a change in pull request #11884: URL: https://github.com/apache/beam/pull/11884#discussion_r442950171 ## File path: sdks/python/apache_beam/runners/interactive/extensions/interactive_beam_side_panel/README.md ## @@ -0,0 +1,111 @@ + + +#

[GitHub] [beam] KevinGG commented on a change in pull request #11884: [BEAM-7923] Initialize an empty Jupyter labextension with README

KevinGG commented on a change in pull request #11884: URL: https://github.com/apache/beam/pull/11884#discussion_r442944084 ## File path: sdks/python/apache_beam/runners/interactive/extensions/interactive_beam_side_panel/.prettierignore ## @@ -0,0 +1,20 @@ +#Licensed to

[GitHub] [beam] KevinGG commented on a change in pull request #11884: [BEAM-7923] Initialize an empty Jupyter labextension with README

KevinGG commented on a change in pull request #11884: URL: https://github.com/apache/beam/pull/11884#discussion_r442944084 ## File path: sdks/python/apache_beam/runners/interactive/extensions/interactive_beam_side_panel/.prettierignore ## @@ -0,0 +1,20 @@ +#Licensed to

[GitHub] [beam] KevinGG commented on a change in pull request #11884: [BEAM-7923] Initialize an empty Jupyter labextension with README

KevinGG commented on a change in pull request #11884: URL: https://github.com/apache/beam/pull/11884#discussion_r442943235 ## File path: sdks/python/apache_beam/runners/interactive/extensions/interactive_beam_side_panel/.github/workflows/build.yml ## @@ -0,0 +1,38 @@ +name:

[GitHub] [beam] TheNeuralBit merged pull request #12033: [BEAM-10276] Replace `grpc._channel._Rendezvous` with `grpc.RpcError`

TheNeuralBit merged pull request #12033: URL: https://github.com/apache/beam/pull/12033 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [beam] boyuanzz commented on pull request #11894: [BEAM-7074] Enable test_pardo_timers_clear for fn_runner

boyuanzz commented on pull request #11894: URL: https://github.com/apache/beam/pull/11894#issuecomment-646725769 Run Python PreCommit This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] pabloem commented on pull request #12031: Update Beam Katas Built-in IOs to get the Kotlin Katas featured

pabloem commented on pull request #12031: URL: https://github.com/apache/beam/pull/12031#issuecomment-646719957 Thanks @henryken ! This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] pabloem merged pull request #12031: Update Beam Katas Built-in IOs to get the Kotlin Katas featured

pabloem merged pull request #12031: URL: https://github.com/apache/beam/pull/12031 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] y1chi commented on pull request #11916: [BEAM-10189] Add ReadModifyWriteState user state to python sdk

y1chi commented on pull request #11916: URL: https://github.com/apache/beam/pull/11916#issuecomment-646701032 Run Python2_PVR_Flink PreCommit This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] TheNeuralBit commented on pull request #12033: [BEAM-10276] Replace `grpc._channel._Rendezvous` with `grpc.RpcError`

TheNeuralBit commented on pull request #12033: URL: https://github.com/apache/beam/pull/12033#issuecomment-646684235 Run Python PreCommit This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] kamilwu commented on pull request #12038: [BEAM-5853] Trigger autodeploy on commit ID and image tag mismatch

kamilwu commented on pull request #12038: URL: https://github.com/apache/beam/pull/12038#issuecomment-646656748 Run Beam Metrics deployment This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] kamilwu commented on pull request #12039: [BEAM-10258] Add tempRoot to jobs using TestDataflowRunner

kamilwu commented on pull request #12039: URL: https://github.com/apache/beam/pull/12039#issuecomment-646655629 I think this makes sense. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] mwalenia commented on pull request #12039: [BEAM-10258] Add tempRoot to jobs using TestDataflowRunner

mwalenia commented on pull request #12039: URL: https://github.com/apache/beam/pull/12039#issuecomment-646653144 What do you think about adding `TEST_DATAFLOW_RUNNER` as an option to the enum in `CommonTestProperties`? This

[GitHub] [beam] kamilwu commented on pull request #12039: [BEAM-10258] Add tempRoot to jobs using TestDataflowRunner

kamilwu commented on pull request #12039: URL: https://github.com/apache/beam/pull/12039#issuecomment-646649115 This will most probably break PubsubIO test. The test requires `TestDataflowRunner`, because matchers does not work with regular `DataflowRunner`.

[GitHub] [beam] kamilwu edited a comment on pull request #12039: [BEAM-10258] Add tempRoot to jobs using TestDataflowRunner

kamilwu edited a comment on pull request #12039: URL: https://github.com/apache/beam/pull/12039#issuecomment-646649115 This will most probably break PubsubIO test. The test requires `TestDataflowRunner`, because matchers do not work with regular `DataflowRunner`.

[GitHub] [beam] mwalenia commented on pull request #12039: [BEAM-10258] Add tempRoot to jobs using TestDataflowRunner

mwalenia commented on pull request #12039: URL: https://github.com/apache/beam/pull/12039#issuecomment-646638743 R: @kamilwu This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [beam] mwalenia commented on pull request #12039: [BEAM-10258] Add tempRoot to jobs using TestDataflowRunner

mwalenia commented on pull request #12039: URL: https://github.com/apache/beam/pull/12039#issuecomment-646638336 Run PubsubIO Performance Test Python This is an automated message from the Apache Git Service. To respond to

[GitHub] [beam] mwalenia commented on pull request #12039: [BEAM-10258] Add tempRoot to jobs using TestDataflowRunner

mwalenia commented on pull request #12039: URL: https://github.com/apache/beam/pull/12039#issuecomment-646633822 Run Load Tests Java GBK Dataflow Batch This is an automated message from the Apache Git Service. To respond to

[GitHub] [beam] mwalenia commented on pull request #12039: [BEAM-10258] Add tempRoot to jobs using TestDataflowRunner

mwalenia commented on pull request #12039: URL: https://github.com/apache/beam/pull/12039#issuecomment-646633098 run seed job This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [beam] mwalenia commented on pull request #12039: [BEAM-10258] Add tempRoot to jobs using TestDataflowRunner

mwalenia commented on pull request #12039: URL: https://github.com/apache/beam/pull/12039#issuecomment-646629659 Run Load Tests Java ParDo Dataflow Batch This is an automated message from the Apache Git Service. To respond

[GitHub] [beam] mwalenia commented on pull request #12039: [BEAM-10258] Add tempRoot to jobs using TestDataflowRunner

mwalenia commented on pull request #12039: URL: https://github.com/apache/beam/pull/12039#issuecomment-646629369 Run Load Tests Java GBK Dataflow Batch This is an automated message from the Apache Git Service. To respond to

[GitHub] [beam] mwalenia commented on pull request #12039: [BEAM-10258] Add tempRoot to jobs using TestDataflowRunner

mwalenia commented on pull request #12039: URL: https://github.com/apache/beam/pull/12039#issuecomment-646628600 run seed job This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [beam] mwalenia opened a new pull request #12039: [BEAM-10258] Add tempRoot to jobs using TestDataflowRunner

mwalenia opened a new pull request #12039: URL: https://github.com/apache/beam/pull/12039 Some other PR changed the runner used for Dataflow-based load tests and as a result, the jobs started failing. This adds a required parameter to the tasks and makes the tests run correctly.

[GitHub] [beam] mwalenia commented on pull request #12039: [BEAM-10258] Add tempRoot to jobs using TestDataflowRunner

mwalenia commented on pull request #12039: URL: https://github.com/apache/beam/pull/12039#issuecomment-646627367 run seed job This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [beam] kamilwu removed a comment on pull request #11956: [BEAM-8133] Publishing results of Nexmark tests to InfluxDB

kamilwu removed a comment on pull request #11956: URL: https://github.com/apache/beam/pull/11956#issuecomment-646611882 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [beam] kamilwu commented on pull request #11956: [BEAM-8133] Publishing results of Nexmark tests to InfluxDB

kamilwu commented on pull request #11956: URL: https://github.com/apache/beam/pull/11956#issuecomment-646613924 Run Load Tests Java ParDo SparkStructuredStreaming Batch This is an automated message from the Apache Git

  1   2   >