[GitHub] [beam] ibzib commented on pull request #11755: [BEAM-10038] Add script to mass-comment Jenkins triggers on PR

2020-05-21 Thread GitBox


ibzib commented on pull request #11755:
URL: https://github.com/apache/beam/pull/11755#issuecomment-632405988


   > Yes we probably need those jenkins uber jobs (Flink too). Other use case 
where this script proves really handy would be users asking committers to 
trigger tests, maybe worth to announce it in the ML. Of course this is not its 
intended goal but realistically a more useful one until we have our own jenkins 
instances. Maybe we can improve it to make that task easier WDYT?
   
   What kind of improvements do you have in mind? It's going to be a little bit 
of work for the user no matter what to specify the list of jobs, so the script 
is only going to be useful when there are many jobs (as is the case with the 
release) or if they needed to be run very often for some reason (which is not 
common).



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [beam] ibzib commented on pull request #11755: [BEAM-10038] Add script to mass-comment Jenkins triggers on PR

2020-05-20 Thread GitBox


ibzib commented on pull request #11755:
URL: https://github.com/apache/beam/pull/11755#issuecomment-631781814


   > > This looks pretty neat. We could maybe specialize this for some 
particular common cases. I found myself many times requiring to run something 
like "Run All Spark Runners ValidatesRunner Tests" WDYT @ibzib ?
   > 
   > If you want to use it as-is, all you have to do is modify the 
`COMMENTS_TO_ADD`.
   
   Actually, for that use case, maybe it would be better to make a single 
Jenkins uber-job that runs all the Spark test suites we have.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [beam] ibzib commented on pull request #11755: [BEAM-10038] Add script to mass-comment Jenkins triggers on PR

2020-05-20 Thread GitBox


ibzib commented on pull request #11755:
URL: https://github.com/apache/beam/pull/11755#issuecomment-631766935


   > This looks pretty neat. We could maybe specialize this for some particular 
common cases. I found myself many times requiring to run something like "Run 
All Spark Runners ValidatesRunner Tests" WDYT @ibzib ?
   
   If you want to use it as-is, all you have to do is modify the 
`COMMENTS_TO_ADD`.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org