[GitHub] [beam] reuvenlax commented on a change in pull request #11456: [BEAM-7554] Add MillisInstant logical type to replace DATETIME

2020-05-21 Thread GitBox
reuvenlax commented on a change in pull request #11456: URL: https://github.com/apache/beam/pull/11456#discussion_r428901750 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/logicaltypes/MillisInstant.java ## @@ -0,0 +1,44 @@ +/* + * Licensed to the

[GitHub] [beam] reuvenlax commented on a change in pull request #11456: [BEAM-7554] Add MillisInstant logical type to replace DATETIME

2020-05-01 Thread GitBox
reuvenlax commented on a change in pull request #11456: URL: https://github.com/apache/beam/pull/11456#discussion_r418443258 ## File path: sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamAggregationRel.java ## @@ -257,10 +257,8 @@