robinyqiu commented on pull request #11272:
URL: https://github.com/apache/beam/pull/11272#issuecomment-632331823
> are there any tests that use the DATE Type in an aggregation (e.g. MAX)?
No. Thanks for bringing this up. I think it is likely to run into the
problem.
robinyqiu commented on pull request #11272:
URL: https://github.com/apache/beam/pull/11272#issuecomment-629420575
Java PreCommit failed due to a build failure. Please help run again.
This is an automated message from the
robinyqiu commented on pull request #11272:
URL: https://github.com/apache/beam/pull/11272#issuecomment-628914752
Rebased against master. Please run precommit tests again.
This is an automated message from the Apache Git
robinyqiu commented on pull request #11272:
URL: https://github.com/apache/beam/pull/11272#issuecomment-624894351
The failing test `SparkPortableExecutionTest.testExecution` should be
unrelated to this change.
This is an
robinyqiu commented on pull request #11272:
URL: https://github.com/apache/beam/pull/11272#issuecomment-624452448
Could you help trigger the tests again?
For the comment on range: Thanks for pointing it out. I overlooked this
problem. I would like to create a separate PR to address
robinyqiu commented on pull request #11272:
URL: https://github.com/apache/beam/pull/11272#issuecomment-624451644
Ah, just realized that the previous comments were not sent out.
This is an automated message from the Apache
robinyqiu commented on pull request #11272:
URL: https://github.com/apache/beam/pull/11272#issuecomment-620739925
> What do you think about going ahead and defining the date logical type in
`org.apache.beam.sdk.schemas.logicaltypes`? It would be useful in other
contexts - for example it
