[GitHub] [beam] DariuszAniszewski commented on pull request #11360: [BEAM-9722] added SnowflakeIO with Read operation

2020-05-21 Thread GitBox
DariuszAniszewski commented on pull request #11360: URL: https://github.com/apache/beam/pull/11360#issuecomment-632019864 Just a small comment about the force-push from above - it was mistakenly done, then reverted. HEAD of this branch is still on **3ba192a** and comment is a leftover.

[GitHub] [beam] DariuszAniszewski commented on pull request #11360: [BEAM-9722] added SnowflakeIO with Read operation

2020-05-20 Thread GitBox
DariuszAniszewski commented on pull request #11360: URL: https://github.com/apache/beam/pull/11360#issuecomment-631670549 Thanks! I'm OK with squash-and-merge - it was intended to go as single commit This is an automated

[GitHub] [beam] DariuszAniszewski commented on pull request #11360: [BEAM-9722] added SnowflakeIO with Read operation

2020-05-19 Thread GitBox
DariuszAniszewski commented on pull request #11360: URL: https://github.com/apache/beam/pull/11360#issuecomment-631062751 @chamikaramj All done, PTAL ;) This is an automated message from the Apache Git Service. To respond

[GitHub] [beam] DariuszAniszewski commented on pull request #11360: [BEAM-9722] added SnowflakeIO with Read operation

2020-05-14 Thread GitBox
DariuszAniszewski commented on pull request #11360: URL: https://github.com/apache/beam/pull/11360#issuecomment-628581369 @chamikaramj Thanks for review. We've applied some of them already and answered/commented to rest of them - can you please have another look on this PR?

[GitHub] [beam] DariuszAniszewski commented on pull request #11360: [BEAM-9722] added SnowflakeIO with Read operation

2020-05-06 Thread GitBox
DariuszAniszewski commented on pull request #11360: URL: https://github.com/apache/beam/pull/11360#issuecomment-624686375 @aromanenko-dev @lukecwik thanks again for the review. We've applied the changes and all your comments/questions are addressed: either changed or answered. Can

[GitHub] [beam] DariuszAniszewski commented on pull request #11360: [BEAM-9722] added SnowflakeIO with Read operation

2020-04-27 Thread GitBox
DariuszAniszewski commented on pull request #11360: URL: https://github.com/apache/beam/pull/11360#issuecomment-619894735 I'm dealing with some private issues this week and I'll be unavailable. @kkucharc and @purbanow will continue working on this PR

[GitHub] [beam] DariuszAniszewski commented on pull request #11360: [BEAM-9722] added SnowflakeIO with Read operation

2020-04-26 Thread GitBox
DariuszAniszewski commented on pull request #11360: URL: https://github.com/apache/beam/pull/11360#issuecomment-619575399 Thanks @aromanenko-dev and @lukecwik for review. I rebased onto (current) master and applied simplest changes already - I'll be back in a few days with rest of