[GitHub] [beam] aaltay commented on pull request #11682: [BEAM-9946] | added new api in Partition Transform

2020-05-29 Thread GitBox
aaltay commented on pull request #11682: URL: https://github.com/apache/beam/pull/11682#issuecomment-636255719 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [beam] aaltay commented on pull request #11682: [BEAM-9946] | added new api in Partition Transform

2020-05-29 Thread GitBox
aaltay commented on pull request #11682: URL: https://github.com/apache/beam/pull/11682#issuecomment-636255355 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [beam] aaltay commented on pull request #11682: [BEAM-9946] | added new api in Partition Transform

2020-05-29 Thread GitBox
aaltay commented on pull request #11682: URL: https://github.com/apache/beam/pull/11682#issuecomment-636198268 Java_Examples_Dataflow_Java11 PreCommit This is an automated message from the Apache Git Service. To respond to

[GitHub] [beam] aaltay commented on pull request #11682: [BEAM-9946] | added new api in Partition Transform

2020-05-28 Thread GitBox
aaltay commented on pull request #11682: URL: https://github.com/apache/beam/pull/11682#issuecomment-635668922 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] aaltay commented on pull request #11682: [BEAM-9946] | added new api in Partition Transform

2020-05-27 Thread GitBox
aaltay commented on pull request #11682: URL: https://github.com/apache/beam/pull/11682#issuecomment-634786238 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] aaltay commented on pull request #11682: [BEAM-9946] | added new api in Partition Transform

2020-05-27 Thread GitBox
aaltay commented on pull request #11682: URL: https://github.com/apache/beam/pull/11682#issuecomment-634785955 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] aaltay commented on pull request #11682: [BEAM-9946] | added new api in Partition Transform

2020-05-26 Thread GitBox
aaltay commented on pull request #11682: URL: https://github.com/apache/beam/pull/11682#issuecomment-634434904 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] aaltay commented on pull request #11682: [BEAM-9946] | added new api in Partition Transform

2020-05-21 Thread GitBox
aaltay commented on pull request #11682: URL: https://github.com/apache/beam/pull/11682#issuecomment-632361896 Java precommit failed in the last 2 runs. Could you look at the logs? Is it related to this change? This is an

[GitHub] [beam] aaltay commented on pull request #11682: [BEAM-9946] | added new api in Partition Transform

2020-05-21 Thread GitBox
aaltay commented on pull request #11682: URL: https://github.com/apache/beam/pull/11682#issuecomment-632313262 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] aaltay commented on pull request #11682: [BEAM-9946] | added new api in Partition Transform

2020-05-21 Thread GitBox
aaltay commented on pull request #11682: URL: https://github.com/apache/beam/pull/11682#issuecomment-632313052 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] aaltay commented on pull request #11682: [BEAM-9946] | added new api in Partition Transform

2020-05-20 Thread GitBox
aaltay commented on pull request #11682: URL: https://github.com/apache/beam/pull/11682#issuecomment-631853304 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] aaltay commented on pull request #11682: [BEAM-9946] | added new api in Partition Transform

2020-05-19 Thread GitBox
aaltay commented on pull request #11682: URL: https://github.com/apache/beam/pull/11682#issuecomment-631053957 R: @apilloud for the java review. @kennknowles might not have time for this review. This is an automated

[GitHub] [beam] aaltay commented on pull request #11682: [BEAM-9946] | added new api in Partition Transform

2020-05-14 Thread GitBox
aaltay commented on pull request #11682: URL: https://github.com/apache/beam/pull/11682#issuecomment-628880635 This LGTM and well written. I will trigger the tests. Added @kennknowles in case I am missing something related to the java apis.