[GitHub] [beam] amaliujia commented on pull request #11610: [BEAM-9825] | Implement Intersect,Union,Except transforms

2020-06-01 Thread GitBox
amaliujia commented on pull request #11610: URL: https://github.com/apache/beam/pull/11610#issuecomment-637255904 This really becomes a big contribution at the end! Thanks @darshanj! This is an automated message from the

[GitHub] [beam] amaliujia commented on pull request #11610: [BEAM-9825] | Implement Intersect,Union,Except transforms

2020-06-01 Thread GitBox
amaliujia commented on pull request #11610: URL: https://github.com/apache/beam/pull/11610#issuecomment-637255622 From what I can tell, comments are addressed properly already. So merging this PR. This is an automated

[GitHub] [beam] amaliujia commented on pull request #11610: [BEAM-9825] | Implement Intersect,Union,Except transforms

2020-05-30 Thread GitBox
amaliujia commented on pull request #11610: URL: https://github.com/apache/beam/pull/11610#issuecomment-636422659 @aaltay I have approved this PR. But will still wait a bit to see if @lukecwik or @robertwb has more comments.

[GitHub] [beam] amaliujia commented on pull request #11610: [BEAM-9825] | Implement Intersect,Union,Except transforms

2020-05-21 Thread GitBox
amaliujia commented on pull request #11610: URL: https://github.com/apache/beam/pull/11610#issuecomment-632377843 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] amaliujia commented on pull request #11610: [BEAM-9825] | Implement Intersect,Union,Except transforms

2020-05-21 Thread GitBox
amaliujia commented on pull request #11610: URL: https://github.com/apache/beam/pull/11610#issuecomment-632249853 Tests retriggered. And it becomes a really big PR :-) Nice work! This is an automated message from the

[GitHub] [beam] amaliujia commented on pull request #11610: [BEAM-9825] | Implement Intersect,Union,Except transforms

2020-05-21 Thread GitBox
amaliujia commented on pull request #11610: URL: https://github.com/apache/beam/pull/11610#issuecomment-632249476 run Java Precommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] amaliujia commented on pull request #11610: [BEAM-9825] | Implement Intersect,Union,Except transforms

2020-05-21 Thread GitBox
amaliujia commented on pull request #11610: URL: https://github.com/apache/beam/pull/11610#issuecomment-632248973 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] amaliujia commented on pull request #11610: [BEAM-9825] | Implement Intersect,Union,Except transforms

2020-05-15 Thread GitBox
amaliujia commented on pull request #11610: URL: https://github.com/apache/beam/pull/11610#issuecomment-629468556 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] amaliujia commented on pull request #11610: [BEAM-9825] | Implement Intersect,Union,Except transforms

2020-05-14 Thread GitBox
amaliujia commented on pull request #11610: URL: https://github.com/apache/beam/pull/11610#issuecomment-628883607 Thank you! The Jira looks good to me! Will merge this PR tomorrow if there is no other comments. This

[GitHub] [beam] amaliujia commented on pull request #11610: [BEAM-9825] | Implement Intersect,Union,Except transforms

2020-05-06 Thread GitBox
amaliujia commented on pull request #11610: URL: https://github.com/apache/beam/pull/11610#issuecomment-624927719 You can run `./gradlew $module:check` to run all checks, include unit testing and style check. This is an

[GitHub] [beam] amaliujia commented on pull request #11610: [BEAM-9825] | Implement Intersect,Union,Except transforms

2020-05-06 Thread GitBox
amaliujia commented on pull request #11610: URL: https://github.com/apache/beam/pull/11610#issuecomment-624889206 > > Thanks! > > In terms of naming, I found it surprising that union (for example) does deduplication. Maybe name them distinctUnion and multisetUnion or something like

[GitHub] [beam] amaliujia commented on pull request #11610: [BEAM-9825] | Implement Intersect,Union,Except transforms

2020-05-06 Thread GitBox
amaliujia commented on pull request #11610: URL: https://github.com/apache/beam/pull/11610#issuecomment-624880686 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] amaliujia commented on pull request #11610: [BEAM-9825] | Implement Intersect,Union,Except transforms

2020-05-05 Thread GitBox
amaliujia commented on pull request #11610: URL: https://github.com/apache/beam/pull/11610#issuecomment-624199945 @darshanj You can run `./gradlew spotlessApply` to fix checkstyle issues. You need to run `./gradlew ${module}:check` command to not only run tests but also run

[GitHub] [beam] amaliujia commented on pull request #11610: [BEAM-9825] | Implement Intersect,Union,Except transforms

2020-05-05 Thread GitBox
amaliujia commented on pull request #11610: URL: https://github.com/apache/beam/pull/11610#issuecomment-624199252 cc @Mark-Zeng to make sure I tagged the right person. This is an automated message from the Apache Git

[GitHub] [beam] amaliujia commented on pull request #11610: [BEAM-9825] | Implement Intersect,Union,Except transforms

2020-05-05 Thread GitBox
amaliujia commented on pull request #11610: URL: https://github.com/apache/beam/pull/11610#issuecomment-624196073 R: @amaliujia cc: @jhnmora000 @MarkZeng1998 (expose more PRs to GSoC students) This is an automated