[GitHub] [beam] apilloud commented on pull request #11272: [BEAM-9641] Support ZetaSQL DATE type as a Beam LogicalType

2020-05-21 Thread GitBox
apilloud commented on pull request #11272: URL: https://github.com/apache/beam/pull/11272#issuecomment-632330703 Interesting question. You should probably add a test for JOIN as well, which will have a similar class of problems.

[GitHub] [beam] apilloud commented on pull request #11272: [BEAM-9641] Support ZetaSQL DATE type as a Beam LogicalType

2020-05-14 Thread GitBox
apilloud commented on pull request #11272: URL: https://github.com/apache/beam/pull/11272#issuecomment-628945312 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] apilloud commented on pull request #11272: [BEAM-9641] Support ZetaSQL DATE type as a Beam LogicalType

2020-05-14 Thread GitBox
apilloud commented on pull request #11272: URL: https://github.com/apache/beam/pull/11272#issuecomment-628921575 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] apilloud commented on pull request #11272: [BEAM-9641] Support ZetaSQL DATE type as a Beam LogicalType

2020-05-07 Thread GitBox
apilloud commented on pull request #11272: URL: https://github.com/apache/beam/pull/11272#issuecomment-625396106 Run SQL Postcommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] apilloud commented on pull request #11272: [BEAM-9641] Support ZetaSQL DATE type as a Beam LogicalType

2020-05-07 Thread GitBox
apilloud commented on pull request #11272: URL: https://github.com/apache/beam/pull/11272#issuecomment-625395912 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] apilloud commented on pull request #11272: [BEAM-9641] Support ZetaSQL DATE type as a Beam LogicalType

2020-05-06 Thread GitBox
apilloud commented on pull request #11272: URL: https://github.com/apache/beam/pull/11272#issuecomment-624759427 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] apilloud commented on pull request #11272: [BEAM-9641] Support ZetaSQL DATE type as a Beam LogicalType

2020-04-30 Thread GitBox
apilloud commented on pull request #11272: URL: https://github.com/apache/beam/pull/11272#issuecomment-622055322 Oops, forgot to include in my comments: ZetaSQL's range is much smaller than the underlying type, can you add a test or two for that? How do out of range values fail? (Also