[GitHub] [beam] boyuanzz commented on a change in pull request #12419: [BEAM-10303] Handle split when truncate observes windows.

2020-08-26 Thread GitBox
boyuanzz commented on a change in pull request #12419: URL: https://github.com/apache/beam/pull/12419#discussion_r477618562 ## File path: sdks/java/harness/src/main/java/org/apache/beam/fn/harness/HandlesSplits.java ## @@ -35,6 +36,12 @@ /** Returns the current progress of

[GitHub] [beam] boyuanzz commented on a change in pull request #12419: [BEAM-10303] Handle split when truncate observes windows.

2020-08-26 Thread GitBox
boyuanzz commented on a change in pull request #12419: URL: https://github.com/apache/beam/pull/12419#discussion_r477554671 ## File path: sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnApiDoFnRunner.java ## @@ -1080,136 +1121,484 @@ private static Progress scaleP

[GitHub] [beam] boyuanzz commented on a change in pull request #12419: [BEAM-10303] Handle split when truncate observes windows.

2020-08-26 Thread GitBox
boyuanzz commented on a change in pull request #12419: URL: https://github.com/apache/beam/pull/12419#discussion_r477498287 ## File path: sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnApiDoFnRunner.java ## @@ -1080,136 +1121,484 @@ private static Progress scaleP

[GitHub] [beam] boyuanzz commented on a change in pull request #12419: [BEAM-10303] Handle split when truncate observes windows.

2020-08-26 Thread GitBox
boyuanzz commented on a change in pull request #12419: URL: https://github.com/apache/beam/pull/12419#discussion_r477462448 ## File path: sdks/java/harness/src/main/java/org/apache/beam/fn/harness/HandlesSplits.java ## @@ -35,6 +36,12 @@ /** Returns the current progress of

[GitHub] [beam] boyuanzz commented on a change in pull request #12419: [BEAM-10303] Handle split when truncate observes windows.

2020-08-26 Thread GitBox
boyuanzz commented on a change in pull request #12419: URL: https://github.com/apache/beam/pull/12419#discussion_r477460982 ## File path: sdks/java/harness/src/test/java/org/apache/beam/fn/harness/FnApiDoFnRunnerTest.java ## @@ -133, +138,4337 @@ import org.apache.beam.ve

[GitHub] [beam] boyuanzz commented on a change in pull request #12419: [BEAM-10303] Handle split when truncate observes windows.

2020-08-25 Thread GitBox
boyuanzz commented on a change in pull request #12419: URL: https://github.com/apache/beam/pull/12419#discussion_r476125331 ## File path: sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnApiDoFnRunner.java ## @@ -1035,6 +1046,130 @@ private Progress getProgress() {

[GitHub] [beam] boyuanzz commented on a change in pull request #12419: [BEAM-10303] Handle split when truncate observes windows.

2020-08-24 Thread GitBox
boyuanzz commented on a change in pull request #12419: URL: https://github.com/apache/beam/pull/12419#discussion_r476125331 ## File path: sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnApiDoFnRunner.java ## @@ -1035,6 +1046,130 @@ private Progress getProgress() {

[GitHub] [beam] boyuanzz commented on a change in pull request #12419: [BEAM-10303] Handle split when truncate observes windows.

2020-08-03 Thread GitBox
boyuanzz commented on a change in pull request #12419: URL: https://github.com/apache/beam/pull/12419#discussion_r464700690 ## File path: sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnApiDoFnRunner.java ## @@ -1035,6 +1046,130 @@ private Progress getProgress() {

[GitHub] [beam] boyuanzz commented on a change in pull request #12419: [BEAM-10303] Handle split when truncate observes windows.

2020-08-03 Thread GitBox
boyuanzz commented on a change in pull request #12419: URL: https://github.com/apache/beam/pull/12419#discussion_r464697946 ## File path: sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnApiDoFnRunner.java ## @@ -1035,6 +1046,130 @@ private Progress getProgress() {

[GitHub] [beam] boyuanzz commented on a change in pull request #12419: [BEAM-10303] Handle split when truncate observes windows.

2020-08-03 Thread GitBox
boyuanzz commented on a change in pull request #12419: URL: https://github.com/apache/beam/pull/12419#discussion_r464686872 ## File path: sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnApiDoFnRunner.java ## @@ -1035,6 +1046,130 @@ private Progress getProgress() {