[GitHub] [beam] chamikaramj commented on pull request #12423: [BEAM-10135][BEAM-10136] Refactor jdbc external transform registrar

2020-08-10 Thread GitBox
chamikaramj commented on pull request #12423: URL: https://github.com/apache/beam/pull/12423#issuecomment-671416413 Was there an error ? Could you file a JIRA ? This is an automated message from the Apache Git Service. To

[GitHub] [beam] chamikaramj commented on pull request #12423: [BEAM-10135][BEAM-10136] Refactor jdbc external transform registrar

2020-08-06 Thread GitBox
chamikaramj commented on pull request #12423: URL: https://github.com/apache/beam/pull/12423#issuecomment-670157940 We can merge this. BTW I'm curious, have you tested the jdbc.py against Dataflow ? If not can you try that ? Instructions for running x-lang wrappers against

[GitHub] [beam] chamikaramj commented on pull request #12423: [BEAM-10135][BEAM-10136] Refactor jdbc external transform registrar

2020-07-31 Thread GitBox
chamikaramj commented on pull request #12423: URL: https://github.com/apache/beam/pull/12423#issuecomment-667303832 "During writing kinesis for cross-language it was suggested to emplace all classes connected to cross-language in one file" I think Java generally recommends keeping