[GitHub] [beam] damondouglas commented on pull request #11883: [BEAM-9679] Add CombineFn to Core Transforms

2020-06-04 Thread GitBox
damondouglas commented on pull request #11883: URL: https://github.com/apache/beam/pull/11883#issuecomment-639255195 @lostluck and @henryken I updated the [stepik course](https://stepik.org/course/70387) and commited the updated `*-remote.yaml` files to this PR. It is ready to merge.

[GitHub] [beam] damondouglas commented on pull request #11883: [BEAM-9679] Add CombineFn to Core Transforms

2020-06-04 Thread GitBox
damondouglas commented on pull request #11883: URL: https://github.com/apache/beam/pull/11883#issuecomment-638992758 I've incorporated all the helpful comments. I'll wait for Henry's final approval before updating stepik/committing `*-remote.yaml` files. Thank you, both.

[GitHub] [beam] damondouglas commented on pull request #11883: [BEAM-9679] Add CombineFn to Core Transforms

2020-06-04 Thread GitBox
damondouglas commented on pull request #11883: URL: https://github.com/apache/beam/pull/11883#issuecomment-63849 Thank you, @henryken for you recent comments. I have not yet updated stepik. If this meets your approval, I will update the course and commit the `*-remote.yaml` files to

[GitHub] [beam] damondouglas commented on pull request #11883: [BEAM-9679] Add CombineFn to Core Transforms

2020-06-03 Thread GitBox
damondouglas commented on pull request #11883: URL: https://github.com/apache/beam/pull/11883#issuecomment-638488229 @lostluck I was waiting on @henryken approval. Should I just go ahead and update stepik and commit the `*-remote.yaml` to this PR?