[GitHub] [beam] darshanj commented on a change in pull request #11682: [BEAM-9946] | added new api in Partition Transform

2020-05-20 Thread GitBox
darshanj commented on a change in pull request #11682: URL: https://github.com/apache/beam/pull/11682#discussion_r428399929 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Partition.java ## @@ -124,21 +190,26 @@ private Partition(PartitionDoFn partiti

[GitHub] [beam] darshanj commented on a change in pull request #11682: [BEAM-9946] | added new api in Partition Transform

2020-05-20 Thread GitBox
darshanj commented on a change in pull request #11682: URL: https://github.com/apache/beam/pull/11682#discussion_r428399738 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Partition.java ## @@ -124,21 +190,26 @@ private Partition(PartitionDoFn partiti

[GitHub] [beam] darshanj commented on a change in pull request #11682: [BEAM-9946] | added new api in Partition Transform

2020-05-20 Thread GitBox
darshanj commented on a change in pull request #11682: URL: https://github.com/apache/beam/pull/11682#discussion_r428399634 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Partition.java ## @@ -85,7 +141,14 @@ * @throws IllegalArgumentException if

[GitHub] [beam] darshanj commented on a change in pull request #11682: [BEAM-9946] | added new api in Partition Transform

2020-05-20 Thread GitBox
darshanj commented on a change in pull request #11682: URL: https://github.com/apache/beam/pull/11682#discussion_r428399671 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Partition.java ## @@ -76,6 +93,45 @@ int partitionFor(T elem, int numParti

[GitHub] [beam] darshanj commented on a change in pull request #11682: [BEAM-9946] | added new api in Partition Transform

2020-05-20 Thread GitBox
darshanj commented on a change in pull request #11682: URL: https://github.com/apache/beam/pull/11682#discussion_r428399770 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Partition.java ## @@ -124,21 +190,26 @@ private Partition(PartitionDoFn partiti