[GitHub] [beam] henryken commented on a change in pull request #11883: [BEAM-9679] Add CombineFn to Core Transforms

2020-06-04 Thread GitBox
henryken commented on a change in pull request #11883: URL: https://github.com/apache/beam/pull/11883#discussion_r435393888 ## File path: learning/katas/go/Core Transforms/Combine/CombineFn/pkg/task/task.go ## @@ -47,9 +47,9 @@ func (c *averageFn) MergeAccumulators(accumA, accu

[GitHub] [beam] henryken commented on a change in pull request #11883: [BEAM-9679] Add CombineFn to Core Transforms

2020-06-04 Thread GitBox
henryken commented on a change in pull request #11883: URL: https://github.com/apache/beam/pull/11883#discussion_r435317881 ## File path: learning/katas/go/Core Transforms/Combine/CombineFn/pkg/task/task.go ## @@ -47,9 +47,9 @@ func (c *averageFn) MergeAccumulators(accumA, accu

[GitHub] [beam] henryken commented on a change in pull request #11883: [BEAM-9679] Add CombineFn to Core Transforms

2020-06-04 Thread GitBox
henryken commented on a change in pull request #11883: URL: https://github.com/apache/beam/pull/11883#discussion_r435314757 ## File path: learning/katas/go/Core Transforms/Combine/CombineFn/pkg/task/task.go ## @@ -0,0 +1,55 @@ +// Licensed to the Apache Software Foundation (ASF

[GitHub] [beam] henryken commented on a change in pull request #11883: [BEAM-9679] Add CombineFn to Core Transforms

2020-06-03 Thread GitBox
henryken commented on a change in pull request #11883: URL: https://github.com/apache/beam/pull/11883#discussion_r434997866 ## File path: learning/katas/go/Core Transforms/Combine/CombineFn/pkg/task/task.go ## @@ -0,0 +1,55 @@ +// Licensed to the Apache Software Foundation (ASF