[GitHub] [beam] ihji commented on pull request #11771: [BEAM-10052] check hash and avoid duplicated artifacts

2020-05-21 Thread GitBox 


ihji commented on pull request #11771:
URL: https://github.com/apache/beam/pull/11771#issuecomment-632251342


   > WDYT about [ihji#1](https://github.com/ihji/beam/pull/1) ?
   > (only change is to Environments.java other changes should go away if you 
rebase)
   
   It will add 36 characters + the length of file name. Is there any concern 
about the maximum length of GCS object name? I think it's okay if GCS allows 
enough space in object names.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [beam] ihji commented on pull request #11771: [BEAM-10052] check hash and avoid duplicated artifacts

2020-05-21 Thread GitBox 


ihji commented on pull request #11771:
URL: https://github.com/apache/beam/pull/11771#issuecomment-631950394


   R: @chamikaramj 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org