[GitHub] [beam] lukecwik commented on a change in pull request #12419: [BEAM-10303] Handle split when truncate observes windows.

2020-08-26 Thread GitBox
lukecwik commented on a change in pull request #12419: URL: https://github.com/apache/beam/pull/12419#discussion_r477506877 ## File path: sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnApiDoFnRunner.java ## @@ -1080,136 +1121,484 @@ private static Progress

[GitHub] [beam] lukecwik commented on a change in pull request #12419: [BEAM-10303] Handle split when truncate observes windows.

2020-08-26 Thread GitBox
lukecwik commented on a change in pull request #12419: URL: https://github.com/apache/beam/pull/12419#discussion_r477472322 ## File path: sdks/java/harness/src/main/java/org/apache/beam/fn/harness/HandlesSplits.java ## @@ -35,6 +36,12 @@ /** Returns the current progress of

[GitHub] [beam] lukecwik commented on a change in pull request #12419: [BEAM-10303] Handle split when truncate observes windows.

2020-08-26 Thread GitBox
lukecwik commented on a change in pull request #12419: URL: https://github.com/apache/beam/pull/12419#discussion_r477470639 ## File path: sdks/java/harness/src/test/java/org/apache/beam/fn/harness/FnApiDoFnRunnerTest.java ## @@ -133, +138,4337 @@ import

[GitHub] [beam] lukecwik commented on a change in pull request #12419: [BEAM-10303] Handle split when truncate observes windows.

2020-08-25 Thread GitBox
lukecwik commented on a change in pull request #12419: URL: https://github.com/apache/beam/pull/12419#discussion_r477022288 ## File path: sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnApiDoFnRunner.java ## @@ -1237,8 +1639,10 @@ public Object restriction() {

[GitHub] [beam] lukecwik commented on a change in pull request #12419: [BEAM-10303] Handle split when truncate observes windows.

2020-08-03 Thread GitBox
lukecwik commented on a change in pull request #12419: URL: https://github.com/apache/beam/pull/12419#discussion_r464699645 ## File path: sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnApiDoFnRunner.java ## @@ -1193,6 +1328,7 @@ public Object restriction() {

[GitHub] [beam] lukecwik commented on a change in pull request #12419: [BEAM-10303] Handle split when truncate observes windows.

2020-08-03 Thread GitBox
lukecwik commented on a change in pull request #12419: URL: https://github.com/apache/beam/pull/12419#discussion_r464699501 ## File path: sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnApiDoFnRunner.java ## @@ -1035,6 +1046,130 @@ private Progress getProgress()

[GitHub] [beam] lukecwik commented on a change in pull request #12419: [BEAM-10303] Handle split when truncate observes windows.

2020-08-03 Thread GitBox
lukecwik commented on a change in pull request #12419: URL: https://github.com/apache/beam/pull/12419#discussion_r464699157 ## File path: sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnApiDoFnRunner.java ## @@ -1035,6 +1046,130 @@ private Progress getProgress()

[GitHub] [beam] lukecwik commented on a change in pull request #12419: [BEAM-10303] Handle split when truncate observes windows.

2020-08-03 Thread GitBox
lukecwik commented on a change in pull request #12419: URL: https://github.com/apache/beam/pull/12419#discussion_r464651698 ## File path: sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnApiDoFnRunner.java ## @@ -515,15 +515,18 @@ &&