[GitHub] [beam] mwalenia commented on pull request #12453: [BEAM-9421] Add Java snippets to NLP documentation.

2020-08-06 Thread GitBox
mwalenia commented on pull request #12453: URL: https://github.com/apache/beam/pull/12453#issuecomment-669763023 > Snippet tests are not meant to be integration tests, but more like a way to check that snippets are still executable over time. Anything we can test without actually making a

[GitHub] [beam] mwalenia commented on pull request #12453: [BEAM-9421] Add Java snippets to NLP documentation.

2020-08-05 Thread GitBox
mwalenia commented on pull request #12453: URL: https://github.com/apache/beam/pull/12453#issuecomment-669024432 @aaltay I think testing this would increase test time and introduce risk of flakes - the cloud language analysis results aren't very reliable (since the ML model underneath can

[GitHub] [beam] mwalenia commented on pull request #12453: [BEAM-9421] Add Java snippets to NLP documentation.

2020-08-04 Thread GitBox
mwalenia commented on pull request #12453: URL: https://github.com/apache/beam/pull/12453#issuecomment-668424165 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [beam] mwalenia commented on pull request #12453: [BEAM-9421] Add Java snippets to NLP documentation.

2020-08-03 Thread GitBox
mwalenia commented on pull request #12453: URL: https://github.com/apache/beam/pull/12453#issuecomment-668052572 Changes preview: https://apache-beam-website-pull-requests.storage.googleapis.com/12453/documentation/patterns/ai-platform/index.html --

[GitHub] [beam] mwalenia commented on pull request #12453: [BEAM-9421] Add Java snippets to NLP documentation.

2020-08-03 Thread GitBox
mwalenia commented on pull request #12453: URL: https://github.com/apache/beam/pull/12453#issuecomment-668049303 R: @aaltay can you take a look at this? This is an automated message from the Apache Git Service. To respond to