mxm commented on a change in pull request #11777:
URL: https://github.com/apache/beam/pull/11777#discussion_r428778698
##########
File path: sdks/python/apache_beam/transforms/trigger.py
##########
@@ -1368,7 +1368,7 @@ def _output(
if timestamp is None:
# If no watermark hold was set, output at end of window.
timestamp = window.max_timestamp()
- elif input_watermark < window.end and self.trigger_fn.has_ontime_pane():
+ elif output_watermark < window.end and self.trigger_fn.has_ontime_pane():
Review comment:
Note that this is the fix in question. Please check @rohdesamuel if that
makes sense.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
