[GitHub] [beam] pabloem commented on pull request #11086: [BEAM-8910] Make custom BQ source read from Avro

2020-06-15 Thread GitBox
pabloem commented on pull request #11086: URL: https://github.com/apache/beam/pull/11086#issuecomment-644458757 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [beam] pabloem commented on pull request #11086: [BEAM-8910] Make custom BQ source read from Avro

2020-06-15 Thread GitBox
pabloem commented on pull request #11086: URL: https://github.com/apache/beam/pull/11086#issuecomment-644455110 Run Python2_PVR_Flink PreCommit This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] pabloem commented on pull request #11086: [BEAM-8910] Make custom BQ source read from Avro

2020-06-15 Thread GitBox
pabloem commented on pull request #11086: URL: https://github.com/apache/beam/pull/11086#issuecomment-644418145 Run Python PreCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] pabloem commented on pull request #11086: [BEAM-8910] Make custom BQ source read from Avro

2020-06-15 Thread GitBox
pabloem commented on pull request #11086: URL: https://github.com/apache/beam/pull/11086#issuecomment-644257498 Run Python PreCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] pabloem commented on pull request #11086: [BEAM-8910] Make custom BQ source read from Avro

2020-06-14 Thread GitBox
pabloem commented on pull request #11086: URL: https://github.com/apache/beam/pull/11086#issuecomment-643807122 Run Python PreCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] pabloem commented on pull request #11086: [BEAM-8910] Make custom BQ source read from Avro

2020-06-13 Thread GitBox
pabloem commented on pull request #11086: URL: https://github.com/apache/beam/pull/11086#issuecomment-643680442 Run Python PreCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] pabloem commented on pull request #11086: [BEAM-8910] Make custom BQ source read from Avro

2020-06-12 Thread GitBox
pabloem commented on pull request #11086: URL: https://github.com/apache/beam/pull/11086#issuecomment-643505543 Run Python PreCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] pabloem commented on pull request #11086: [BEAM-8910] Make custom BQ source read from Avro

2020-06-12 Thread GitBox
pabloem commented on pull request #11086: URL: https://github.com/apache/beam/pull/11086#issuecomment-643470635 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [beam] pabloem commented on pull request #11086: [BEAM-8910] Make custom BQ source read from Avro

2020-06-12 Thread GitBox
pabloem commented on pull request #11086: URL: https://github.com/apache/beam/pull/11086#issuecomment-643470728 Run Python2_PVR_Flink PreCommit This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] pabloem commented on pull request #11086: [BEAM-8910] Make custom BQ source read from Avro

2020-06-11 Thread GitBox
pabloem commented on pull request #11086: URL: https://github.com/apache/beam/pull/11086#issuecomment-643055171 okay, in that case, the main points have been addressed. Any objections from merging? fyi @chamikaramj @tvalentyn @robertwb @kamilwu If no objections, I'll merge in a day

[GitHub] [beam] pabloem commented on pull request #11086: [BEAM-8910] Make custom BQ source read from Avro

2020-06-11 Thread GitBox
pabloem commented on pull request #11086: URL: https://github.com/apache/beam/pull/11086#issuecomment-642899088 @tvalentyn @chamikaramj thoughts? This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] pabloem commented on pull request #11086: [BEAM-8910] Make custom BQ source read from Avro

2020-06-09 Thread GitBox
pabloem commented on pull request #11086: URL: https://github.com/apache/beam/pull/11086#issuecomment-641652552 Run Python 3.7 PostCommit This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] pabloem commented on pull request #11086: [BEAM-8910] Make custom BQ source read from Avro

2020-06-09 Thread GitBox
pabloem commented on pull request #11086: URL: https://github.com/apache/beam/pull/11086#issuecomment-641607885 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [beam] pabloem commented on pull request #11086: [BEAM-8910] Make custom BQ source read from Avro

2020-06-09 Thread GitBox
pabloem commented on pull request #11086: URL: https://github.com/apache/beam/pull/11086#issuecomment-641603355 Run Python PreCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] pabloem commented on pull request #11086: [BEAM-8910] Make custom BQ source read from Avro

2020-06-09 Thread GitBox
pabloem commented on pull request #11086: URL: https://github.com/apache/beam/pull/11086#issuecomment-641588460 So, I think the last remaining issue was whether to have the `use_json_exports` flag or individual flags per columns. Are there other topics to discuss?

[GitHub] [beam] pabloem commented on pull request #11086: [BEAM-8910] Make custom BQ source read from Avro

2020-05-28 Thread GitBox
pabloem commented on pull request #11086: URL: https://github.com/apache/beam/pull/11086#issuecomment-635449147 Run Python2_PVR_Flink PreCommit This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] pabloem commented on pull request #11086: [BEAM-8910] Make custom BQ source read from Avro

2020-05-28 Thread GitBox
pabloem commented on pull request #11086: URL: https://github.com/apache/beam/pull/11086#issuecomment-635440442 Run Python 2 PostCommit This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] pabloem commented on pull request #11086: [BEAM-8910] Make custom BQ source read from Avro

2020-05-27 Thread GitBox
pabloem commented on pull request #11086: URL: https://github.com/apache/beam/pull/11086#issuecomment-635031678 Run Python PreCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] pabloem commented on pull request #11086: [BEAM-8910] Make custom BQ source read from Avro

2020-05-27 Thread GitBox
pabloem commented on pull request #11086: URL: https://github.com/apache/beam/pull/11086#issuecomment-635031588 py2 failure is hdfs integration test This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] pabloem commented on pull request #11086: [BEAM-8910] Make custom BQ source read from Avro

2020-05-27 Thread GitBox
pabloem commented on pull request #11086: URL: https://github.com/apache/beam/pull/11086#issuecomment-634947671 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [beam] pabloem commented on pull request #11086: [BEAM-8910] Make custom BQ source read from Avro

2020-05-21 Thread GitBox
pabloem commented on pull request #11086: URL: https://github.com/apache/beam/pull/11086#issuecomment-632277003 Run Python2_PVR_Flink PreCommit This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] pabloem commented on pull request #11086: [BEAM-8910] Make custom BQ source read from Avro

2020-05-20 Thread GitBox
pabloem commented on pull request #11086: URL: https://github.com/apache/beam/pull/11086#issuecomment-631609774 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [beam] pabloem commented on pull request #11086: [BEAM-8910] Make custom BQ source read from Avro

2020-05-15 Thread GitBox
pabloem commented on pull request #11086: URL: https://github.com/apache/beam/pull/11086#issuecomment-629436995 Run Python 3.7 PostCommit This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] pabloem commented on pull request #11086: [BEAM-8910] Make custom BQ source read from Avro

2020-05-09 Thread GitBox
pabloem commented on pull request #11086: URL: https://github.com/apache/beam/pull/11086#issuecomment-626277631 Run Python 3.7 PostCommit This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] pabloem commented on pull request #11086: [BEAM-8910] Make custom BQ source read from Avro

2020-05-09 Thread GitBox
pabloem commented on pull request #11086: URL: https://github.com/apache/beam/pull/11086#issuecomment-626259948 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] pabloem commented on pull request #11086: [BEAM-8910] Make custom BQ source read from Avro

2020-05-09 Thread GitBox
pabloem commented on pull request #11086: URL: https://github.com/apache/beam/pull/11086#issuecomment-626214612 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] pabloem commented on pull request #11086: [BEAM-8910] Make custom BQ source read from Avro

2020-05-08 Thread GitBox
pabloem commented on pull request #11086: URL: https://github.com/apache/beam/pull/11086#issuecomment-625999573 Run Python 2 PostCommit This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] pabloem commented on pull request #11086: [BEAM-8910] Make custom BQ source read from Avro

2020-05-06 Thread GitBox
pabloem commented on pull request #11086: URL: https://github.com/apache/beam/pull/11086#issuecomment-624879527 Run Python 2 PostCommit This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] pabloem commented on pull request #11086: [BEAM-8910] Make custom BQ source read from Avro

2020-05-05 Thread GitBox
pabloem commented on pull request #11086: URL: https://github.com/apache/beam/pull/11086#issuecomment-624431077 Run PythonDocker PreCommit This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] pabloem commented on pull request #11086: [BEAM-8910] Make custom BQ source read from Avro

2020-05-05 Thread GitBox
pabloem commented on pull request #11086: URL: https://github.com/apache/beam/pull/11086#issuecomment-624431173 Run Python2_PVR_Flink PreCommit This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] pabloem commented on pull request #11086: [BEAM-8910] Make custom BQ source read from Avro

2020-05-05 Thread GitBox
pabloem commented on pull request #11086: URL: https://github.com/apache/beam/pull/11086#issuecomment-624430895 Run Python 2 PostCommit This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] pabloem commented on pull request #11086: [BEAM-8910] Make custom BQ source read from Avro

2020-05-05 Thread GitBox
pabloem commented on pull request #11086: URL: https://github.com/apache/beam/pull/11086#issuecomment-624431013 Run Python PreCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] pabloem commented on pull request #11086: [BEAM-8910] Make custom BQ source read from Avro

2020-05-05 Thread GitBox
pabloem commented on pull request #11086: URL: https://github.com/apache/beam/pull/11086#issuecomment-624370689 Run Python 3.7 PostCommit This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] pabloem commented on pull request #11086: [BEAM-8910] Make custom BQ source read from Avro

2020-05-05 Thread GitBox
pabloem commented on pull request #11086: URL: https://github.com/apache/beam/pull/11086#issuecomment-624356609 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [beam] pabloem commented on pull request #11086: [BEAM-8910] Make custom BQ source read from Avro

2020-05-05 Thread GitBox
pabloem commented on pull request #11086: URL: https://github.com/apache/beam/pull/11086#issuecomment-624209882 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [beam] pabloem commented on pull request #11086: [BEAM-8910] Make custom BQ source read from Avro

2020-05-04 Thread GitBox
pabloem commented on pull request #11086: URL: https://github.com/apache/beam/pull/11086#issuecomment-623800613 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [beam] pabloem commented on pull request #11086: [BEAM-8910] Make custom BQ source read from Avro

2020-04-30 Thread GitBox
pabloem commented on pull request #11086: URL: https://github.com/apache/beam/pull/11086#issuecomment-622212861 Run Python 3.7 PostCommit This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] pabloem commented on pull request #11086: [BEAM-8910] Make custom BQ source read from Avro

2020-04-30 Thread GitBox
pabloem commented on pull request #11086: URL: https://github.com/apache/beam/pull/11086#issuecomment-622212825 > Thanks Pablo. > > 1. Can we take another look at a big comment at the beginning of bigquery.py and see if it needs an update. It sounds like we now have two ways of