[GitHub] [beam] rahul8383 commented on pull request #11581: [BEAM-8307] NPE in Calcite dialect when input PCollection has logical…

2020-05-09 Thread GitBox
rahul8383 commented on pull request #11581: URL: https://github.com/apache/beam/pull/11581#issuecomment-626139548 R: @TheNeuralBit I found a bug while implementing this feature and raised PR #11609 to fix the bug as I thought that the bug fix could be cherry-picked in 2.21.0

[GitHub] [beam] rahul8383 commented on pull request #11581: [BEAM-8307] NPE in Calcite dialect when input PCollection has logical…

2020-05-01 Thread GitBox
rahul8383 commented on pull request #11581: URL: https://github.com/apache/beam/pull/11581#issuecomment-622661943 I will make the necessary changes as suggested by @TheNeuralBit in

[GitHub] [beam] rahul8383 commented on pull request #11581: [BEAM-8307] NPE in Calcite dialect when input PCollection has logical…

2020-05-01 Thread GitBox
rahul8383 commented on pull request #11581: URL: https://github.com/apache/beam/pull/11581#issuecomment-622652488 JdbcIO.Read -> SqlTransform.query(SELECT COUNT(*) FROM PCOLLECTION //Any query ) would throw NPE if the input PCollection to SqlTransform JdbcIO specific Logical Types in its

[GitHub] [beam] rahul8383 commented on pull request #11581: [BEAM-8307] NPE in Calcite dialect when input PCollection has logical…

2020-05-01 Thread GitBox
rahul8383 commented on pull request #11581: URL: https://github.com/apache/beam/pull/11581#issuecomment-622308296 I agree that this is not a scalable solution. Providing a Calcite RelDataType Mapping for every Logical Type defined(which is the solution presented in this PR) by every IO is

[GitHub] [beam] rahul8383 commented on pull request #11581: [BEAM-8307] NPE in Calcite dialect when input PCollection has logical…

2020-05-01 Thread GitBox
rahul8383 commented on pull request #11581: URL: https://github.com/apache/beam/pull/11581#issuecomment-622277282 @reuvenlax I have provided the source table schema and attached the NPE that I have faced in [BEAM-8307](https://issues.apache.org/jira/browse/BEAM-8307) NPE is

[GitHub] [beam] rahul8383 commented on pull request #11581: [BEAM-8307] NPE in Calcite dialect when input PCollection has logical…

2020-04-30 Thread GitBox
rahul8383 commented on pull request #11581: URL: https://github.com/apache/beam/pull/11581#issuecomment-622049393 R: @reuvenlax @amaliujia @iemejia This is an automated message from the Apache Git Service. To respond to the