rahul8383 commented on pull request #11609:
URL: https://github.com/apache/beam/pull/11609#issuecomment-626140088
> I'd be +1 for just dropping the padding logic. I don't think it should be
the responsibility of the LogicalType to coerce values like this. What do you
think @reuvenlax?
rahul8383 commented on pull request #11609:
URL: https://github.com/apache/beam/pull/11609#issuecomment-626139746
If there are no comments, can we close this PR?
This is an automated message from the Apache Git Service.
To
rahul8383 commented on pull request #11609:
URL: https://github.com/apache/beam/pull/11609#issuecomment-624906438
> This seems to be a holdover. Previously Row stored logical type values as
their base type, so we probably called `toBaseType(toInputType(x))`.
Even before the code
rahul8383 commented on pull request #11609:
URL: https://github.com/apache/beam/pull/11609#issuecomment-624360661
> We always convert logical types to their base type when serializing with
SchemaCoder, and convert back to the input type when deserializing. Other than
that I think the only
rahul8383 commented on pull request #11609:
URL: https://github.com/apache/beam/pull/11609#issuecomment-624160514
@reuvenlax @TheNeuralBit
Thanks for the review.
Could you please clarify the questions that I have asked above?
I wanted to understand more about logical types for my
rahul8383 commented on pull request #11609:
URL: https://github.com/apache/beam/pull/11609#issuecomment-624153984
@TheNeuralBit
schemas.logicaltypes.LogicalTypesTest.testFixedBytesIllegalArgument Test
will fail even if addValue() method is used instead of withFieldValue() method.
