[GitHub] [beam] robertwb commented on a change in pull request #11765: [BEAM-9322] Remove passthrough_pcollection_output_ids and force_generated_pcollection_output_ids flags
robertwb commented on a change in pull request #11765: URL: https://github.com/apache/beam/pull/11765#discussion_r438299971 ## File path: sdks/python/apache_beam/transforms/ptransform.py ## @@ -270,11 +256,19 @@ def get_named_nested_pvalues(pvalueish): tagged_values = pvalueish.items() else: if isinstance(pvalueish, (pvalue.PValue, pvalue.DoOutputsTuple)): - yield None, pvalueish + # For transforms that only have a tagged PCollection as an output, + # propagate that tag forward. + if first_iteration and isinstance(pvalueish, pvalue.PValue): +yield pvalueish.tag, pvalueish Review comment: We can remove this now that the TestStream change is going in right? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [beam] robertwb commented on a change in pull request #11765: [BEAM-9322] Remove passthrough_pcollection_output_ids and force_generated_pcollection_output_ids flags
robertwb commented on a change in pull request #11765: URL: https://github.com/apache/beam/pull/11765#discussion_r428960780 ## File path: sdks/python/apache_beam/transforms/ptransform.py ## @@ -270,11 +256,19 @@ def get_named_nested_pvalues(pvalueish): tagged_values = pvalueish.items() else: if isinstance(pvalueish, (pvalue.PValue, pvalue.DoOutputsTuple)): - yield None, pvalueish + # For transforms that only have a tagged PCollection as an output, + # propagate that tag forward. + if first_iteration and isinstance(pvalueish, pvalue.PValue): +yield pvalueish.tag, pvalueish Review comment: I think this may break some google3 runners. Can you ensure that this imports correctly? (Could you also explain why this is needed?) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
