[GitHub] [beam] udim commented on a change in pull request #11939: [BEAM-10197] Support typehints for Python's frozenset

2020-06-15 Thread GitBox
udim commented on a change in pull request #11939: URL: https://github.com/apache/beam/pull/11939#discussion_r440536984 ## File path: sdks/python/apache_beam/typehints/typehints.py ## @@ -435,10 +435,14 @@ def type_check(self, instance): class TypeVariable(AnyTypeConstrain

[GitHub] [beam] udim commented on a change in pull request #11939: [BEAM-10197] Support typehints for Python's frozenset

2020-06-09 Thread GitBox
udim commented on a change in pull request #11939: URL: https://github.com/apache/beam/pull/11939#discussion_r436908464 ## File path: sdks/python/apache_beam/typehints/typehints_test.py ## @@ -612,54 +613,70 @@ def test_match_type_variables(self): hint.mat

[GitHub] [beam] udim commented on a change in pull request #11939: [BEAM-10197] Support typehints for Python's frozenset

2020-06-05 Thread GitBox
udim commented on a change in pull request #11939: URL: https://github.com/apache/beam/pull/11939#discussion_r436187871 ## File path: sdks/python/apache_beam/typehints/typehints_test.py ## @@ -612,54 +613,70 @@ def test_match_type_variables(self): hint.mat