[GitHub] [beam] udim commented on pull request #11070: [BEAM-8280] Blog post: Python typing changes

2020-05-28 Thread GitBox


udim commented on pull request #11070:
URL: https://github.com/apache/beam/pull/11070#issuecomment-635472111


   Any other comments, okay to publish?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [beam] udim commented on pull request #11070: [BEAM-8280] Blog post: Python typing changes

2020-05-22 Thread GitBox


udim commented on pull request #11070:
URL: https://github.com/apache/beam/pull/11070#issuecomment-632506918


   CC: @robertwb 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [beam] udim commented on pull request #11070: [BEAM-8280] Blog post: Python typing changes

2020-05-22 Thread GitBox


udim commented on pull request #11070:
URL: https://github.com/apache/beam/pull/11070#issuecomment-632506706


   PTAL. Preview is here:
   
http://apache-beam-website-pull-requests.storage.googleapis.com/11070/blog/python-typing/index.html



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [beam] udim commented on pull request #11070: [BEAM-8280] Blog post: Python typing changes

2020-05-21 Thread GitBox


udim commented on pull request #11070:
URL: https://github.com/apache/beam/pull/11070#issuecomment-632433800


   I've squashed the commits to more easily rename the file. Optimistically 
merging by May 26! :)



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [beam] udim commented on pull request #11070: [BEAM-8280] Blog post: Python typing changes

2020-05-15 Thread GitBox


udim commented on pull request #11070:
URL: https://github.com/apache/beam/pull/11070#issuecomment-629360659


   > > @chadrik, do you have the "edit file" option available?
   > 
   > Nope :(
   
   I think that maybe it's because you're not on 
https://github.com/orgs/apache/teams/beam-committers ? (you are on 
https://github.com/orgs/apache/teams/apache-committers though)
   Maybe ask on the mailing list.
   
   Meanwhile, if you make suggestions I think that'd be easiest. (I hope)



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [beam] udim commented on pull request #11070: [BEAM-8280] Blog post: Python typing changes

2020-05-15 Thread GitBox


udim commented on pull request #11070:
URL: https://github.com/apache/beam/pull/11070#issuecomment-629344436


   > Hi @udim I have my edits ready, but I can't push to this branch. I can 
make an PR against it, if you'd like. There's an option for each PR to "allow 
edits from maintainers", which could help, but I'm not sure if I'm considered a 
Beam maintainer or not.
   > 
   > Alternately, I can provide my edits as "suggestions" in a review, and you 
can apply them that way.
   
   @chadrik, do you have the "edit file" option available?
   
![xns3dSvObwH](https://user-images.githubusercontent.com/127695/82071819-7a052700-968b-11ea-990c-452cb5d04b5e.png)
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org