[GitHub] [beam] udim commented on pull request #12009: [BEAM-10258] Support type hint annotations on PTransform's expand()

2020-07-31 Thread GitBox
udim commented on pull request #12009: URL: https://github.com/apache/beam/pull/12009#issuecomment-667445932 Run Python2_PVR_Flink PreCommit This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] udim commented on pull request #12009: [BEAM-10258] Support type hint annotations on PTransform's expand()

2020-07-31 Thread GitBox
udim commented on pull request #12009: URL: https://github.com/apache/beam/pull/12009#issuecomment-667296451 running internal tests This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [beam] udim commented on pull request #12009: [BEAM-10258] Support type hint annotations on PTransform's expand()

2020-07-30 Thread GitBox
udim commented on pull request #12009: URL: https://github.com/apache/beam/pull/12009#issuecomment-31741 Run Python2_PVR_Flink PreCommit This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] udim commented on pull request #12009: [BEAM-10258] Support type hint annotations on PTransform's expand()

2020-07-29 Thread GitBox
udim commented on pull request #12009: URL: https://github.com/apache/beam/pull/12009#issuecomment-664632940 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [beam] udim commented on pull request #12009: [BEAM-10258] Support type hint annotations on PTransform's expand()

2020-06-30 Thread GitBox
udim commented on pull request #12009: URL: https://github.com/apache/beam/pull/12009#issuecomment-652079902 @saavan-google-intern I haven't taken a close look, but the failing tests could be due changes in this PR. PTAL Thi

[GitHub] [beam] udim commented on pull request #12009: [BEAM-10258] Support type hint annotations on PTransform's expand()

2020-06-29 Thread GitBox
udim commented on pull request #12009: URL: https://github.com/apache/beam/pull/12009#issuecomment-651396234 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [beam] udim commented on pull request #12009: [BEAM-10258] Support type hint annotations on PTransform's expand()

2020-06-29 Thread GitBox
udim commented on pull request #12009: URL: https://github.com/apache/beam/pull/12009#issuecomment-651395927 adsfdf This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [beam] udim commented on pull request #12009: [BEAM-10258] Support type hint annotations on PTransform's expand()

2020-06-25 Thread GitBox
udim commented on pull request #12009: URL: https://github.com/apache/beam/pull/12009#issuecomment-649924273 > The two functions **strip_pcoll_input** and **strip_pcoll_output_** are very similar. Could be refactored into one function. What do you think Yeah, they do look similar eno

[GitHub] [beam] udim commented on pull request #12009: [BEAM-10258] Support type hint annotations on PTransform's expand()

2020-06-24 Thread GitBox
udim commented on pull request #12009: URL: https://github.com/apache/beam/pull/12009#issuecomment-649145031 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [beam] udim commented on pull request #12009: [BEAM-10258] Support type hint annotations on PTransform's expand()

2020-06-23 Thread GitBox
udim commented on pull request #12009: URL: https://github.com/apache/beam/pull/12009#issuecomment-648498242 Let's see This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH