[GitHub] [beam] y1chi commented on a change in pull request #11756: [BEAM-9603] Add timer family support to FnApiDoFnRunner

2020-05-21 Thread GitBox
y1chi commented on a change in pull request #11756: URL: https://github.com/apache/beam/pull/11756#discussion_r428754395 ## File path: sdks/java/harness/src/test/java/org/apache/beam/fn/harness/FnApiDoFnRunnerTest.java ## @@ -947,49 +910,213 @@ public void testTimers() throws

[GitHub] [beam] y1chi commented on a change in pull request #11756: [BEAM-9603] Add timer family support to FnApiDoFnRunner

2020-05-20 Thread GitBox
y1chi commented on a change in pull request #11756: URL: https://github.com/apache/beam/pull/11756#discussion_r428242655 ## File path: sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnApiDoFnRunner.java ## @@ -460,14 +461,22 @@ public void accept(WindowedValue

[GitHub] [beam] y1chi commented on a change in pull request #11756: [BEAM-9603] Add timer family support to FnApiDoFnRunner

2020-05-20 Thread GitBox
y1chi commented on a change in pull request #11756: URL: https://github.com/apache/beam/pull/11756#discussion_r428241263 ## File path: sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnApiDoFnRunner.java ## @@ -1207,15 +1224,51 @@ private void output(Instant

[GitHub] [beam] y1chi commented on a change in pull request #11756: [BEAM-9603] Add timer family support to FnApiDoFnRunner

2020-05-20 Thread GitBox
y1chi commented on a change in pull request #11756: URL: https://github.com/apache/beam/pull/11756#discussion_r428241083 ## File path: sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnApiDoFnRunner.java ## @@ -460,14 +461,22 @@ public void accept(WindowedValue

[GitHub] [beam] y1chi commented on a change in pull request #11756: [BEAM-9603] Add timer family support to FnApiDoFnRunner

2020-05-20 Thread GitBox
y1chi commented on a change in pull request #11756: URL: https://github.com/apache/beam/pull/11756#discussion_r427759019 ## File path: sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnApiDoFnRunner.java ## @@ -1207,15 +1224,51 @@ private void output(Instant

[GitHub] [beam] y1chi commented on a change in pull request #11756: [BEAM-9603] Add timer family support to FnApiDoFnRunner

2020-05-19 Thread GitBox
y1chi commented on a change in pull request #11756: URL: https://github.com/apache/beam/pull/11756#discussion_r427758607 ## File path: sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnApiDoFnRunner.java ## @@ -1207,15 +1224,51 @@ private void output(Instant

[GitHub] [beam] y1chi commented on a change in pull request #11756: [BEAM-9603] Add timer family support to FnApiDoFnRunner

2020-05-19 Thread GitBox
y1chi commented on a change in pull request #11756: URL: https://github.com/apache/beam/pull/11756#discussion_r427738041 ## File path: sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnApiDoFnRunner.java ## @@ -1207,15 +1224,51 @@ private void output(Instant

[GitHub] [beam] y1chi commented on a change in pull request #11756: [BEAM-9603] Add timer family support to FnApiDoFnRunner

2020-05-19 Thread GitBox
y1chi commented on a change in pull request #11756: URL: https://github.com/apache/beam/pull/11756#discussion_r427737289 ## File path: sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnApiDoFnRunner.java ## @@ -962,16 +971,25 @@ private Progress getProgress() {