timsaucer commented on PR #1074:
URL:
https://github.com/apache/datafusion-python/pull/1074#issuecomment-2833517926
I must have missed that CI didn't run on this. We have a circular import and
broke CI on `main`.
--
This is an automated message from the Apache Git Service.
To respond to
timsaucer merged PR #1074:
URL: https://github.com/apache/datafusion-python/pull/1074
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...
deanm commented on PR #1074:
URL:
https://github.com/apache/datafusion-python/pull/1074#issuecomment-2741334821
I wrote this script to help produce this PR. I wanted to start with just the
functions which have a single Expr input that return an Expr. The script writes
all those defs to
timsaucer commented on PR #1074:
URL:
https://github.com/apache/datafusion-python/pull/1074#issuecomment-2745373049
At a high level I like some of the aspects of a namespace. It would
especially be nice to clean up our documentation using them in `functions`. I
haven't thought through what
deanm commented on PR #1074:
URL:
https://github.com/apache/datafusion-python/pull/1074#issuecomment-2745350211
@timsaucer did you have any thoughts on the namespaces because going from
this to that would wind up being a breaking change.
--
This is an automated message from the Apach
deanm commented on PR #1074:
URL:
https://github.com/apache/datafusion-python/pull/1074#issuecomment-2745349544
I'll mark it ready and just do a second PR for more methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
timsaucer commented on PR #1074:
URL:
https://github.com/apache/datafusion-python/pull/1074#issuecomment-2745345097
I do love this PR. I hadn't looked at it since it's in draft, but I fully
endorse.
--
This is an automated message from the Apache Git Service.
To respond to the message,
timsaucer commented on PR #1074:
URL:
https://github.com/apache/datafusion-python/pull/1074#issuecomment-2745345231
Let me know when it's ready for review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
deanm opened a new pull request, #1074:
URL: https://github.com/apache/datafusion-python/pull/1074
# Which issue does this PR close?
Works towards closing #1064
# Rationale for this change
To improve ergonomics of the API by adding functions to the Expr class so
th
